MIRRORS/linux-yocto
1
0
Fork 0
mirror of git://git.yoctoproject.org/linux-yocto.git synced 2025-10-23 07:23:12 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

ALSA: usb-audio: qcom: Adjust mutex unlock order

Browse Source 
The mutexes qdev_mutex and chip->mutex are acquired in that order
throughout the driver. To preserve proper lock hierarchy and avoid
potential deadlocks, they must be released in the reverse
order of acquisition.

This change reorders the unlock sequence to first release chip->mutex
followed by qdev_mutex, ensuring consistency with the locking pattern.

[ fixed the code indentations and Fixes tag by tiwai ]

Fixes: 326bbc3482 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://patch.msgid.link/20250721114554.1666104-1-karanja99erick@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Erick Karanja 2025-07-21 14:45:53 +03:00 committed by Takashi Iwai
parent 9744ede709
commit 48915162b5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sound/usb/qcom/qc_audio_offload.c
View File

@ -825,8 +825,8 @@ static int uaudio_sideband_notifier(struct usb_interface *intf,
}
}
mutex_unlock(&qdev_mutex);
mutex_unlock(&chip->mutex);
mutex_unlock(&qdev_mutex);
return 0;
}
@ -1865,8 +1865,8 @@ static void qc_usb_audio_offload_disconnect(struct snd_usb_audio *chip)
/* Device has already been cleaned up, or never populated */
if (!dev->chip) {
mutex_unlock(&qdev_mutex);
mutex_unlock(&chip->mutex);
mutex_unlock(&qdev_mutex);
return;
}
@ -1921,8 +1921,8 @@ static void qc_usb_audio_offload_suspend(struct usb_interface *intf,
uaudio_send_disconnect_ind(chip);
mutex_unlock(&qdev_mutex);
mutex_unlock(&chip->mutex);
mutex_unlock(&qdev_mutex);
}
static struct snd_usb_platform_ops offload_ops = {