MIRRORS/linux-yocto
1
0
Fork 0
mirror of git://git.yoctoproject.org/linux-yocto.git synced 2025-10-23 07:23:12 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

configfs-tsm: Namespace TSM report symbols

Browse Source 
In preparation for new + common TSM (TEE Security Manager)
infrastructure, namespace the TSM report symbols in tsm.h with an
_REPORT suffix to differentiate them from other incoming tsm work.

Cc: Yilun Xu <yilun.xu@intel.com>
Cc: Samuel Ortiz <sameo@rivosinc.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Steven Price <steven.price@arm.com>
Reviewed-by: Alexey Kardashevskiy <aik@amd.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://patch.msgid.link/174107246021.1288555.7203769833791489618.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2025-03-03 23:14:20 -08:00
parent 8ffd015db8
commit 71ded61bee
7 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
Documentation/ABI/testing/configfs-tsm → Documentation/ABI/testing/configfs-tsm-report
View File

2
MAINTAINERS
View File

@ -24559,7 +24559,7 @@ TRUSTED SECURITY MODULE (TSM) ATTESTATION REPORTS
M: Dan Williams <dan.j.williams@intel.com> M: Dan Williams <dan.j.williams@intel.com>
L: linux-coco@lists.linux.dev L: linux-coco@lists.linux.dev
S: Maintained S: Maintained
F: Documentation/ABI/testing/configfs-tsm F: Documentation/ABI/testing/configfs-tsm-report
F: drivers/virt/coco/tsm.c F: drivers/virt/coco/tsm.c
F: include/linux/tsm.h F: include/linux/tsm.h

8
drivers/virt/coco/arm-cca-guest/arm-cca-guest.c
View File

@ -96,7 +96,7 @@ static int arm_cca_report_new(struct tsm_report *report, void *data)
struct arm_cca_token_info info; struct arm_cca_token_info info;
void *buf; void *buf;
u8 *token __free(kvfree) = NULL; u8 *token __free(kvfree) = NULL;
struct tsm_desc *desc = &report->desc; struct tsm_report_desc *desc = &report->desc;
if (desc->inblob_len < 32 || desc->inblob_len > 64) if (desc->inblob_len < 32 || desc->inblob_len > 64)
return -EINVAL; return -EINVAL;
@ -181,7 +181,7 @@ exit_free_granule_page:
return ret; return ret;
} }
static const struct tsm_ops arm_cca_tsm_ops = { static const struct tsm_report_ops arm_cca_tsm_ops = {
.name = KBUILD_MODNAME, .name = KBUILD_MODNAME,
.report_new = arm_cca_report_new, .report_new = arm_cca_report_new,
}; };
@ -202,7 +202,7 @@ static int __init arm_cca_guest_init(void)
if (!is_realm_world()) if (!is_realm_world())
return -ENODEV; return -ENODEV;
ret = tsm_register(&arm_cca_tsm_ops, NULL); ret = tsm_report_register(&arm_cca_tsm_ops, NULL);
if (ret < 0) if (ret < 0)
pr_err("Error %d registering with TSM\n", ret); pr_err("Error %d registering with TSM\n", ret);
@ -216,7 +216,7 @@ module_init(arm_cca_guest_init);
*/ */
static void __exit arm_cca_guest_exit(void) static void __exit arm_cca_guest_exit(void)
{ {
tsm_unregister(&arm_cca_tsm_ops); tsm_report_unregister(&arm_cca_tsm_ops);
} }
module_exit(arm_cca_guest_exit); module_exit(arm_cca_guest_exit);

12
drivers/virt/coco/sev-guest/sev-guest.c
View File

@ -346,7 +346,7 @@ struct snp_msg_cert_entry {
static int sev_svsm_report_new(struct tsm_report *report, void *data) static int sev_svsm_report_new(struct tsm_report *report, void *data)
{ {
unsigned int rep_len, man_len, certs_len; unsigned int rep_len, man_len, certs_len;
struct tsm_desc *desc = &report->desc; struct tsm_report_desc *desc = &report->desc;
struct svsm_attest_call ac = {}; struct svsm_attest_call ac = {};
unsigned int retry_count; unsigned int retry_count;
void *rep, *man, *certs; void *rep, *man, *certs;
@ -481,7 +481,7 @@ retry:
static int sev_report_new(struct tsm_report *report, void *data) static int sev_report_new(struct tsm_report *report, void *data)
{ {
struct snp_msg_cert_entry *cert_table; struct snp_msg_cert_entry *cert_table;
struct tsm_desc *desc = &report->desc; struct tsm_report_desc *desc = &report->desc;
struct snp_guest_dev *snp_dev = data; struct snp_guest_dev *snp_dev = data;
struct snp_msg_report_resp_hdr hdr; struct snp_msg_report_resp_hdr hdr;
const u32 report_size = SZ_4K; const u32 report_size = SZ_4K;
@ -610,7 +610,7 @@ static bool sev_report_bin_attr_visible(int n)
return false; return false;
} }
static struct tsm_ops sev_tsm_ops = { static struct tsm_report_ops sev_tsm_report_ops = {
.name = KBUILD_MODNAME, .name = KBUILD_MODNAME,
.report_new = sev_report_new, .report_new = sev_report_new,
.report_attr_visible = sev_report_attr_visible, .report_attr_visible = sev_report_attr_visible,
@ -619,7 +619,7 @@ static struct tsm_ops sev_tsm_ops = {
static void unregister_sev_tsm(void *data) static void unregister_sev_tsm(void *data)
{ {
tsm_unregister(&sev_tsm_ops); tsm_report_unregister(&sev_tsm_report_ops);
} }
static int __init sev_guest_probe(struct platform_device *pdev) static int __init sev_guest_probe(struct platform_device *pdev)
@ -656,9 +656,9 @@ static int __init sev_guest_probe(struct platform_device *pdev)
misc->fops = &snp_guest_fops; misc->fops = &snp_guest_fops;
/* Set the privlevel_floor attribute based on the vmpck_id */ /* Set the privlevel_floor attribute based on the vmpck_id */
sev_tsm_ops.privlevel_floor = mdesc->vmpck_id; sev_tsm_report_ops.privlevel_floor = mdesc->vmpck_id;
ret = tsm_register(&sev_tsm_ops, snp_dev); ret = tsm_report_register(&sev_tsm_report_ops, snp_dev);
if (ret) if (ret)
goto e_msg_init; goto e_msg_init;

8
drivers/virt/coco/tdx-guest/tdx-guest.c
View File

@ -161,7 +161,7 @@ static int tdx_report_new(struct tsm_report *report, void *data)
{ {
u8 *buf, *reportdata = NULL, *tdreport = NULL; u8 *buf, *reportdata = NULL, *tdreport = NULL;
struct tdx_quote_buf *quote_buf = quote_data; struct tdx_quote_buf *quote_buf = quote_data;
struct tsm_desc *desc = &report->desc; struct tsm_report_desc *desc = &report->desc;
int ret; int ret;
u64 err; u64 err;
@ -297,7 +297,7 @@ static const struct x86_cpu_id tdx_guest_ids[] = {
}; };
MODULE_DEVICE_TABLE(x86cpu, tdx_guest_ids); MODULE_DEVICE_TABLE(x86cpu, tdx_guest_ids);
static const struct tsm_ops tdx_tsm_ops = { static const struct tsm_report_ops tdx_tsm_ops = {
.name = KBUILD_MODNAME, .name = KBUILD_MODNAME,
.report_new = tdx_report_new, .report_new = tdx_report_new,
.report_attr_visible = tdx_report_attr_visible, .report_attr_visible = tdx_report_attr_visible,
@ -322,7 +322,7 @@ static int __init tdx_guest_init(void)
goto free_misc; goto free_misc;
} }
ret = tsm_register(&tdx_tsm_ops, NULL); ret = tsm_report_register(&tdx_tsm_ops, NULL);
if (ret) if (ret)
goto free_quote; goto free_quote;
@ -339,7 +339,7 @@ module_init(tdx_guest_init);
static void __exit tdx_guest_exit(void) static void __exit tdx_guest_exit(void)
{ {
tsm_unregister(&tdx_tsm_ops); tsm_report_unregister(&tdx_tsm_ops);
free_quote_buf(quote_data); free_quote_buf(quote_data);
misc_deregister(&tdx_misc_dev); misc_deregister(&tdx_misc_dev);
} }

32
drivers/virt/coco/tsm.c
View File

@ -13,7 +13,7 @@
#include <linux/configfs.h> #include <linux/configfs.h>
static struct tsm_provider { static struct tsm_provider {
const struct tsm_ops *ops; const struct tsm_report_ops *ops;
void *data; void *data;
} provider; } provider;
static DECLARE_RWSEM(tsm_rwsem); static DECLARE_RWSEM(tsm_rwsem);
@ -98,7 +98,7 @@ static ssize_t tsm_report_privlevel_store(struct config_item *cfg,
* SEV-SNP GHCB) and a minimum of a TSM selected floor value no less * SEV-SNP GHCB) and a minimum of a TSM selected floor value no less
* than 0. * than 0.
*/ */
if (provider.ops->privlevel_floor > val || val > TSM_PRIVLEVEL_MAX) if (provider.ops->privlevel_floor > val || val > TSM_REPORT_PRIVLEVEL_MAX)
return -EINVAL; return -EINVAL;
guard(rwsem_write)(&tsm_rwsem); guard(rwsem_write)(&tsm_rwsem);
@ -202,7 +202,7 @@ static ssize_t tsm_report_inblob_write(struct config_item *cfg,
memcpy(report->desc.inblob, buf, count); memcpy(report->desc.inblob, buf, count);
return count; return count;
} }
CONFIGFS_BIN_ATTR_WO(tsm_report_, inblob, NULL, TSM_INBLOB_MAX); CONFIGFS_BIN_ATTR_WO(tsm_report_, inblob, NULL, TSM_REPORT_INBLOB_MAX);
static ssize_t tsm_report_generation_show(struct config_item *cfg, char *buf) static ssize_t tsm_report_generation_show(struct config_item *cfg, char *buf)
{ {
@ -272,7 +272,7 @@ static ssize_t tsm_report_read(struct tsm_report *report, void *buf,
size_t count, enum tsm_data_select select) size_t count, enum tsm_data_select select)
{ {
struct tsm_report_state *state = to_state(report); struct tsm_report_state *state = to_state(report);
const struct tsm_ops *ops; const struct tsm_report_ops *ops;
ssize_t rc; ssize_t rc;
/* try to read from the existing report if present and valid... */ /* try to read from the existing report if present and valid... */
@ -314,7 +314,7 @@ static ssize_t tsm_report_outblob_read(struct config_item *cfg, void *buf,
return tsm_report_read(report, buf, count, TSM_REPORT); return tsm_report_read(report, buf, count, TSM_REPORT);
} }
CONFIGFS_BIN_ATTR_RO(tsm_report_, outblob, NULL, TSM_OUTBLOB_MAX); CONFIGFS_BIN_ATTR_RO(tsm_report_, outblob, NULL, TSM_REPORT_OUTBLOB_MAX);
static ssize_t tsm_report_auxblob_read(struct config_item *cfg, void *buf, static ssize_t tsm_report_auxblob_read(struct config_item *cfg, void *buf,
size_t count) size_t count)
@ -323,7 +323,7 @@ static ssize_t tsm_report_auxblob_read(struct config_item *cfg, void *buf,
return tsm_report_read(report, buf, count, TSM_CERTS); return tsm_report_read(report, buf, count, TSM_CERTS);
} }
CONFIGFS_BIN_ATTR_RO(tsm_report_, auxblob, NULL, TSM_OUTBLOB_MAX); CONFIGFS_BIN_ATTR_RO(tsm_report_, auxblob, NULL, TSM_REPORT_OUTBLOB_MAX);
static ssize_t tsm_report_manifestblob_read(struct config_item *cfg, void *buf, static ssize_t tsm_report_manifestblob_read(struct config_item *cfg, void *buf,
size_t count) size_t count)
@ -332,7 +332,7 @@ static ssize_t tsm_report_manifestblob_read(struct config_item *cfg, void *buf,
return tsm_report_read(report, buf, count, TSM_MANIFEST); return tsm_report_read(report, buf, count, TSM_MANIFEST);
} }
CONFIGFS_BIN_ATTR_RO(tsm_report_, manifestblob, NULL, TSM_OUTBLOB_MAX); CONFIGFS_BIN_ATTR_RO(tsm_report_, manifestblob, NULL, TSM_REPORT_OUTBLOB_MAX);
static struct configfs_attribute *tsm_report_attrs[] = { static struct configfs_attribute *tsm_report_attrs[] = {
[TSM_REPORT_GENERATION] = &tsm_report_attr_generation, [TSM_REPORT_GENERATION] = &tsm_report_attr_generation,
@ -448,9 +448,9 @@ static struct configfs_subsystem tsm_configfs = {
.su_mutex = __MUTEX_INITIALIZER(tsm_configfs.su_mutex), .su_mutex = __MUTEX_INITIALIZER(tsm_configfs.su_mutex),
}; };
int tsm_register(const struct tsm_ops *ops, void *priv) int tsm_report_register(const struct tsm_report_ops *ops, void *priv)
{ {
const struct tsm_ops *conflict; const struct tsm_report_ops *conflict;
guard(rwsem_write)(&tsm_rwsem); guard(rwsem_write)(&tsm_rwsem);
conflict = provider.ops; conflict = provider.ops;
@ -463,9 +463,9 @@ int tsm_register(const struct tsm_ops *ops, void *priv)
provider.data = priv; provider.data = priv;
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(tsm_register); EXPORT_SYMBOL_GPL(tsm_report_register);
int tsm_unregister(const struct tsm_ops *ops) int tsm_report_unregister(const struct tsm_report_ops *ops)
{ {
guard(rwsem_write)(&tsm_rwsem); guard(rwsem_write)(&tsm_rwsem);
if (ops != provider.ops) if (ops != provider.ops)
@ -474,11 +474,11 @@ int tsm_unregister(const struct tsm_ops *ops)
provider.data = NULL; provider.data = NULL;
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(tsm_unregister); EXPORT_SYMBOL_GPL(tsm_report_unregister);
static struct config_group *tsm_report_group; static struct config_group *tsm_report_group;
static int __init tsm_init(void) static int __init tsm_report_init(void)
{ {
struct config_group *root = &tsm_configfs.su_group; struct config_group *root = &tsm_configfs.su_group;
struct config_group *tsm; struct config_group *tsm;
@ -499,14 +499,14 @@ static int __init tsm_init(void)
return 0; return 0;
} }
module_init(tsm_init); module_init(tsm_report_init);
static void __exit tsm_exit(void) static void __exit tsm_report_exit(void)
{ {
configfs_unregister_default_group(tsm_report_group); configfs_unregister_default_group(tsm_report_group);
configfs_unregister_subsystem(&tsm_configfs); configfs_unregister_subsystem(&tsm_configfs);
} }
module_exit(tsm_exit); module_exit(tsm_report_exit);
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Provide Trusted Security Module attestation reports via configfs"); MODULE_DESCRIPTION("Provide Trusted Security Module attestation reports via configfs");

22
include/linux/tsm.h
View File

@ -6,17 +6,17 @@
#include <linux/types.h> #include <linux/types.h>
#include <linux/uuid.h> #include <linux/uuid.h>
#define TSM_INBLOB_MAX 64 #define TSM_REPORT_INBLOB_MAX 64
#define TSM_OUTBLOB_MAX SZ_32K #define TSM_REPORT_OUTBLOB_MAX SZ_32K
/* /*
* Privilege level is a nested permission concept to allow confidential * Privilege level is a nested permission concept to allow confidential
* guests to partition address space, 4-levels are supported. * guests to partition address space, 4-levels are supported.
*/ */
#define TSM_PRIVLEVEL_MAX 3 #define TSM_REPORT_PRIVLEVEL_MAX 3
/** /**
* struct tsm_desc - option descriptor for generating tsm report blobs * struct tsm_report_desc - option descriptor for generating tsm report blobs
* @privlevel: optional privilege level to associate with @outblob * @privlevel: optional privilege level to associate with @outblob
* @inblob_len: sizeof @inblob * @inblob_len: sizeof @inblob
* @inblob: arbitrary input data * @inblob: arbitrary input data
@ -24,10 +24,10 @@
* @service_guid: optional service-provider service guid to attest * @service_guid: optional service-provider service guid to attest
* @service_manifest_version: optional service-provider service manifest version requested * @service_manifest_version: optional service-provider service manifest version requested
*/ */
struct tsm_desc { struct tsm_report_desc {
unsigned int privlevel; unsigned int privlevel;
size_t inblob_len; size_t inblob_len;
u8 inblob[TSM_INBLOB_MAX]; u8 inblob[TSM_REPORT_INBLOB_MAX];
char *service_provider; char *service_provider;
guid_t service_guid; guid_t service_guid;
unsigned int service_manifest_version; unsigned int service_manifest_version;
@ -44,7 +44,7 @@ struct tsm_desc {
* @manifestblob: (optional) manifest data associated with the report * @manifestblob: (optional) manifest data associated with the report
*/ */
struct tsm_report { struct tsm_report {
struct tsm_desc desc; struct tsm_report_desc desc;
size_t outblob_len; size_t outblob_len;
u8 *outblob; u8 *outblob;
size_t auxblob_len; size_t auxblob_len;
@ -88,7 +88,7 @@ enum tsm_bin_attr_index {
}; };
/** /**
* struct tsm_ops - attributes and operations for tsm instances * struct tsm_report_ops - attributes and operations for tsm_report instances
* @name: tsm id reflected in /sys/kernel/config/tsm/report/$report/provider * @name: tsm id reflected in /sys/kernel/config/tsm/report/$report/provider
* @privlevel_floor: convey base privlevel for nested scenarios * @privlevel_floor: convey base privlevel for nested scenarios
* @report_new: Populate @report with the report blob and auxblob * @report_new: Populate @report with the report blob and auxblob
@ -99,7 +99,7 @@ enum tsm_bin_attr_index {
* Implementation specific ops, only one is expected to be registered at * Implementation specific ops, only one is expected to be registered at
* a time i.e. only one of "sev-guest", "tdx-guest", etc. * a time i.e. only one of "sev-guest", "tdx-guest", etc.
*/ */
struct tsm_ops { struct tsm_report_ops {
const char *name; const char *name;
unsigned int privlevel_floor; unsigned int privlevel_floor;
int (*report_new)(struct tsm_report *report, void *data); int (*report_new)(struct tsm_report *report, void *data);
@ -107,6 +107,6 @@ struct tsm_ops {
bool (*report_bin_attr_visible)(int n); bool (*report_bin_attr_visible)(int n);
}; };
int tsm_register(const struct tsm_ops *ops, void *priv); int tsm_report_register(const struct tsm_report_ops *ops, void *priv);
int tsm_unregister(const struct tsm_ops *ops); int tsm_report_unregister(const struct tsm_report_ops *ops);
#endif /* __TSM_H */ #endif /* __TSM_H */