dpll: Add an assertion to check freq_supported_num

[ Upstream commit 39e912a959 ]

Since the driver is broken in the case that src->freq_supported is not
NULL but src->freq_supported_num is 0, add an assertion for it.

Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Link: https://patch.msgid.link/20250228150210.34404-1-jiashengjiangcool@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiasheng Jiang 2025-02-28 15:02:10 +00:00 committed by Greg Kroah-Hartman
parent ebaed867bf
commit c4f025a58e

View File

@ -443,8 +443,11 @@ static void dpll_pin_prop_free(struct dpll_pin_properties *prop)
static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,
struct dpll_pin_properties *dst) struct dpll_pin_properties *dst)
{ {
if (WARN_ON(src->freq_supported && !src->freq_supported_num))
return -EINVAL;
memcpy(dst, src, sizeof(*dst)); memcpy(dst, src, sizeof(*dst));
if (src->freq_supported && src->freq_supported_num) { if (src->freq_supported) {
size_t freq_size = src->freq_supported_num * size_t freq_size = src->freq_supported_num *
sizeof(*src->freq_supported); sizeof(*src->freq_supported);
dst->freq_supported = kmemdup(src->freq_supported, dst->freq_supported = kmemdup(src->freq_supported,