linux-yocto/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
Matthew Auld c60f91bbc4 drm/xe: covert sysfs over to devm
Hotunplugging the device seems to result in stuff like:

kobject_add_internal failed for tile0 with -EEXIST, don't try to
register things with the same name in the same directory.

We only remove the sysfs as part of drmm, however that is tied to the
lifetime of the driver instance and not the device underneath. Attempt
to fix by using devm for all of the remaining sysfs stuff related to the
device.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1667
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1432
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-20-matthew.auld@intel.com
2024-05-22 13:22:38 +01:00

689 lines
18 KiB
C

// SPDX-License-Identifier: MIT
/*
* Copyright © 2023 Intel Corporation
*/
#include <drm/drm_managed.h>
#include <linux/kobject.h>
#include <linux/sysfs.h>
#include "xe_device.h"
#include "xe_gt.h"
#include "xe_hw_engine_class_sysfs.h"
#include "xe_pm.h"
#define MAX_ENGINE_CLASS_NAME_LEN 16
static int xe_add_hw_engine_class_defaults(struct xe_device *xe,
struct kobject *parent);
/**
* xe_hw_engine_timeout_in_range - Helper to check if timeout is in range
* @timeout: timeout to validate
* @min: min value of valid range
* @max: max value of valid range
*
* This helper helps to validate if timeout is in min-max range of HW engine
* scheduler.
*
* Returns: Returns false value for failure and true for success.
*/
bool xe_hw_engine_timeout_in_range(u64 timeout, u64 min, u64 max)
{
return timeout >= min && timeout <= max;
}
static void kobj_xe_hw_engine_release(struct kobject *kobj)
{
kfree(kobj);
}
static const struct kobj_type kobj_xe_hw_engine_type = {
.release = kobj_xe_hw_engine_release,
.sysfs_ops = &kobj_sysfs_ops
};
static ssize_t job_timeout_max_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (timeout < eclass->sched_props.job_timeout_min)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(timeout,
XE_HW_ENGINE_JOB_TIMEOUT_MIN,
XE_HW_ENGINE_JOB_TIMEOUT_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.job_timeout_max, timeout);
return count;
}
static ssize_t job_timeout_max_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.job_timeout_max);
}
static const struct kobj_attribute job_timeout_max_attr =
__ATTR(job_timeout_max, 0644, job_timeout_max_show, job_timeout_max_store);
static ssize_t job_timeout_min_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (timeout > eclass->sched_props.job_timeout_max)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(timeout,
XE_HW_ENGINE_JOB_TIMEOUT_MIN,
XE_HW_ENGINE_JOB_TIMEOUT_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.job_timeout_min, timeout);
return count;
}
static ssize_t job_timeout_min_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.job_timeout_min);
}
static const struct kobj_attribute job_timeout_min_attr =
__ATTR(job_timeout_min, 0644, job_timeout_min_show, job_timeout_min_store);
static ssize_t job_timeout_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 min = eclass->sched_props.job_timeout_min;
u32 max = eclass->sched_props.job_timeout_max;
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (!xe_hw_engine_timeout_in_range(timeout, min, max))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.job_timeout_ms, timeout);
return count;
}
static ssize_t job_timeout_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.job_timeout_ms);
}
static const struct kobj_attribute job_timeout_attr =
__ATTR(job_timeout_ms, 0644, job_timeout_show, job_timeout_store);
static ssize_t job_timeout_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.job_timeout_ms);
}
static const struct kobj_attribute job_timeout_def =
__ATTR(job_timeout_ms, 0444, job_timeout_default, NULL);
static ssize_t job_timeout_min_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.job_timeout_min);
}
static const struct kobj_attribute job_timeout_min_def =
__ATTR(job_timeout_min, 0444, job_timeout_min_default, NULL);
static ssize_t job_timeout_max_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.job_timeout_max);
}
static const struct kobj_attribute job_timeout_max_def =
__ATTR(job_timeout_max, 0444, job_timeout_max_default, NULL);
static ssize_t timeslice_duration_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 min = eclass->sched_props.timeslice_min;
u32 max = eclass->sched_props.timeslice_max;
u32 duration;
int err;
err = kstrtou32(buf, 0, &duration);
if (err)
return err;
if (!xe_hw_engine_timeout_in_range(duration, min, max))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.timeslice_us, duration);
return count;
}
static ssize_t timeslice_duration_max_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 duration;
int err;
err = kstrtou32(buf, 0, &duration);
if (err)
return err;
if (duration < eclass->sched_props.timeslice_min)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(duration,
XE_HW_ENGINE_TIMESLICE_MIN,
XE_HW_ENGINE_TIMESLICE_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.timeslice_max, duration);
return count;
}
static ssize_t timeslice_duration_max_show(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.timeslice_max);
}
static const struct kobj_attribute timeslice_duration_max_attr =
__ATTR(timeslice_duration_max, 0644, timeslice_duration_max_show,
timeslice_duration_max_store);
static ssize_t timeslice_duration_min_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 duration;
int err;
err = kstrtou32(buf, 0, &duration);
if (err)
return err;
if (duration > eclass->sched_props.timeslice_max)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(duration,
XE_HW_ENGINE_TIMESLICE_MIN,
XE_HW_ENGINE_TIMESLICE_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.timeslice_min, duration);
return count;
}
static ssize_t timeslice_duration_min_show(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.timeslice_min);
}
static const struct kobj_attribute timeslice_duration_min_attr =
__ATTR(timeslice_duration_min, 0644, timeslice_duration_min_show,
timeslice_duration_min_store);
static ssize_t timeslice_duration_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.timeslice_us);
}
static const struct kobj_attribute timeslice_duration_attr =
__ATTR(timeslice_duration_us, 0644, timeslice_duration_show,
timeslice_duration_store);
static ssize_t timeslice_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.timeslice_us);
}
static const struct kobj_attribute timeslice_duration_def =
__ATTR(timeslice_duration_us, 0444, timeslice_default, NULL);
static ssize_t timeslice_min_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.timeslice_min);
}
static const struct kobj_attribute timeslice_duration_min_def =
__ATTR(timeslice_duration_min, 0444, timeslice_min_default, NULL);
static ssize_t timeslice_max_default(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.timeslice_max);
}
static const struct kobj_attribute timeslice_duration_max_def =
__ATTR(timeslice_duration_max, 0444, timeslice_max_default, NULL);
static ssize_t preempt_timeout_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 min = eclass->sched_props.preempt_timeout_min;
u32 max = eclass->sched_props.preempt_timeout_max;
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (!xe_hw_engine_timeout_in_range(timeout, min, max))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.preempt_timeout_us, timeout);
return count;
}
static ssize_t preempt_timeout_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.preempt_timeout_us);
}
static const struct kobj_attribute preempt_timeout_attr =
__ATTR(preempt_timeout_us, 0644, preempt_timeout_show, preempt_timeout_store);
static ssize_t preempt_timeout_default(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.preempt_timeout_us);
}
static const struct kobj_attribute preempt_timeout_def =
__ATTR(preempt_timeout_us, 0444, preempt_timeout_default, NULL);
static ssize_t preempt_timeout_min_default(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.preempt_timeout_min);
}
static const struct kobj_attribute preempt_timeout_min_def =
__ATTR(preempt_timeout_min, 0444, preempt_timeout_min_default, NULL);
static ssize_t preempt_timeout_max_default(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj->parent);
return sysfs_emit(buf, "%u\n", eclass->defaults.preempt_timeout_max);
}
static const struct kobj_attribute preempt_timeout_max_def =
__ATTR(preempt_timeout_max, 0444, preempt_timeout_max_default, NULL);
static ssize_t preempt_timeout_max_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (timeout < eclass->sched_props.preempt_timeout_min)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(timeout,
XE_HW_ENGINE_PREEMPT_TIMEOUT_MIN,
XE_HW_ENGINE_PREEMPT_TIMEOUT_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.preempt_timeout_max, timeout);
return count;
}
static ssize_t preempt_timeout_max_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.preempt_timeout_max);
}
static const struct kobj_attribute preempt_timeout_max_attr =
__ATTR(preempt_timeout_max, 0644, preempt_timeout_max_show,
preempt_timeout_max_store);
static ssize_t preempt_timeout_min_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
u32 timeout;
int err;
err = kstrtou32(buf, 0, &timeout);
if (err)
return err;
if (timeout > eclass->sched_props.preempt_timeout_max)
return -EINVAL;
if (!xe_hw_engine_timeout_in_range(timeout,
XE_HW_ENGINE_PREEMPT_TIMEOUT_MIN,
XE_HW_ENGINE_PREEMPT_TIMEOUT_MAX))
return -EINVAL;
WRITE_ONCE(eclass->sched_props.preempt_timeout_min, timeout);
return count;
}
static ssize_t preempt_timeout_min_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
return sysfs_emit(buf, "%u\n", eclass->sched_props.preempt_timeout_min);
}
static const struct kobj_attribute preempt_timeout_min_attr =
__ATTR(preempt_timeout_min, 0644, preempt_timeout_min_show,
preempt_timeout_min_store);
static const struct attribute *defaults[] = {
&job_timeout_def.attr,
&job_timeout_min_def.attr,
&job_timeout_max_def.attr,
&timeslice_duration_def.attr,
&timeslice_duration_min_def.attr,
&timeslice_duration_max_def.attr,
&preempt_timeout_def.attr,
&preempt_timeout_min_def.attr,
&preempt_timeout_max_def.attr,
NULL
};
static const struct attribute * const files[] = {
&job_timeout_attr.attr,
&job_timeout_min_attr.attr,
&job_timeout_max_attr.attr,
&timeslice_duration_attr.attr,
&timeslice_duration_min_attr.attr,
&timeslice_duration_max_attr.attr,
&preempt_timeout_attr.attr,
&preempt_timeout_min_attr.attr,
&preempt_timeout_max_attr.attr,
NULL
};
static void kobj_xe_hw_engine_class_fini(void *arg)
{
struct kobject *kobj = arg;
sysfs_remove_files(kobj, files);
kobject_put(kobj);
}
static struct kobj_eclass *
kobj_xe_hw_engine_class(struct xe_device *xe, struct kobject *parent, const char *name)
{
struct kobj_eclass *keclass;
int err = 0;
keclass = kzalloc(sizeof(*keclass), GFP_KERNEL);
if (!keclass)
return NULL;
kobject_init(&keclass->base, &kobj_xe_hw_engine_type);
if (kobject_add(&keclass->base, parent, "%s", name)) {
kobject_put(&keclass->base);
return NULL;
}
keclass->xe = xe;
err = devm_add_action_or_reset(xe->drm.dev, kobj_xe_hw_engine_class_fini,
&keclass->base);
if (err)
return NULL;
return keclass;
}
static void hw_engine_class_defaults_fini(void *arg)
{
struct kobject *kobj = arg;
sysfs_remove_files(kobj, defaults);
kobject_put(kobj);
}
static int xe_add_hw_engine_class_defaults(struct xe_device *xe,
struct kobject *parent)
{
struct kobject *kobj;
int err = 0;
kobj = kzalloc(sizeof(*kobj), GFP_KERNEL);
if (!kobj)
return -ENOMEM;
kobject_init(kobj, &kobj_xe_hw_engine_type);
err = kobject_add(kobj, parent, "%s", ".defaults");
if (err)
goto err_object;
err = sysfs_create_files(kobj, defaults);
if (err)
goto err_object;
return devm_add_action_or_reset(xe->drm.dev, hw_engine_class_defaults_fini, kobj);
err_object:
kobject_put(kobj);
return err;
}
static void xe_hw_engine_sysfs_kobj_release(struct kobject *kobj)
{
kfree(kobj);
}
static ssize_t xe_hw_engine_class_sysfs_attr_show(struct kobject *kobj,
struct attribute *attr,
char *buf)
{
struct xe_device *xe = kobj_to_xe(kobj);
struct kobj_attribute *kattr;
ssize_t ret = -EIO;
kattr = container_of(attr, struct kobj_attribute, attr);
if (kattr->show) {
xe_pm_runtime_get(xe);
ret = kattr->show(kobj, kattr, buf);
xe_pm_runtime_put(xe);
}
return ret;
}
static ssize_t xe_hw_engine_class_sysfs_attr_store(struct kobject *kobj,
struct attribute *attr,
const char *buf,
size_t count)
{
struct xe_device *xe = kobj_to_xe(kobj);
struct kobj_attribute *kattr;
ssize_t ret = -EIO;
kattr = container_of(attr, struct kobj_attribute, attr);
if (kattr->store) {
xe_pm_runtime_get(xe);
ret = kattr->store(kobj, kattr, buf, count);
xe_pm_runtime_put(xe);
}
return ret;
}
static const struct sysfs_ops xe_hw_engine_class_sysfs_ops = {
.show = xe_hw_engine_class_sysfs_attr_show,
.store = xe_hw_engine_class_sysfs_attr_store,
};
static const struct kobj_type xe_hw_engine_sysfs_kobj_type = {
.release = xe_hw_engine_sysfs_kobj_release,
.sysfs_ops = &xe_hw_engine_class_sysfs_ops,
};
static void hw_engine_class_sysfs_fini(void *arg)
{
struct kobject *kobj = arg;
kobject_put(kobj);
}
/**
* xe_hw_engine_class_sysfs_init - Init HW engine classes on GT.
* @gt: Xe GT.
*
* This routine creates sysfs for HW engine classes and adds methods
* to get/set different scheduling properties for HW engines class.
*
* Returns: Returns error value for failure and 0 for success.
*/
int xe_hw_engine_class_sysfs_init(struct xe_gt *gt)
{
struct xe_device *xe = gt_to_xe(gt);
struct xe_hw_engine *hwe;
enum xe_hw_engine_id id;
struct kobject *kobj;
u16 class_mask = 0;
int err = 0;
kobj = kzalloc(sizeof(*kobj), GFP_KERNEL);
if (!kobj)
return -ENOMEM;
kobject_init(kobj, &xe_hw_engine_sysfs_kobj_type);
err = kobject_add(kobj, gt->sysfs, "engines");
if (err)
goto err_object;
for_each_hw_engine(hwe, gt, id) {
const char *name;
struct kobj_eclass *keclass;
if (hwe->class == XE_ENGINE_CLASS_OTHER ||
hwe->class == XE_ENGINE_CLASS_MAX)
continue;
if ((class_mask >> hwe->class) & 1)
continue;
class_mask |= 1 << hwe->class;
name = xe_hw_engine_class_to_str(hwe->class);
if (!name) {
err = -EINVAL;
goto err_object;
}
keclass = kobj_xe_hw_engine_class(xe, kobj, name);
if (!keclass) {
err = -EINVAL;
goto err_object;
}
keclass->eclass = hwe->eclass;
err = xe_add_hw_engine_class_defaults(xe, &keclass->base);
if (err)
goto err_object;
err = sysfs_create_files(&keclass->base, files);
if (err)
goto err_object;
}
return devm_add_action_or_reset(xe->drm.dev, hw_engine_class_sysfs_fini, kobj);
err_object:
kobject_put(kobj);
return err;
}