mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-08-21 16:31:14 +02:00
f30490e969
Fix a race condition in the i40e driver that leads to MAC/VLAN filters
becoming corrupted and leaking. Address the issue that occurs under
heavy load when multiple threads are concurrently modifying MAC/VLAN
filters by setting mac and port VLAN.
1. Thread T0 allocates a filter in i40e_add_filter() within
i40e_ndo_set_vf_port_vlan().
2. Thread T1 concurrently frees the filter in __i40e_del_filter() within
i40e_ndo_set_vf_mac().
3. Subsequently, i40e_service_task() calls i40e_sync_vsi_filters(), which
refers to the already freed filter memory, causing corruption.
Reproduction steps:
1. Spawn multiple VFs.
2. Apply a concurrent heavy load by running parallel operations to change
MAC addresses on the VFs and change port VLANs on the host.
3. Observe errors in dmesg:
"Error I40E_AQ_RC_ENOSPC adding RX filters on VF XX,
please set promiscuous on manually for VF XX".
Exact code for stable reproduction Intel can't open-source now.
The fix involves implementing a new intermediate filter state,
I40E_FILTER_NEW_SYNC, for the time when a filter is on a tmp_add_list.
These filters cannot be deleted from the hash list directly but
must be removed using the full process.
Fixes:
|
||
|---|---|---|
| .. | ||
| i40e_adminq_cmd.h | ||
| i40e_adminq.c | ||
| i40e_adminq.h | ||
| i40e_alloc.h | ||
| i40e_client.c | ||
| i40e_common.c | ||
| i40e_dcb_nl.c | ||
| i40e_dcb.c | ||
| i40e_dcb.h | ||
| i40e_ddp.c | ||
| i40e_debug.h | ||
| i40e_debugfs.c | ||
| i40e_devids.h | ||
| i40e_devlink.c | ||
| i40e_devlink.h | ||
| i40e_diag.c | ||
| i40e_diag.h | ||
| i40e_ethtool.c | ||
| i40e_hmc.c | ||
| i40e_hmc.h | ||
| i40e_io.h | ||
| i40e_lan_hmc.c | ||
| i40e_lan_hmc.h | ||
| i40e_main.c | ||
| i40e_nvm.c | ||
| i40e_prototype.h | ||
| i40e_ptp.c | ||
| i40e_register.h | ||
| i40e_trace.h | ||
| i40e_txrx_common.h | ||
| i40e_txrx.c | ||
| i40e_txrx.h | ||
| i40e_type.h | ||
| i40e_virtchnl_pf.c | ||
| i40e_virtchnl_pf.h | ||
| i40e_xsk.c | ||
| i40e_xsk.h | ||
| i40e.h | ||
| Makefile | ||