mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-08-22 00:42:01 +02:00
5225b6562b
Currently a number of SVE/SME related tests have almost identical
functions to enumerate all supported vector lengths. However over time
the copy&pasted code has diverged, allowing some bugs to creep in:
- fake_sigreturn_sme_change_vl reports a failure, not a SKIP if only
one vector length is supported (but the SVE version is fine)
- fake_sigreturn_sme_change_vl tries to set the SVE vector length, not
the SME one (but the other SME tests are fine)
- za_no_regs keeps iterating forever if only one vector length is
supported (but za_regs is correct)
Since those bugs seem to be mostly copy&paste ones, let's consolidate
the enumeration loop into one shared function, and just call that from
each test. That should fix the above bugs, and prevent similar issues
from happening again.
Fixes: 4963aeb35a ("kselftest/arm64: signal: Add SME signal handling tests")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240821164401.3598545-1-andre.przywara@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
106 lines
2.0 KiB
C
106 lines
2.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2021 ARM Limited
|
|
*
|
|
* Verify that the SVE register context in signal frames is set up as
|
|
* expected.
|
|
*/
|
|
|
|
#include <kselftest.h>
|
|
#include <signal.h>
|
|
#include <ucontext.h>
|
|
#include <sys/prctl.h>
|
|
|
|
#include "test_signals_utils.h"
|
|
#include "sve_helpers.h"
|
|
#include "testcases.h"
|
|
|
|
static union {
|
|
ucontext_t uc;
|
|
char buf[1024 * 64];
|
|
} context;
|
|
|
|
static bool sve_get_vls(struct tdescr *td)
|
|
{
|
|
int res = sve_fill_vls(VLS_USE_SVE, 1);
|
|
|
|
if (!res)
|
|
return true;
|
|
|
|
if (res == KSFT_SKIP)
|
|
td->result = KSFT_SKIP;
|
|
|
|
return false;
|
|
}
|
|
|
|
static void setup_sve_regs(void)
|
|
{
|
|
/* RDVL x16, #1 so we should have SVE regs; real data is TODO */
|
|
asm volatile(".inst 0x04bf5030" : : : "x16" );
|
|
}
|
|
|
|
static int do_one_sve_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc,
|
|
unsigned int vl)
|
|
{
|
|
size_t offset;
|
|
struct _aarch64_ctx *head = GET_BUF_RESV_HEAD(context);
|
|
struct sve_context *sve;
|
|
|
|
fprintf(stderr, "Testing VL %d\n", vl);
|
|
|
|
if (prctl(PR_SVE_SET_VL, vl) == -1) {
|
|
fprintf(stderr, "Failed to set VL\n");
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* Get a signal context which should have a SVE frame and registers
|
|
* in it.
|
|
*/
|
|
setup_sve_regs();
|
|
if (!get_current_context(td, &context.uc, sizeof(context)))
|
|
return 1;
|
|
|
|
head = get_header(head, SVE_MAGIC, GET_BUF_RESV_SIZE(context),
|
|
&offset);
|
|
if (!head) {
|
|
fprintf(stderr, "No SVE context\n");
|
|
return 1;
|
|
}
|
|
|
|
sve = (struct sve_context *)head;
|
|
if (sve->vl != vl) {
|
|
fprintf(stderr, "Got VL %d, expected %d\n", sve->vl, vl);
|
|
return 1;
|
|
}
|
|
|
|
/* The actual size validation is done in get_current_context() */
|
|
fprintf(stderr, "Got expected size %u and VL %d\n",
|
|
head->size, sve->vl);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int sve_regs(struct tdescr *td, siginfo_t *si, ucontext_t *uc)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < nvls; i++) {
|
|
if (do_one_sve_vl(td, si, uc, vls[i]))
|
|
return 1;
|
|
}
|
|
|
|
td->pass = 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct tdescr tde = {
|
|
.name = "SVE registers",
|
|
.descr = "Check that we get the right SVE registers reported",
|
|
.feats_required = FEAT_SVE,
|
|
.timeout = 3,
|
|
.init = sve_get_vls,
|
|
.run = sve_regs,
|
|
};
|