mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-07-19 03:59:45 +02:00
14e14aaf61
The current API for the wilco EC mailbox interface is bad. It assumes that most messages sent to the EC follow a similar structure, with a command byte in MBOX[0], followed by a junk byte, followed by actual data. This doesn't happen in several cases, such as setting the RTC time, using the raw debugfs interface, and reading or writing properties such as the Peak Shift policy (this last to be submitted soon). Similarly for the response message from the EC, the current interface assumes that the first byte of data is always 0, and the second byte is unused. However, in both setting and getting the RTC time, in the debugfs interface, and for reading and writing properties, this isn't true. The current way to resolve this is to use WILCO_EC_FLAG_RAW* flags to specify when and when not to skip these initial bytes in the sent and received message. They are confusing and used so much that they are normal, and not exceptions. In addition, the first byte of response in the debugfs interface is still always skipped, which is weird, since this raw interface should be giving the entire result. Additionally, sent messages assume the first byte is a command, and so struct wilco_ec_message contains the "command" field. In setting or getting properties however, the first byte is not a command, and so this field has to be filled with a byte that isn't actually a command. This is again inconsistent. wilco_ec_message contains a result field as well, copied from wilco_ec_response->result. The message result field should be removed: if the message fails, the cause is already logged, and the callers are alerted. They will never care about the actual state of the result flag. These flags and different cases make the wilco_ec_transfer() function, used in wilco_ec_mailbox(), really gross, dealing with a bunch of different cases. It's difficult to figure out what it is doing. Finally, making these assumptions about the structure of a message make it so that the messages do not correspond well with the specification for the EC's mailbox interface. For instance, this interface specification may say that MBOX[9] in the received message contains some information, but the calling code needs to remember that the first byte of response is always skipped, and because it didn't set the RESPONSE_RAW flag, the next byte is also skipped, so this information is actually contained within wilco_ec_message->response_data[7]. This makes it difficult to maintain this code in the future. To fix these problems this patch standardizes the mailbox interface by: - Removing the WILCO_EC_FLAG_RAW* flags - Removing the command and reserved_raw bytes from wilco_ec_request - Removing the mbox0 byte from wilco_ec_response - Simplifying wilco_ec_transfer() because of these changes - Gives the callers of wilco_ec_mailbox() the responsibility of exactly and consistently defining the structure of the mailbox request and response - Removing command and result from wilco_ec_message. This results in the reduction of total code, and makes it much more maintainable and understandable. Signed-off-by: Nick Crews <ncrews@chromium.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> |
||
|---|---|---|
| .. | ||
| gpio | ||
| jz4740 | ||
| media | ||
| txx9 | ||
| x86 | ||
| ad5449.h | ||
| ad5755.h | ||
| ad5761.h | ||
| ad7266.h | ||
| ad7291.h | ||
| ad7298.h | ||
| ad7303.h | ||
| ad7791.h | ||
| ad7793.h | ||
| ad7887.h | ||
| adau17x1.h | ||
| adau1977.h | ||
| adp5588.h | ||
| adp8860.h | ||
| adp8870.h | ||
| ads1015.h | ||
| ads7828.h | ||
| ams-delta-fiq.h | ||
| apds990x.h | ||
| arm-ux500-pm.h | ||
| asoc-imx-ssi.h | ||
| asoc-kirkwood.h | ||
| asoc-mx27vis.h | ||
| asoc-palm27x.h | ||
| asoc-s3c.h | ||
| asoc-s3c24xx_simtec.h | ||
| asoc-ti-mcbsp.h | ||
| asoc-ux500-msp.h | ||
| at91_adc.h | ||
| ata-pxa.h | ||
| ata-samsung_cf.h | ||
| atmel.h | ||
| b53.h | ||
| bcmgenet.h | ||
| bd6107.h | ||
| bh1770glc.h | ||
| brcmfmac.h | ||
| clk-da8xx-cfgchip.h | ||
| clk-davinci-pll.h | ||
| clk-integrator.h | ||
| clk-st.h | ||
| clk-u300.h | ||
| cpuidle-exynos.h | ||
| crypto-atmel.h | ||
| crypto-ux500.h | ||
| cyttsp4.h | ||
| davinci_asp.h | ||
| davinci-cpufreq.h | ||
| db8500_thermal.h | ||
| dma-atmel.h | ||
| dma-coh901318.h | ||
| dma-dw.h | ||
| dma-ep93xx.h | ||
| dma-hsu.h | ||
| dma-imx-sdma.h | ||
| dma-imx.h | ||
| dma-mcf-edma.h | ||
| dma-mmp_tdma.h | ||
| dma-mv_xor.h | ||
| dma-s3c24xx.h | ||
| dma-ste-dma40.h | ||
| dmtimer-omap.h | ||
| ds620.h | ||
| dsa.h | ||
| dwc3-omap.h | ||
| edma.h | ||
| efm32-spi.h | ||
| efm32-uart.h | ||
| ehci-sh.h | ||
| elm.h | ||
| emif_plat.h | ||
| eth-netx.h | ||
| fsa9480.h | ||
| g762.h | ||
| gpio_backlight.h | ||
| gpio-ath79.h | ||
| gpio-davinci.h | ||
| gpio-dwapb.h | ||
| gpio-htc-egpio.h | ||
| gpio-omap.h | ||
| gpmc-omap.h | ||
| hsmmc-omap.h | ||
| hwmon-s3c.h | ||
| i2c-davinci.h | ||
| i2c-designware.h | ||
| i2c-gpio.h | ||
| i2c-hid.h | ||
| i2c-imx.h | ||
| i2c-mux-gpio.h | ||
| i2c-mux-reg.h | ||
| i2c-ocores.h | ||
| i2c-omap.h | ||
| i2c-pca-platform.h | ||
| i2c-pxa.h | ||
| i2c-s3c2410.h | ||
| i2c-xiic.h | ||
| ina2xx.h | ||
| intel-mid_wdt.h | ||
| intel-spi.h | ||
| invensense_mpu6050.h | ||
| iommu-omap.h | ||
| irda-pxaficp.h | ||
| irda-sa11x0.h | ||
| isl9305.h | ||
| itco_wdt.h | ||
| keyboard-pxa930_rotary.h | ||
| keyboard-spear.h | ||
| keypad-ep93xx.h | ||
| keypad-nomadik-ske.h | ||
| keypad-omap.h | ||
| keypad-pxa27x.h | ||
| keypad-w90p910.h | ||
| keyscan-davinci.h | ||
| lcd-mipid.h | ||
| leds-kirkwood-netxbig.h | ||
| leds-kirkwood-ns2.h | ||
| leds-lm355x.h | ||
| leds-lm3642.h | ||
| leds-lp55xx.h | ||
| leds-omap.h | ||
| leds-pca963x.h | ||
| leds-s3c24xx.h | ||
| lm3630a_bl.h | ||
| lm3639_bl.h | ||
| lm8323.h | ||
| lp855x.h | ||
| lp8727.h | ||
| lp8755.h | ||
| ltc4245.h | ||
| lv5207lp.h | ||
| macb.h | ||
| max197.h | ||
| max732x.h | ||
| max3421-hcd.h | ||
| max6639.h | ||
| max6697.h | ||
| mcs.h | ||
| mdio-bcm-unimac.h | ||
| mdio-gpio.h | ||
| mfd-mcp-sa11x0.h | ||
| microchip-ksz.h | ||
| mlxreg.h | ||
| mmc-davinci.h | ||
| mmc-esdhc-imx.h | ||
| mmc-mxcmmc.h | ||
| mmc-omap.h | ||
| mmc-pxamci.h | ||
| mmc-s3cmci.h | ||
| mmc-sdhci-s3c.h | ||
| mmp_audio.h | ||
| mmp_dma.h | ||
| mouse-pxa930_trkball.h | ||
| mtd-davinci-aemif.h | ||
| mtd-davinci.h | ||
| mtd-mxc_nand.h | ||
| mtd-nand-omap2.h | ||
| mtd-nand-pxa3xx.h | ||
| mtd-nand-s3c2410.h | ||
| mtd-orion_nand.h | ||
| mv_usb.h | ||
| mv88e6xxx.h | ||
| net-cw1200.h | ||
| nfcmrvl.h | ||
| ntc_thermistor.h | ||
| nxp-nci.h | ||
| omap-twl4030.h | ||
| omap-wd-timer.h | ||
| omap1_bl.h | ||
| omapdss.h | ||
| pca953x.h | ||
| pca954x.h | ||
| pcf857x.h | ||
| pcmcia-pxa2xx_viper.h | ||
| phy-da8xx-usb.h | ||
| pinctrl-single.h | ||
| pixcir_i2c_ts.h | ||
| pm33xx.h | ||
| pwm_omap_dmtimer.h | ||
| pxa_sdhci.h | ||
| pxa2xx_udc.h | ||
| regulator-haptic.h | ||
| remoteproc-omap.h | ||
| rtc-ds2404.h | ||
| rtc-v3020.h | ||
| s3c-hsotg.h | ||
| s3c-hsudc.h | ||
| sa11x0-serial.h | ||
| sc18is602.h | ||
| sdhci-pic32.h | ||
| serial-imx.h | ||
| serial-omap.h | ||
| serial-sccnxp.h | ||
| shmob_drm.h | ||
| sht3x.h | ||
| shtc1.h | ||
| si5351.h | ||
| simplefb.h | ||
| sky81452-backlight.h | ||
| spi-ath79.h | ||
| spi-clps711x.h | ||
| spi-davinci.h | ||
| spi-ep93xx.h | ||
| spi-imx.h | ||
| spi-mt65xx.h | ||
| spi-nuc900.h | ||
| spi-omap2-mcspi.h | ||
| spi-s3c64xx.h | ||
| ssm2518.h | ||
| st_sensors_pdata.h | ||
| st33zp24.h | ||
| syscon.h | ||
| tc35876x.h | ||
| tda9950.h | ||
| ti-aemif.h | ||
| ti-sysc.h | ||
| touchscreen-s3c2410.h | ||
| tsc2007.h | ||
| tsl2563.h | ||
| tsl2772.h | ||
| uio_dmem_genirq.h | ||
| uio_pruss.h | ||
| usb-davinci.h | ||
| usb-ehci-mxc.h | ||
| usb-ehci-orion.h | ||
| usb-musb-ux500.h | ||
| usb-mx2.h | ||
| usb-ohci-pxa27x.h | ||
| usb-ohci-s3c2410.h | ||
| usb-omap.h | ||
| usb-omap1.h | ||
| usb-pxa3xx-ulpi.h | ||
| usb-s3c2410_udc.h | ||
| usb3503.h | ||
| ux500_wdt.h | ||
| video_s3c.h | ||
| video-clcd-versatile.h | ||
| video-ep93xx.h | ||
| video-imxfb.h | ||
| video-mx3fb.h | ||
| video-nuc900fb.h | ||
| video-pxafb.h | ||
| voltage-omap.h | ||
| wilco-ec.h | ||
| wiznet.h | ||
| wkup_m3.h | ||
| zforce_ts.h | ||