Eric Dumazet 0c5eba454e net: lockless sock_i_ino() ... [ Upstream commit 5d6b58c932ec451a5c41482790eb5b1ecf165a94 ] Followup of commit c51da3f7a1 ("net: remove sock_i_uid()") A recent syzbot report was the trigger for this change. Over the years, we had many problems caused by the read_lock[_bh](&sk->sk_callback_lock) in sock_i_uid(). We could fix smc_diag_dump_proto() or make a more radical move: Instead of waiting for new syzbot reports, cache the socket inode number in sk->sk_ino, so that we no longer need to acquire sk->sk_callback_lock in sock_i_ino(). This makes socket dumps faster (one less cache line miss, and two atomic ops avoided). Prior art: commit 25a9c8a443 ("netlink: Add __sock_i_ino() for __netlink_diag_dump().") commit 4f9bf2a2f5 ("tcp: Don't acquire inet_listen_hashbucket::lock with disabled BH.") commit efc3dbc374 ("rds: Make rds_sock_lock BH rather than IRQ safe.") Fixes: d2d6422f8b ("x86: Allow to enable PREEMPT_RT.") Reported-by: syzbot+50603c05bbdf4dfdaffa@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/68b73804.050a0220.3db4df.01d8.GAE@google.com/T/#u Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Link: https://patch.msgid.link/20250902183603.740428-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2025-09-09 19:02:26 +02:00
..
af_netlink.c	netlink: avoid infinite retry looping in netlink_unicast()	2025-08-20 18:40:45 +02:00
af_netlink.h	netlink: terminate outstanding dump on socket close	2024-11-07 13:45:34 -08:00
diag.c	net: lockless sock_i_ino()	2025-09-09 19:02:26 +02:00
genetlink.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-10-21 09:14:18 +02:00
genetlink.h	netlink: create a new header for internal genetlink symbols	2024-04-01 21:44:34 -07:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	netlink: add infrastructure to expose policies to userspace	2020-04-30 17:51:42 -07:00
policy.c	netlink: fix policy dump for int with validation callback	2025-05-12 18:50:09 -07:00