Go to file
Ammar Faizi 4f681834f0 net: usbnet: Fix the wrong netif_carrier_on() call
commit 8466d39370 upstream.

The commit referenced in the Fixes tag causes usbnet to malfunction
(identified via git bisect). Post-commit, my external RJ45 LAN cable
fails to connect. Linus also reported the same issue after pulling that
commit.

The code has a logic error: netif_carrier_on() is only called when the
link is already on. Fix this by moving the netif_carrier_on() call
outside the if-statement entirely. This ensures it is always called
when EVENT_LINK_CARRIER_ON is set and properly clears it regardless
of the link state.

Cc: stable@vger.kernel.org
Cc: Armando Budianto <sprite@gnuweeb.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/all/CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com
Closes: https://lore.kernel.org/netdev/CAHk-=wjKh8X4PT_mU1kD4GQrbjivMfPn-_hXa6han_BTDcXddw@mail.gmail.com
Closes: https://lore.kernel.org/netdev/0752dee6-43d6-4e1f-81d2-4248142cccd2@gnuweeb.org
Fixes: 0d9cfc9b8c ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE event")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-08-15 16:39:32 +02:00
arch s390/boot: Fix startup debugging log 2025-08-15 16:39:28 +02:00
block block: ensure discard_granularity is zero when discard is not supported 2025-08-15 16:39:24 +02:00
certs sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3 2024-09-20 19:52:48 +03:00
crypto crypto: krb5 - Fix memory leak in krb5_test_one_prf() 2025-08-15 16:39:10 +02:00
Documentation netlink: specs: ethtool: fix module EEPROM input/output arguments 2025-08-15 16:39:24 +02:00
drivers net: usbnet: Fix the wrong netif_carrier_on() call 2025-08-15 16:39:32 +02:00
fs smb: server: Fix extension string in ksmbd_extract_shortname() 2025-08-15 16:39:32 +02:00
include net: usbnet: Avoid potential RCU stall on LINK_CHANGE event 2025-08-15 16:39:32 +02:00
init io_uring: fix breakage in EXPERT menu 2025-08-15 16:38:23 +02:00
io_uring io_uring-6.16-20250718 2025-07-18 12:21:26 -07:00
ipc - The 3 patch series "hung_task: extend blocking task stacktrace dump to 2025-05-31 19:12:53 -07:00
kernel perf/core: Prevent VMA split of buffer mappings 2025-08-15 16:39:31 +02:00
lib kunit/fortify: Add back "volatile" for sizeof() constants 2025-08-15 16:38:22 +02:00
LICENSES LICENSES: add CC0-1.0 license text 2025-05-21 14:54:17 +02:00
mm slub: Fix a documentation build error for krealloc() 2025-08-15 16:38:38 +02:00
net vsock: Do not allow binding to VMADDR_PORT_ANY 2025-08-15 16:39:31 +02:00
rust rust: miscdevice: clarify invariant for MiscDeviceRegistration 2025-08-15 16:38:30 +02:00
samples samples: mei: Fix building on musl libc 2025-08-15 16:38:34 +02:00
scripts kconfig: qconf: fix ConfigList::updateListAllforAll() 2025-08-15 16:39:21 +02:00
security apparmor: Fix unaligned memory accesses in KUnit test 2025-08-15 16:39:16 +02:00
sound ALSA: hda/ca0132: Fix missing error handling in ca0132_alt_select_out() 2025-08-15 16:39:28 +02:00
tools selftests/perf_events: Add a mmap() correctness test 2025-08-15 16:39:31 +02:00
usr usr/include: openrisc: don't HDRTEST bpf_perf_event.h 2025-05-12 15:03:17 +09:00
virt KVM: Allow CPU to reschedule while setting per-page memory attributes 2025-06-24 12:20:17 -07:00
.clang-format Linux 6.15-rc5 2025-05-06 16:39:25 +10:00
.clippy.toml rust: clean Rust 1.88.0's warning about clippy::disallowed_macros configuration 2025-05-07 00:11:47 +02:00
.cocciconfig
.editorconfig
.get_maintainer.ignore MAINTAINERS: Retire Ralf Baechle 2024-11-12 15:48:59 +01:00
.gitattributes
.gitignore gitignore: allow .pylintrc to be tracked 2025-08-15 16:39:03 +02:00
.mailmap 11 hotfixes. 9 are cc:stable and the remainder address post-6.15 issues 2025-07-24 19:13:30 -07:00
.pylintrc docs: add a .pylintrc file with sys path for docs scripts 2025-04-09 12:10:33 -06:00
.rustfmt.toml
COPYING
CREDITS mm: update MAINTAINERS entry for HMM 2025-07-19 19:26:16 -07:00
Kbuild drm: ensure drm headers are self-contained and pass kernel-doc 2025-02-12 10:44:43 +02:00
Kconfig io_uring: Rename KConfig to Kconfig 2025-02-19 14:53:27 -07:00
MAINTAINERS 11 hotfixes. 9 are cc:stable and the remainder address post-6.15 issues 2025-07-24 19:13:30 -07:00
Makefile Linux 6.16 2025-07-27 14:26:38 -07:00
README

Linux kernel

There are several guides for kernel developers and users. These guides can be rendered in a number of formats, like HTML and PDF. Please read Documentation/admin-guide/README.rst first.

In order to build the documentation, use make htmldocs or make pdfdocs. The formatted documentation can also be read online at:

https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory, several of them using the reStructuredText markup notation.

Please read the Documentation/process/changes.rst file, as it contains the requirements for building and running the kernel, and information about the problems which may result by upgrading your kernel.