Srinivas Kandagatla f80e4e91b0 rpmsg: glink: fix rpmsg device leak ... commit a53e356df548f6b0e82529ef3cc6070f42622189 upstream. While testing rpmsg-char interface it was noticed that duplicate sysfs entries are getting created and below warning is noticed. Reason for this is that we are leaking rpmsg device pointer, setting it null without actually unregistering device. Any further attempts to unregister fail because rpdev is NULL, resulting in a leak. Fix this by unregistering rpmsg device before removing its reference from rpmsg channel. sysfs: cannot create duplicate filename '/devices/platform/soc@0/3700000.remot eproc/remoteproc/remoteproc1/3700000.remoteproc:glink-edge/3700000.remoteproc: glink-edge.adsp_apps.-1.-1' [ 114.115347] CPU: 0 UID: 0 PID: 9 Comm: kworker/0:0 Not tainted 6.16.0-rc4 #7 PREEMPT [ 114.115355] Hardware name: Qualcomm Technologies, Inc. Robotics RB3gen2 (DT) [ 114.115358] Workqueue: events qcom_glink_work [ 114.115371] Call trace:8 [ 114.115374] show_stack+0x18/0x24 (C) [ 114.115382] dump_stack_lvl+0x60/0x80 [ 114.115388] dump_stack+0x18/0x24 [ 114.115393] sysfs_warn_dup+0x64/0x80 [ 114.115402] sysfs_create_dir_ns+0xf4/0x120 [ 114.115409] kobject_add_internal+0x98/0x260 [ 114.115416] kobject_add+0x9c/0x108 [ 114.115421] device_add+0xc4/0x7a0 [ 114.115429] rpmsg_register_device+0x5c/0xb0 [ 114.115434] qcom_glink_work+0x4bc/0x820 [ 114.115438] process_one_work+0x148/0x284 [ 114.115446] worker_thread+0x2c4/0x3e0 [ 114.115452] kthread+0x12c/0x204 [ 114.115457] ret_from_fork+0x10/0x20 [ 114.115464] kobject: kobject_add_internal failed for 3700000.remoteproc: glink-edge.adsp_apps.-1.-1 with -EEXIST, don't try to register things with the same name in the same directory. [ 114.250045] rpmsg 3700000.remoteproc:glink-edge.adsp_apps.-1.-1: device_add failed: -17 Fixes: 835764ddd9 ("rpmsg: glink: Move the common glink protocol implementation to glink_native.c") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250822100043.2604794-2-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2026-01-02 12:57:29 +01:00
..
Kconfig	rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl	2022-03-13 11:49:53 -05:00
Makefile	rpmsg: glink: Introduce packet tracepoints	2024-08-12 15:26:28 -07:00
mtk_rpmsg.c	rpmsg: mtk_rpmsg: Fix circular locking dependency	2022-06-14 16:41:10 -06:00
qcom_glink_native.c	rpmsg: glink: fix rpmsg device leak	2026-01-02 12:57:29 +01:00
qcom_glink_native.h	rpmsg: glink: Fix spelling of peek	2023-02-14 20:28:48 -08:00
qcom_glink_rpm.c	Get rid of 'remove_new' relic from platform driver struct	2024-12-01 15:12:43 -08:00
qcom_glink_smem.c	rpmsg: glink: Fix spelling of peek	2023-02-14 20:28:48 -08:00
qcom_glink_ssr.c	rpmsg: qcom_glink_ssr: fix module autoloading	2024-05-06 19:26:28 -07:00
qcom_glink_trace.h	rpmsg: glink: Introduce packet tracepoints	2024-08-12 15:26:28 -07:00
qcom_smd.c	rpmsg: qcom_smd: Fix fallback to qcom,ipc parse	2025-09-20 21:29:48 -05:00
rpmsg_char.c	rpmsg: char: Export alias for RPMSG ID rpmsg-raw from table	2025-08-25 08:20:21 -06:00
rpmsg_char.h	rpmsg: char: Export eptdev create and destroy functions	2022-03-13 11:49:53 -05:00
rpmsg_core.c	rpmsg: core: Drop dev_pm_domain_detach() call	2025-08-29 10:21:31 -06:00
rpmsg_ctrl.c	rpmsg: core: Make rpmsg_class constant	2024-03-26 11:25:13 -06:00
rpmsg_internal.h	rpmsg: Remove unused method pointers *send_offchannel	2025-05-06 11:11:45 -06:00
rpmsg_ns.c	rpmsg: Replace deprecated strncpy with strscpy_pad	2023-10-23 11:57:57 -06:00
virtio_rpmsg_bus.c	remoteproc: Don't use %pK through printk	2025-06-17 08:03:24 -05:00