Wang Liang 34171b9e53 net: bridge: fix soft lockup in br_multicast_query_expired() ... [ Upstream commit d1547bf460baec718b3398365f8de33d25c5f36f ] When set multicast_query_interval to a large value, the local variable 'time' in br_multicast_send_query() may overflow. If the time is smaller than jiffies, the timer will expire immediately, and then call mod_timer() again, which creates a loop and may trigger the following soft lockup issue. watchdog: BUG: soft lockup - CPU#1 stuck for 221s! [rb_consumer:66] CPU: 1 UID: 0 PID: 66 Comm: rb_consumer Not tainted 6.16.0+ #259 PREEMPT(none) Call Trace: <IRQ> __netdev_alloc_skb+0x2e/0x3a0 br_ip6_multicast_alloc_query+0x212/0x1b70 __br_multicast_send_query+0x376/0xac0 br_multicast_send_query+0x299/0x510 br_multicast_query_expired.constprop.0+0x16d/0x1b0 call_timer_fn+0x3b/0x2a0 __run_timers+0x619/0x950 run_timer_softirq+0x11c/0x220 handle_softirqs+0x18e/0x560 __irq_exit_rcu+0x158/0x1a0 sysvec_apic_timer_interrupt+0x76/0x90 </IRQ> This issue can be reproduced with: ip link add br0 type bridge echo 1 > /sys/class/net/br0/bridge/multicast_querier echo 0xffffffffffffffff > /sys/class/net/br0/bridge/multicast_query_interval ip link set dev br0 up The multicast_startup_query_interval can also cause this issue. Similar to the commit 99b4061095 ("net: bridge: mcast: add and enforce query interval minimum"), add check for the query interval maximum to fix this issue. Link: https://lore.kernel.org/netdev/20250806094941.1285944-1-wangliang74@huawei.com/ Link: https://lore.kernel.org/netdev/20250812091818.542238-1-wangliang74@huawei.com/ Fixes: d902eee43f ("bridge: Add multicast count/interval sysfs entries") Suggested-by: Nikolay Aleksandrov <razor@blackwall.org> Signed-off-by: Wang Liang <wangliang74@huawei.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Acked-by: Nikolay Aleksandrov <razor@blackwall.org> Link: https://patch.msgid.link/20250813021054.1643649-1-wangliang74@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2025-08-28 16:24:37 +02:00
..
netfilter	netfilter: bridge: Move specific fragmented packet to slow_path instead of dropping it	2025-06-27 11:05:12 +01:00
br_arp_nd_proxy.c
br_cfm_netlink.c
br_cfm.c
br_device.c	net: bridge: xmit: make sure we have at least eth header len bytes	2024-11-14 13:13:40 +01:00
br_fdb.c	net: bridge: br_fdb_external_learn_add(): always set EXT_LEARN	2024-09-12 11:07:47 +02:00
br_forward.c	net: bridge: fix corrupted ethernet header on multicast-to-unicast	2024-05-17 11:50:58 +02:00
br_if.c
br_input.c	netfilter: br_netfilter: skip conntrack input hook for promisc packets	2024-04-27 17:05:24 +02:00
br_ioctl.c
br_mdb.c
br_mrp_netlink.c
br_mrp_switchdev.c
br_mrp.c
br_multicast_eht.c
br_multicast.c	net: bridge: fix soft lockup in br_multicast_query_expired()	2025-08-28 16:24:37 +02:00
br_netfilter_hooks.c	netfilter: br_netfilter: fix panic with metadata_dst skb	2024-10-17 15:11:54 +02:00
br_netfilter_ipv6.c
br_netlink_tunnel.c
br_netlink.c	bridge/br_netlink.c: no need to return void function	2024-05-02 16:24:45 +02:00
br_nf_core.c	bridge: netfilter: Fix forwarding of fragmented packets	2025-06-04 14:38:05 +02:00
br_private_cfm.h
br_private_mcast_eht.h
br_private_mrp.h
br_private_stp.h
br_private_tunnel.h
br_private.h	net: bridge: fix soft lockup in br_multicast_query_expired()	2025-08-28 16:24:37 +02:00
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_stp.c
br_switchdev.c	net: bridge: Do not offload IGMP/MLD messages	2025-08-28 16:24:02 +02:00
br_sysfs_br.c
br_sysfs_if.c
br_vlan_options.c
br_vlan_tunnel.c
br_vlan.c
br.c
Kconfig
Makefile