Yang Yingliang 9346517ed2 genirq/irqdesc: Don't try to remove non-existing sysfs files ... [ Upstream commit 9049e1ca41 ] Fault injection tests trigger warnings like this: kernfs: can not remove 'chip_name', no directory WARNING: CPU: 0 PID: 253 at fs/kernfs/dir.c:1616 kernfs_remove_by_name_ns+0xce/0xe0 RIP: 0010:kernfs_remove_by_name_ns+0xce/0xe0 Call Trace: <TASK> remove_files.isra.1+0x3f/0xb0 sysfs_remove_group+0x68/0xe0 sysfs_remove_groups+0x41/0x70 __kobject_del+0x45/0xc0 kobject_del+0x29/0x40 free_desc+0x42/0x70 irq_free_descs+0x5e/0x90 The reason is that the interrupt descriptor sysfs handling does not roll back on a failing kobject_add() during allocation. If the descriptor is freed later on, kobject_del() is invoked with a not added kobject resulting in the above warnings. A proper rollback in case of a kobject_add() failure would be the straight forward solution. But this is not possible due to the way how interrupt descriptor sysfs handling works. Interrupt descriptors are allocated before sysfs becomes available. So the sysfs files for the early allocated descriptors are added later in the boot process. At this point there can be nothing useful done about a failing kobject_add(). For consistency the interrupt descriptor allocation always treats kobject_add() failures as non-critical and just emits a warning. To solve this problem, keep track in the interrupt descriptor whether kobject_add() was successful or not and make the invocation of kobject_del() conditional on that. [ tglx: Massage changelog, comments and use a state bit. ] Fixes: ecb3f394c5 ("genirq: Expose interrupt information through sysfs") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20221128151612.1786122-1-yangyingliang@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-14 10:15:18 +01:00
..
affinity.c	genirq/affinity: Consider that CPUs on nodes can be unbalanced	2022-04-20 09:23:29 +02:00
autoprobe.c
chip.c	genirq: Don't return error on missing optional irq_request_resources()	2022-08-21 15:15:28 +02:00
cpuhotplug.c
debug.h
debugfs.c
devres.c
dummychip.c
generic-chip.c
handle.c	random: remove unused irq_flags argument from add_interrupt_randomness()	2022-05-30 09:33:27 +02:00
internals.h	genirq/irqdesc: Don't try to remove non-existing sysfs files	2023-01-14 10:15:18 +01:00
ipi.c
irq_sim.c
irqdesc.c	genirq/irqdesc: Don't try to remove non-existing sysfs files	2023-01-14 10:15:18 +01:00
irqdomain.c
Kconfig	genirq: GENERIC_IRQ_IPI depends on SMP	2022-08-21 15:15:28 +02:00
Makefile
manage.c	genirq: Take the proposed affinity at face value if force==true	2022-12-02 17:40:06 +01:00
matrix.c
migration.c
msi.c	genirq/msi: Shutdown managed interrupts with unsatifiable affinities	2022-12-02 17:40:06 +01:00
pm.c
proc.c
resend.c
settings.h
spurious.c
timings.c	genirq/timings: Fix error return code in irq_timings_test_irqs()	2021-09-15 09:50:29 +02:00