Ivan Solodovnikov 9ee68b0f23 dccp: Fix memory leak in dccp_feat_change_recv ... [ Upstream commit 22be4727a8 ] If dccp_feat_push_confirm() fails after new value for SP feature was accepted without reconciliation ('entry == NULL' branch), memory allocated for that value with dccp_feat_clone_sp_val() is never freed. Here is the kmemleak stack for this: unreferenced object 0xffff88801d4ab488 (size 8): comm "syz-executor310", pid 1127, jiffies 4295085598 (age 41.666s) hex dump (first 8 bytes): 01 b4 4a 1d 80 88 ff ff ..J..... backtrace: [<00000000db7cabfe>] kmemdup+0x23/0x50 mm/util.c:128 [<0000000019b38405>] kmemdup include/linux/string.h:465 [inline] [<0000000019b38405>] dccp_feat_clone_sp_val net/dccp/feat.c:371 [inline] [<0000000019b38405>] dccp_feat_clone_sp_val net/dccp/feat.c:367 [inline] [<0000000019b38405>] dccp_feat_change_recv net/dccp/feat.c:1145 [inline] [<0000000019b38405>] dccp_feat_parse_options+0x1196/0x2180 net/dccp/feat.c:1416 [<00000000b1f6d94a>] dccp_parse_options+0xa2a/0x1260 net/dccp/options.c:125 [<0000000030d7b621>] dccp_rcv_state_process+0x197/0x13d0 net/dccp/input.c:650 [<000000001f74c72e>] dccp_v4_do_rcv+0xf9/0x1a0 net/dccp/ipv4.c:688 [<00000000a6c24128>] sk_backlog_rcv include/net/sock.h:1041 [inline] [<00000000a6c24128>] __release_sock+0x139/0x3b0 net/core/sock.c:2570 [<00000000cf1f3a53>] release_sock+0x54/0x1b0 net/core/sock.c:3111 [<000000008422fa23>] inet_wait_for_connect net/ipv4/af_inet.c:603 [inline] [<000000008422fa23>] __inet_stream_connect+0x5d0/0xf70 net/ipv4/af_inet.c:696 [<0000000015b6f64d>] inet_stream_connect+0x53/0xa0 net/ipv4/af_inet.c:735 [<0000000010122488>] __sys_connect_file+0x15c/0x1a0 net/socket.c:1865 [<00000000b4b70023>] __sys_connect+0x165/0x1a0 net/socket.c:1882 [<00000000f4cb3815>] __do_sys_connect net/socket.c:1892 [inline] [<00000000f4cb3815>] __se_sys_connect net/socket.c:1889 [inline] [<00000000f4cb3815>] __x64_sys_connect+0x6e/0xb0 net/socket.c:1889 [<00000000e7b1e839>] do_syscall_64+0x33/0x40 arch/x86/entry/common.c:46 [<0000000055e91434>] entry_SYSCALL_64_after_hwframe+0x67/0xd1 Clean up the allocated memory in case of dccp_feat_push_confirm() failure and bail out with an error reset code. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: e77b8363b2 ("dccp: Process incoming Change feature-negotiation options") Signed-off-by: Ivan Solodovnikov <solodovnikov.ia@phystech.edu> Link: https://patch.msgid.link/20241126143902.190853-1-solodovnikov.ia@phystech.edu Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-12-14 20:03:05 +01:00
..
ccids	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
ackvec.c	net: dccp: Simplify the allocation of slab caches in dccp_ackvec_init	2024-02-02 12:19:26 +00:00
ackvec.h
ccid.c
ccid.h
dccp.h	net: ioctl: Use kernel memory on protocol ioctl callbacks	2023-06-15 22:33:26 -07:00
diag.c	inet_diag: add module pointer to "struct inet_diag_handler"	2024-01-23 15:13:54 +01:00
feat.c	dccp: Fix memory leak in dccp_feat_change_recv	2024-12-14 20:03:05 +01:00
feat.h	dccp: Remove unused declaration dccp_feat_initialise_sysctls()	2023-07-27 17:16:26 -07:00
input.c
ipv4.c	Fix race for duplicate reqsk on identical SYN	2024-06-25 11:37:45 +02:00
ipv6.c	net: fix data-races around sk->sk_forward_alloc	2024-11-11 15:29:33 -08:00
ipv6.h	ipv6: remove hard coded limitation on ipv6_pinfo	2023-07-24 09:39:31 +01:00
Kconfig
Makefile
minisocks.c	net: tcp: un-pin the tw_timer	2024-06-10 11:54:18 +01:00
options.c	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
output.c	net: add sk_wake_async_rcu() helper	2024-03-29 15:03:11 -07:00
proto.c	dccp: annotate data-races in dccp_poll()	2023-08-18 19:30:24 -07:00
qpolicy.c
sysctl.c	net: Remove the now superfluous sentinel elements from ctl_table array	2024-05-03 13:29:41 +01:00
timer.c	tcp: record last received ipv6 flowlabel	2023-10-10 10:02:59 +02:00
trace.h