linux-yocto/net/nfc
Krzysztof Kozlowski 55c3dbd838 NFC: nci: uart: Set tty->disc_data only in success path
commit fc27ab4890 upstream.

Setting tty->disc_data before opening the NCI device means we need to
clean it up on error paths.  This also opens some short window if device
starts sending data, even before NCIUARTSETDRIVER IOCTL succeeded
(broken hardware?).  Close the window by exposing tty->disc_data only on
the success path, when opening of the NCI device and try_module_get()
succeeds.

The code differs in error path in one aspect: tty->disc_data won't be
ever assigned thus NULL-ified.  This however should not be relevant
difference, because of "tty->disc_data=NULL" in nci_uart_tty_open().

Cc: Linus Torvalds <torvalds@linuxfoundation.org>
Fixes: 9961127d4b ("NFC: nci: add generic uart support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20250618073649.25049-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-06-27 11:11:21 +01:00
..
hci nfc: hci: Save a few bytes of memory when registering a 'nfc_llc' engine 2024-02-06 15:36:06 +01:00
nci NFC: nci: uart: Set tty->disc_data only in success path 2025-06-27 11:11:21 +01:00
af_nfc.c
core.c nfc: core: make nfc_class constant 2024-03-05 11:21:18 -08:00
digital_core.c net: fill in MODULE_DESCRIPTION()s for NFC 2024-01-11 16:16:08 -08:00
digital_dep.c
digital_technology.c
digital.h
Kconfig
llcp_commands.c
llcp_core.c nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local 2023-12-25 07:29:04 +00:00
llcp_sock.c net: change proto and proto_ops accept type 2024-05-13 18:19:09 -06:00
llcp.h
Makefile
netlink.c net: nfc: remove inappropriate attrs check 2024-04-12 18:52:35 -07:00
nfc.h
rawsock.c