Kees Cook db44404d1b randstruct: gcc-plugin: Remove bogus void member ... [ Upstream commit e136a40621 ] When building the randomized replacement tree of struct members, the randstruct GCC plugin would insert, as the first member, a 0-sized void member. This appears as though it was done to catch non-designated ("unnamed") static initializers, which wouldn't be stable since they depend on the original struct layout order. This was accomplished by having the side-effect of the "void member" tripping an assert in GCC internals (count_type_elements) if the member list ever needed to be counted (e.g. for figuring out the order of members during a non-designated initialization), which would catch impossible type (void) in the struct: security/landlock/fs.c: In function ‘hook_file_ioctl_common’: security/landlock/fs.c:1745:61: internal compiler error: in count_type_elements, at expr.cc:7075 1745 | .u.op = &(struct lsm_ioctlop_audit) { | ^ static HOST_WIDE_INT count_type_elements (const_tree type, bool for_ctor_p) { switch (TREE_CODE (type)) ... case VOID_TYPE: default: gcc_unreachable (); } } However this is a redundant safety measure since randstruct uses the __designated_initializer attribute both internally and within the __randomized_layout attribute macro so that this would be enforced by the compiler directly even when randstruct was not enabled (via -Wdesignated-init). A recent change in Landlock ended up tripping the same member counting routine when using a full-struct copy initializer as part of an anonymous initializer. This, however, is a false positive as the initializer is copying between identical structs (and hence identical layouts). The "path" member is "struct path", a randomized struct, and is being copied to from another "struct path", the "f_path" member: landlock_log_denial(landlock_cred(file->f_cred), &(struct landlock_request) { .type = LANDLOCK_REQUEST_FS_ACCESS, .audit = { .type = LSM_AUDIT_DATA_IOCTL_OP, .u.op = &(struct lsm_ioctlop_audit) { .path = file->f_path, .cmd = cmd, }, }, ... As can be seen with the coming randstruct KUnit test, there appears to be no behavioral problems with this kind of initialization when the void member is removed from the randstruct GCC plugin, so remove it. Reported-by: "Dr. David Alan Gilbert" <linux@treblig.org> Closes: https://lore.kernel.org/lkml/Z_PRaKx7q70MKgCA@gallifrey/ Reported-by: Mark Brown <broonie@kernel.org> Closes: https://lore.kernel.org/lkml/20250407-kbuild-disable-gcc-plugins-v1-1-5d46ae583f5e@kernel.org/ Reported-by: WangYuli <wangyuli@uniontech.com> Closes: https://lore.kernel.org/lkml/337D5D4887277B27+3c677db3-a8b9-47f0-93a4-7809355f1381@uniontech.com/ Fixes: 313dd1b629 ("gcc-plugins: Add the randstruct plugin") Signed-off-by: Kees Cook <kees@kernel.org> Stable-dep-of: f39f18f3c3 ("randstruct: gcc-plugin: Fix attribute addition") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-09-09 18:50:23 +02:00
..
atomic
basic
clang-tools	gen_compile_commands: fix invalid escape sequence warning	2024-03-26 18:21:12 -04:00
coccinelle
dtc	kbuild: Allow kernel installation packaging to override pkg-config	2023-02-01 08:27:30 +01:00
dummy-tools
gcc-plugins	randstruct: gcc-plugin: Remove bogus void member	2025-09-09 18:50:23 +02:00
gdb	scripts/gdb: fix SB_* constants parsing	2024-06-16 13:39:54 +02:00
genksyms	genksyms: fix memory leak when the same symbol is read from *.symref file	2025-03-13 12:50:13 +01:00
kconfig	kconfig: lxdialog: fix 'space' to (de)select options	2025-08-28 16:24:25 +02:00
ksymoops
mod	modpost: fix the missed iteration for the max bit in do_input()	2025-01-09 13:28:49 +01:00
package	builddeb: clean generated package content	2023-03-10 09:39:44 +01:00
selinux	selinux: Chain up tool resolving errors in install_policy.sh	2025-04-10 14:31:57 +02:00
tracing	ftrace/scripts: Update the instructions for ftrace-bisect.sh	2023-02-01 08:27:23 +01:00
.gitignore
adjust_autoksyms.sh
as-version.sh	kbuild: Update assembler calls to use proper flags and language target	2025-06-27 11:05:21 +01:00
asn1_compiler.c	ASN.1: Fix check for strdup() success	2023-04-26 13:51:56 +02:00
bin2c.c
bloat-o-meter
bootgraph.pl
bpf_doc.py	bpf, scripts: Correct GPL license name	2024-03-01 13:21:58 +01:00
cc-can-link.sh
cc-version.sh
check_extable.sh
check-sysctl-docs
checkdeclares.pl
checkincludes.pl
checkkconfigsymbols.py	scripts: handle BrokenPipeError for python scripts	2023-03-17 08:49:02 +01:00
checkpatch.pl
checkstack.pl	checkstack: fix printed address	2023-12-13 18:36:43 +01:00
checksyscalls.sh
checkversion.pl
cleanfile
cleanpatch
coccicheck
config	kbuild: fix argument parsing in scripts/config	2025-06-04 14:37:57 +02:00
const_structs.checkpatch
decode_stacktrace.sh	scripts/decode_stacktrace.sh: optionally use LLVM utilities	2024-02-23 08:55:13 +01:00
decodecode
depmod.sh
dev-needs.sh
diffconfig	scripts: handle BrokenPipeError for python scripts	2023-03-17 08:49:02 +01:00
documentation-file-ref-check
export_report.pl
extract_xc3028.pl
extract-cert.c
extract-ikconfig
extract-module-sig.pl
extract-sys-certs.pl
extract-vmlinux
faddr2line
file-size.sh
find-unused-docs.sh
gcc-goto.sh
gcc-ld
gcc-x86_32-has-stack-protector.sh	kbuild: Fix '-S -c' in x86 stack protector scripts	2024-08-19 05:45:16 +02:00
gcc-x86_64-has-stack-protector.sh	kbuild: Fix '-S -c' in x86 stack protector scripts	2024-08-19 05:45:16 +02:00
gen_autoksyms.sh
gen_ksymdeps.sh
generate_initcall_order.pl
get_abi.pl	scripts/get_abi: fix source path leak	2024-02-23 08:54:25 +01:00
get_dvb_firmware
get_feat.pl
get_maintainer.pl
gfp-translate
headerdep.pl
headers_check.pl
headers_install.sh
insert-sys-cert.c
jobserver-exec
kallsyms.c
Kbuild.include
Kconfig.include	kbuild: Update assembler calls to use proper flags and language target	2025-06-27 11:05:21 +01:00
kernel-doc
ld-version.sh	kbuild: Make ld-version.sh more robust against version string changes	2024-07-18 13:07:45 +02:00
leaking_addresses.pl
Lindent
link-vmlinux.sh	kbuild: fix short log for AS in link-vmlinux.sh	2024-07-18 13:07:36 +02:00
Makefile	kbuild: Allow kernel installation packaging to override pkg-config	2023-02-01 08:27:30 +01:00
Makefile.asm-generic
Makefile.build
Makefile.clang	kbuild: add $(CLANG_FLAGS) to KBUILD_CPPFLAGS	2025-06-27 11:05:21 +01:00
Makefile.clean
Makefile.compiler	kbuild: Add KBUILD_CPPFLAGS to as-option invocation	2025-06-27 11:05:21 +01:00
Makefile.dtbinst	kbuild: Install dtb files as 0644 in Makefile.dtbinst	2024-07-05 09:14:48 +02:00
Makefile.extrawarn	kbuild: Move -Wenum-enum-conversion to W=2	2025-03-13 12:50:29 +01:00
Makefile.gcc-plugins
Makefile.headersinst
Makefile.host
Makefile.kasan
Makefile.kcov
Makefile.kcsan
Makefile.lib
Makefile.modfinal	kbuild: Disable KCSAN for autogenerated *.mod.c intermediaries	2024-05-17 11:50:53 +02:00
Makefile.modinst
Makefile.modpost
Makefile.package
Makefile.ubsan
Makefile.userprogs
makelst
markup_oops.pl
min-tool-version.sh
mkcompile_h
mksysmap
mkuboot.sh
module.lds.S
modules-check.sh
nsdeps
objdiff
pahole-flags.sh	bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25	2024-01-25 14:52:31 -08:00
pahole-version.sh	kbuild: Add CONFIG_PAHOLE_VERSION	2023-02-25 12:06:45 +01:00
parse-maintainers.pl
patch-kernel
profile2linkerlist.pl
prune-kernel
recordmcount.c	recordmcount: Fix memory leaks in the uwrite function	2023-05-24 17:36:47 +01:00
recordmcount.h
recordmcount.pl
remove-stale-files
setlocalversion
show_delta
sign-file.c	sign-file: Fix incorrect return values check	2023-12-20 15:17:37 +01:00
sorttable.c
sorttable.h	scripts/sorttable: fix orc_sort_cmp() to maintain symmetry and transitivity	2025-01-23 17:15:52 +01:00
spdxcheck-test.sh
spdxcheck.py
spelling.txt
sphinx-pre-install
split-man.pl
stackdelta
stackusage
subarch.include
syscallhdr.sh
syscallnr.sh
syscalltbl.sh
tags.sh	scripts/tags.sh: Resolve gtags empty index generation	2023-07-05 18:25:05 +01:00
tools-support-relr.sh
unifdef.c
ver_linux
xen-hypercalls.sh
xz_wrap.sh