Eric Sandeen dcdf36f1b6 xfs: do not propagate ENODATA disk errors into xattr code ... commit ae668cd567a6a7622bc813ee0bb61c42bed61ba7 upstream. ENODATA (aka ENOATTR) has a very specific meaning in the xfs xattr code; namely, that the requested attribute name could not be found. However, a medium error from disk may also return ENODATA. At best, this medium error may escape to userspace as "attribute not found" when in fact it's an IO (disk) error. At worst, we may oops in xfs_attr_leaf_get() when we do: error = xfs_attr_leaf_hasname(args, &bp); if (error == -ENOATTR) { xfs_trans_brelse(args->trans, bp); return error; } because an ENODATA/ENOATTR error from disk leaves us with a null bp, and the xfs_trans_brelse will then null-deref it. As discussed on the list, we really need to modify the lower level IO functions to trap all disk errors and ensure that we don't let unique errors like this leak up into higher xfs functions - many like this should be remapped to EIO. However, this patch directly addresses a reported bug in the xattr code, and should be safe to backport to stable kernels. A larger-scope patch to handle more unique errors at lower levels can follow later. (Note, prior to 07120f1abd we did not oops, but we did return the wrong error code to userspace.) Signed-off-by: Eric Sandeen <sandeen@redhat.com> Fixes: 07120f1abd ("xfs: Add xfs_has_attr and subroutines") Cc: stable@vger.kernel.org # v5.9+ Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Carlos Maiolino <cem@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-09-04 15:31:54 +02:00
..
xfs_ag_resv.c
xfs_ag_resv.h	xfs: get rid of xfs_ag_resv_rmapbt_alloc	2024-07-04 14:36:13 +05:30
xfs_ag.c	xfs: update the pag for the last AG at recovery time	2024-10-22 13:37:19 +02:00
xfs_ag.h	xfs: update the pag for the last AG at recovery time	2024-10-22 13:37:19 +02:00
xfs_alloc_btree.c	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_alloc_btree.h	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_alloc.c	xfs: Reduce unnecessary searches when searching for the best extents	2024-10-30 11:27:18 +01:00
xfs_alloc.h	xfs: don't ifdef around the exact minlen allocations	2024-10-07 08:00:11 +02:00
xfs_attr_leaf.c	xfs: distinguish extra split from real ENOSPC from xfs_attr3_leaf_split	2024-10-07 08:00:11 +02:00
xfs_attr_leaf.h	xfs: return bool from xfs_attr3_leaf_add	2024-10-07 08:00:11 +02:00
xfs_attr_remote.c	xfs: do not propagate ENODATA disk errors into xattr code	2025-09-04 15:31:54 +02:00
xfs_attr_remote.h	xfs: create a helper to compute the blockcount of a max sized remote value	2024-05-02 07:48:36 -07:00
xfs_attr_sf.h
xfs_attr.c	xfs: distinguish extra split from real ENOSPC from xfs_attr_node_try_addname	2024-10-07 08:00:11 +02:00
xfs_attr.h	xfs: fix xfs_init_attr_trans not handling explicit operation codes	2024-05-27 15:55:52 +05:30
xfs_bit.c
xfs_bit.h
xfs_bmap_btree.c	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_bmap_btree.h	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_bmap.c	xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc	2024-10-07 08:00:12 +02:00
xfs_bmap.h	xfs: hoist extent size helpers to libxfs	2024-07-02 11:36:55 -07:00
xfs_btree_mem.c
xfs_btree_mem.h
xfs_btree_staging.c
xfs_btree_staging.h
xfs_btree.c	xfs: return a 64-bit block count from xfs_btree_count_blocks	2024-12-19 18:13:08 +01:00
xfs_btree.h	xfs: return a 64-bit block count from xfs_btree_count_blocks	2024-12-19 18:13:08 +01:00
xfs_cksum.h
xfs_da_btree.c	xfs: do not propagate ENODATA disk errors into xattr code	2025-09-04 15:31:54 +02:00
xfs_da_btree.h
xfs_da_format.h	xfs: turn XFS_ATTR3_RMT_BUF_SPACE into a function	2024-05-02 07:48:36 -07:00
xfs_defer.c	xfs: Remove duplicate xfs_trans_priv.h header	2024-09-03 10:07:41 +05:30
xfs_defer.h
xfs_dir2_block.c
xfs_dir2_data.c	xfs: don't walk off the end of a directory data block	2024-07-01 09:32:29 +05:30
xfs_dir2_leaf.c
xfs_dir2_node.c
xfs_dir2_priv.h	xfs: don't walk off the end of a directory data block	2024-07-01 09:32:29 +05:30
xfs_dir2_sf.c
xfs_dir2.c	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_dir2.h	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_dquot_buf.c
xfs_errortag.h
xfs_exchmaps.c	xfs: refactor dir format helpers	2024-04-26 11:21:46 +05:30
xfs_exchmaps.h
xfs_format.h	xfs: don't use the incore struct xfs_sb for offsets into struct xfs_dsb	2024-07-02 11:37:00 -07:00
xfs_fs.h	xfs: fix C++ compilation errors in xfs_fs.h	2024-09-01 08:58:20 -07:00
xfs_health.h	xfs: report directory tree corruption in the health information	2024-04-23 16:55:17 -07:00
xfs_ialloc_btree.c	xfs: return a 64-bit block count from xfs_btree_count_blocks	2024-12-19 18:13:08 +01:00
xfs_ialloc_btree.h	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_ialloc.c	xfs: fix sparse inode limits on runt AG	2024-12-27 14:02:00 +01:00
xfs_ialloc.h	xfs: pass the icreate args object to xfs_dialloc	2024-09-01 08:58:19 -07:00
xfs_iext_tree.c
xfs_inode_buf.c	xfs: fix di_onlink checking for V1/V2 inodes	2024-08-26 09:50:41 +05:30
xfs_inode_buf.h
xfs_inode_fork.c	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_inode_fork.h	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_inode_util.c	xfs: remove unnecessary check	2024-09-03 10:07:40 +05:30
xfs_inode_util.h	xfs: hoist inode free function to libxfs	2024-07-02 11:36:59 -07:00
xfs_log_format.h
xfs_log_recover.h
xfs_log_rlimit.c	xfs: drop compatibility minimum log size computations for reflink	2024-04-23 07:47:01 -07:00
xfs_ondisk.h	xfs: don't use the incore struct xfs_sb for offsets into struct xfs_dsb	2024-07-02 11:37:00 -07:00
xfs_parent.c	xfs: add raw parent pointer apis to support repair	2024-04-23 07:47:04 -07:00
xfs_parent.h	xfs: add raw parent pointer apis to support repair	2024-04-23 07:47:04 -07:00
xfs_quota_defs.h	xfs: remove unused parameter in macro XFS_DQUOT_LOGRES	2024-07-29 09:29:31 +05:30
xfs_refcount_btree.c	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_refcount_btree.h	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_refcount.c	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_refcount.h	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_rmap_btree.c	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_rmap_btree.h	xfs: standardize the btree maxrecs function parameters	2024-09-01 08:58:20 -07:00
xfs_rmap.c	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rmap.h	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rtbitmap.c	xfs: replace m_rsumsize with m_rsumblocks	2024-09-01 08:58:19 -07:00
xfs_rtbitmap.h	xfs: remove xfs_{rtbitmap,rtsummary}_wordcount	2024-09-01 08:58:19 -07:00
xfs_sb.c	xfs: fix sb_spino_align checks for large fsblock sizes	2024-12-27 14:02:01 +01:00
xfs_sb.h	xfs: ensure rtx mask/shift are correct after growfs	2024-09-01 08:58:19 -07:00
xfs_shared.h	xfs: enable block size larger than page size support	2024-09-03 15:00:52 +02:00
xfs_symlink_remote.c	xfs: return from xfs_symlink_verify early on V4 filesystems	2024-12-19 18:13:08 +01:00
xfs_symlink_remote.h
xfs_trans_inode.c	xfs: implement atime updates in xfs_trans_ichgtime	2024-07-02 11:36:56 -07:00
xfs_trans_resv.c	xfs: replace shouty XFS_BM{BT,DR} macros	2024-09-01 08:58:20 -07:00
xfs_trans_resv.h
xfs_trans_space.c
xfs_trans_space.h
xfs_types.c
xfs_types.h	xfs: remove xfs_validate_rtextents	2024-09-01 08:58:19 -07:00