Al Viro d717325b5e clone_private_mnt(): make sure that caller has CAP_SYS_ADMIN in the right userns ... commit c28f922c9d upstream. What we want is to verify there is that clone won't expose something hidden by a mount we wouldn't be able to undo. "Wouldn't be able to undo" may be a result of MNT_LOCKED on a child, but it may also come from lacking admin rights in the userns of the namespace mount belongs to. clone_private_mnt() checks the former, but not the latter. There's a number of rather confusing CAP_SYS_ADMIN checks in various userns during the mount, especially with the new mount API; they serve different purposes and in case of clone_private_mnt() they usually, but not always end up covering the missing check mentioned above. Reviewed-by: Christian Brauner <brauner@kernel.org> Reported-by: "Orlando, Noah" <Noah.Orlando@deshaw.com> Fixes: 427215d85e ("ovl: prevent private clone if bind mount is not allowed") Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> [ merge conflict resolution: clone_private_mount() was reworked in db04662e2f ("fs: allow detached mounts in clone_private_mount()"). Tweak the relevant ns_capable check so that it works on older kernels ] Signed-off-by: Noah Orlando <Noah.Orlando@deshaw.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-07-24 08:51:54 +02:00
..
9p	fs/9p: fix uninitialized values during inode evict	2024-11-22 15:37:34 +01:00
adfs
affs	affs: don't write overlarge OFS data block size fields	2025-04-10 14:33:38 +02:00
afs	afs: Fix the server_list to unuse a displaced server rather than putting it	2025-03-07 16:56:43 +01:00
autofs	autofs: fix memory leak of waitqueues in autofs_catatonic_mode	2023-09-23 11:10:59 +02:00
befs
bfs
btrfs	btrfs: fix assertion when building free space tree	2025-07-17 18:32:14 +02:00
cachefiles	cachefiles: Fix the incorrect return value in __cachefiles_write()	2025-07-24 08:51:51 +02:00
ceph	ceph: fix possible integer overflow in ceph_zero_objects()	2025-07-06 10:57:56 +02:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-10 09:33:52 +01:00
configfs	configfs: Do not override creating attribute file failure in populate_attrs()	2025-06-27 11:07:25 +01:00
cramfs	fs/cramfs/inode.c: initialize file_ra_state	2023-03-10 09:34:09 +01:00
crypto	fs: Create a generic is_dot_dotdot() utility	2024-10-17 15:21:17 +02:00
debugfs	debugfs: fix automount d_fsdata usage	2024-01-20 11:50:04 +01:00
devpts
dlm	dlm: make tcp still work in multi-link env	2025-06-04 14:40:05 +02:00
ecryptfs	fs: Create a generic is_dot_dotdot() utility	2024-10-17 15:21:17 +02:00
efivarfs	efivarfs: Fix error on non-existent file	2024-12-27 13:52:55 +01:00
efs
erofs	erofs: fix to add missing tracepoint in erofs_read_folio()	2025-07-17 18:32:12 +02:00
exfat	exfat: fix the infinite loop in exfat_find_last_cluster()	2025-04-10 14:33:37 +02:00
exportfs	exportfs: use pr_debug for unreachable debug statements	2024-03-06 14:45:15 +00:00
ext2	ext2: Verify bitmap and itable block numbers before using them	2024-08-03 08:49:32 +02:00
ext4	ext4: ensure i_size is smaller than maxbytes	2025-06-27 11:07:29 +01:00
f2fs	f2fs: don't over-report free space or inodes in statvfs	2025-07-06 10:57:57 +02:00
fat	fat: fix uninitialized variable	2024-10-22 15:56:43 +02:00
freevxfs
fscache	netfs/fscache: Add a memory barrier for FSCACHE_VOLUME_CREATING	2024-12-14 19:53:15 +01:00
fuse	fuse: Return EPERM rather than ENOSYS from link()	2025-06-04 14:40:02 +02:00
gfs2	gfs2: move msleep to sleepable context	2025-06-27 11:07:25 +01:00
hfs	hfs/hfsplus: fix slab-out-of-bounds in hfs_bnode_read_key	2025-04-25 10:43:53 +02:00
hfsplus	hfs/hfsplus: fix slab-out-of-bounds in hfs_bnode_read_key	2025-04-25 10:43:53 +02:00
hostfs
hpfs
hugetlbfs	mm/hugetlb: add hugetlb_folio_subpool() helpers	2024-05-17 11:55:51 +02:00
iomap	iomap: avoid avoid truncating 64-bit offset to 32 bits	2025-01-23 17:17:12 +01:00
isofs	isofs: Verify inode mode when loading from disk	2025-07-24 08:51:49 +02:00
jbd2	jbd2: fix data-race and null-ptr-deref in jbd2_journal_dirty_metadata()	2025-06-27 11:07:26 +01:00
jffs2	jffs2: check jffs2_prealloc_raw_node_refs() result in few other places	2025-06-27 11:07:36 +01:00
jfs	jfs: validate AG parameters in dbMount() to prevent crashes	2025-07-06 10:57:57 +02:00
kernfs	kernfs: Relax constraint in draining guard	2025-06-27 11:07:11 +01:00
lockd	nfsd: stop setting ->pg_stats for unused stats	2024-08-19 06:00:04 +02:00
minix
netfs	netfs: Only call folio_start_fscache() one time for each folio	2023-10-06 14:56:32 +02:00
nfs	NFSv4/flexfiles: Fix handling of NFS level errors in I/O	2025-07-10 15:59:51 +02:00
nfs_common
nfsd	nfsd: Initialize ssc before laundromat_work to prevent NULL dereference	2025-06-27 11:07:26 +01:00
nilfs2	nilfs2: do not propagate ENOENT error from nilfs_btree_propagate()	2025-06-27 11:07:13 +01:00
nls	fs/nls: make load_nls() take a const parameter	2023-09-13 09:42:22 +02:00
notify	fsnotify: fix sending inotify event with unexpected filename	2024-12-14 19:53:59 +01:00
ntfs
ntfs3	fs/ntfs3: handle hdr_first_de() return value	2025-06-27 11:07:08 +01:00
ocfs2	ocfs2: fix possible memory leak in ocfs2_finish_quota_recovery	2025-06-27 11:07:13 +01:00
omfs	fs: omfs: Use flexible-array member in struct omfs_extent	2025-07-06 10:58:03 +02:00
openpromfs	openpromfs: finish conversion to the new mount API	2024-06-12 11:03:03 +02:00
orangefs	orangefs: Do not truncate file size	2025-06-04 14:40:08 +02:00
overlayfs	ovl: Check for NULL d_inode() in ovl_dentry_upper()	2025-07-06 10:57:56 +02:00
proc	fix proc_sys_compare() handling of in-lookup dentries	2025-07-17 18:32:05 +02:00
pstore	pstore/blk: trivial typo fixes	2025-02-21 13:48:53 +01:00
qnx4
qnx6
quota	quota: flush quota_release_work upon quota writeback	2024-12-14 19:54:10 +01:00
ramfs	shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs	2023-07-19 16:22:11 +02:00
reiserfs	reiserfs: fix uninit-value in comp_keys	2024-08-29 17:30:20 +02:00
romfs
smb	smb: client: fix use-after-free in cifs_oplock_break	2025-07-24 08:51:52 +02:00
squashfs	Squashfs: check return result of sb_min_blocksize	2025-06-27 11:07:13 +01:00
sysfs	fs: sysfs: Fix reference leak in sysfs_break_active_protection()	2024-04-27 17:07:16 +02:00
sysv	sysv: don't call sb_bread() with pointers_lock held	2024-04-13 13:05:05 +02:00
tracefs	tracefs: Add missing lockdown check to tracefs_create_dir()	2023-09-23 11:11:12 +02:00
ubifs	ubifs: skip dumping tnc tree when zroot is null	2025-02-21 13:49:21 +01:00
udf	udf: Fix directory iteration for longer tail extents	2024-12-27 13:53:01 +01:00
ufs
unicode	Revert "unicode: Don't special case ignorable code points"	2024-12-14 19:54:50 +01:00
vboxsf	vboxsf: fix building with GCC 15	2025-03-28 21:58:51 +01:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-09-13 09:43:03 +02:00
xfs	xfs: reset rootdir extent size hint after growfsrt	2025-06-27 11:07:20 +01:00
zonefs	zonefs: Improve error handling	2024-02-23 09:12:45 +01:00
aio.c	fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion	2024-04-03 15:19:42 +02:00
anon_inodes.c	fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass	2025-07-17 18:32:10 +02:00
attr.c	attr: block mode changes of symlinks	2023-09-23 11:11:10 +02:00
bad_inode.c
binfmt_elf_fdpic.c	binfmt: Fix whitespace issues	2025-05-22 14:09:58 +02:00
binfmt_elf_test.c
binfmt_elf.c	binfmt_elf: Move brk for static PIE even if ASLR disabled	2025-05-22 14:09:59 +02:00
binfmt_flat.c	binfmt_flat: Fix integer overflow bug on 32 bit systems	2025-02-21 13:49:39 +01:00
binfmt_misc.c	binfmt_misc: cleanup on filesystem umount	2024-08-29 17:30:30 +02:00
binfmt_script.c
buffer.c
char_dev.c
compat_binfmt_elf.c
coredump.c	coredump: hand a pidfd to the usermode coredump helper	2025-06-04 14:40:25 +02:00
d_path.c
dax.c	fsdax: dax_unshare_iter needs to copy entire blocks	2024-11-08 16:26:42 +01:00
dcache.c	fs: better handle deep ancestor chains in is_subdir()	2024-07-25 09:49:18 +02:00
direct-io.c
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-13 09:42:27 +02:00
eventpoll.c	epoll: Add synchronous wakeup support for ep_poll_callback	2024-12-27 13:53:01 +01:00
exec.c	binfmt: Fix whitespace issues	2025-05-22 14:09:58 +02:00
fcntl.c	fs: Fix file_set_fowner LSM hook inconsistencies	2024-10-17 15:21:23 +02:00
fhandle.c	do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak	2024-03-26 18:20:27 -04:00
file_table.c	fs: fix proc_handler for sysctl_nr_open	2025-02-21 13:48:53 +01:00
file.c	fs: consistently deref the files table with rcu_dereference_raw()	2025-04-25 10:43:27 +02:00
filesystems.c	fs/filesystems: Fix potential unsigned integer underflow in fs_name()	2025-06-27 11:07:23 +01:00
fs_context.c	vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing	2023-09-13 09:42:28 +02:00
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	writeback, cgroup: switch inodes with dirty timestamps to release dying cgwbs	2023-11-20 11:51:50 +01:00
fsopen.c
init.c
inode.c	fs/inode: Prevent dump_mapping() accessing invalid dentry.d_name.name	2024-12-14 19:53:13 +01:00
internal.h	nfs: use vfs setgid helper	2023-08-30 16:11:10 +02:00
ioctl.c	lsm: new security_file_ioctl_compat() hook	2024-01-31 16:17:00 -08:00
Kconfig	nfs: add missing selections of CONFIG_CRC32	2025-04-25 10:43:52 +02:00
Kconfig.binfmt
kernel_read_file.c
libfs.c
locks.c	filelock: Fix fcntl/close race recovery compat path	2024-07-27 11:32:19 +02:00
Makefile	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
mbcache.c
mount.h
mpage.c
namei.c	fuse: don't truncate cached, mutated symlink	2025-03-28 21:58:53 +01:00
namespace.c	clone_private_mnt(): make sure that caller has CAP_SYS_ADMIN in the right userns	2025-07-24 08:51:54 +02:00
no-block.c
nsfs.c
open.c	openat2: explicitly return -E2BIG for (usize > PAGE_SIZE)	2024-11-01 01:56:06 +01:00
pipe.c	fs/pipe: Fix lockdep false-positive in watchqueue pipe_write()	2024-04-10 16:28:30 +02:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
readdir.c
remap_range.c
select.c	hrtimer: Use and report correct timerslack values for realtime tasks	2025-03-28 21:58:48 +01:00
seq_file.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
signalfd.c
splice.c	mm: merge folio_has_private()/filemap_release_folio() call pairs	2024-01-10 17:10:31 +01:00
stack.c
stat.c
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-24 17:32:51 +01:00
super.c	fs: don't allow non-init s_user_ns for filesystems without FS_USERNS_MOUNT	2024-08-03 08:49:53 +02:00
sync.c
sysctls.c
timerfd.c
userfaultfd.c	mm/uffd: fix vma operation where start addr cuts part of vma	2025-06-27 11:07:04 +01:00
utimes.c
xattr.c