Kees Cook f28f1f578c fbcon: Make sure modelist not set on unregistered console ... [ Upstream commit cedc1b6339 ] It looks like attempting to write to the "store_modes" sysfs node will run afoul of unregistered consoles: UBSAN: array-index-out-of-bounds in drivers/video/fbdev/core/fbcon.c:122:28 index -1 is out of range for type 'fb_info *[32]' ... fbcon_info_from_console+0x192/0x1a0 drivers/video/fbdev/core/fbcon.c:122 fbcon_new_modelist+0xbf/0x2d0 drivers/video/fbdev/core/fbcon.c:3048 fb_new_modelist+0x328/0x440 drivers/video/fbdev/core/fbmem.c:673 store_modes+0x1c9/0x3e0 drivers/video/fbdev/core/fbsysfs.c:113 dev_attr_store+0x55/0x80 drivers/base/core.c:2439 static struct fb_info *fbcon_registered_fb[FB_MAX]; ... static signed char con2fb_map[MAX_NR_CONSOLES]; ... static struct fb_info *fbcon_info_from_console(int console) ... return fbcon_registered_fb[con2fb_map[console]]; If con2fb_map contains a -1 things go wrong here. Instead, return NULL, as callers of fbcon_info_from_console() are trying to compare against existing "info" pointers, so error handling should kick in correctly. Reported-by: syzbot+a7d4444e7b6e743572f7@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/679d0a8f.050a0220.163cdc.000c.GAE@google.com/ Signed-off-by: Kees Cook <kees@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2025-06-27 11:11:35 +01:00
..
backlight	backlight: pm8941: Add NULL check in wled_configure()	2025-06-19 15:32:04 +02:00
console	dummycon: Trigger redraw when switching consoles with deferred takeover	2025-06-27 11:11:26 +01:00
fbdev	fbcon: Make sure modelist not set on unregistered console	2025-06-27 11:11:35 +01:00
logo
aperture.c
cmdline.c
display_timing.c
hdmi.c
Kconfig
Makefile
nomodeset.c
of_display_timing.c
of_videomode.c
screen_info_generic.c
screen_info_pci.c	video: screen_info: Relocate framebuffers behind PCI bridges	2025-06-27 11:11:23 +01:00
sticore.c
vgastate.c
videomode.c