Martin KaFai Lau da70cb95b8 bpftool: Fix cgroup command to only show cgroup bpf programs ... commit b69d4413aa upstream. The netkit program is not a cgroup bpf program and should not be shown in the output of the "bpftool cgroup show" command. However, if the netkit device happens to have ifindex 3, the "bpftool cgroup show" command will output the netkit bpf program as well: > ip -d link show dev nk1 3: nk1@if2: ... link/ether ... netkit mode ... > bpftool net show tc: nk1(3) netkit/peer tw_ns_nk2phy prog_id 469447 > bpftool cgroup show /sys/fs/cgroup/... ID AttachType AttachFlags Name ... ... ... 469447 netkit_peer tw_ns_nk2phy The reason is that the target_fd (which is the cgroup_fd here) and the target_ifindex are in a union in the uapi/linux/bpf.h. The bpftool iterates all values in "enum bpf_attach_type" which includes non cgroup attach types like netkit. The cgroup_fd is usually 3 here, so the bug is triggered when the netkit ifindex just happens to be 3 as well. The bpftool's cgroup.c already has a list of cgroup-only attach type defined in "cgroup_attach_types[]". This patch fixes it by iterating over "cgroup_attach_types[]" instead of "__MAX_BPF_ATTACH_TYPE". Cc: Quentin Monnet <qmo@kernel.org> Reported-by: Takshak Chahande <ctakshak@meta.com> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Quentin Monnet <qmo@kernel.org> Link: https://lore.kernel.org/r/20250507203232.1420762-1-martin.lau@linux.dev Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-06-27 11:11:46 +01:00
..
bpftool	bpftool: Fix cgroup command to only show cgroup bpf programs	2025-06-27 11:11:46 +01:00
resolve_btfids	tools/resolve_btfids: Fix build when cross compiling kernel with clang.	2025-06-19 15:32:33 +02:00
runqslower	tools/runqslower: Fix LDFLAGS and add LDLIBS support	2024-07-29 15:05:05 -07:00
.gitignore
bpf_asm.c
bpf_dbg.c	bpf: Simplify the calculation of variables	2021-03-04 19:24:53 -08:00
bpf_exp.l
bpf_exp.y	tools, bpf_asm: Exit non-zero on errors	2021-02-26 22:53:50 +01:00
bpf_jit_disasm.c	tools bpf_jit_disasm: Fix compilation error with new binutils	2022-08-01 15:30:48 -03:00
Makefile	tools bpf_jit_disasm: Don't display disassembler-four-args feature test	2022-08-01 15:31:51 -03:00