Paul Chaignon 6952aeace9 bpf: Reject %p% format string in bprintf-like helpers ... [ Upstream commit f824274587 ] static const char fmt[] = "%p%"; bpf_trace_printk(fmt, sizeof(fmt)); The above BPF program isn't rejected and causes a kernel warning at runtime: Please remove unsupported %\x00 in format string WARNING: CPU: 1 PID: 7244 at lib/vsprintf.c:2680 format_decode+0x49c/0x5d0 This happens because bpf_bprintf_prepare skips over the second %, detected as punctuation, while processing %p. This patch fixes it by not skipping over punctuation. %\x00 is then processed in the next iteration and rejected. Reported-by: syzbot+e2c932aec5c8a6e1d31c@syzkaller.appspotmail.com Fixes: 48cac3f4a9 ("bpf: Implement formatted output helpers with bstr_printf") Acked-by: Yonghong Song <yonghong.song@linux.dev> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com> Link: https://lore.kernel.org/r/a0e06cc479faec9e802ae51ba5d66420523251ee.1751395489.git.paul.chaignon@gmail.com Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2025-07-24 08:56:29 +02:00
..
preload	bpf: Fix BPF_INTERNAL namespace import	2025-05-05 11:00:29 +02:00
arena.c	bpf: Fix softlockup in arena_map_free on 64k page kernel	2025-02-27 04:30:19 -08:00
arraymap.c	bpf: Prevent tailcall infinite loop caused by freplace	2024-12-14 20:03:49 +01:00
bloom_filter.c	bpf: Check bloom filter map value size	2024-03-27 09:56:17 -07:00
bpf_cgrp_storage.c	bpf: Only fails the busy counter check in bpf_cgrp_storage_get if it creates storage	2025-05-02 07:59:16 +02:00
bpf_inode_storage.c	bpf: switch fdget_raw() uses to CLASS(fd_raw, ...)	2024-08-13 15:58:10 -07:00
bpf_iter.c	[tree-wide] finally take no_llseek out	2024-09-27 08:18:43 -07:00
bpf_local_storage.c	bpf: bpf_local_storage: Always use bpf_mem_alloc in PREEMPT_RT	2025-02-08 09:57:29 +01:00
bpf_lru_list.c	bpf: Adjust free target to avoid global starvation of LRU map	2025-07-17 18:37:22 +02:00
bpf_lru_list.h	bpf: Adjust free target to avoid global starvation of LRU map	2025-07-17 18:37:22 +02:00
bpf_lsm.c	bpf, lsm: Remove bpf_lsm_key_free hook	2024-10-08 12:52:40 -07:00
bpf_struct_ops.c	bpf: Pass the same orig_call value to trampoline functions	2025-06-27 11:11:31 +01:00
bpf_task_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
btf_iter.c	bpf: Remove custom build rule	2024-08-30 08:55:26 -07:00
btf_relocate.c	bpf: Remove custom build rule	2024-08-30 08:55:26 -07:00
btf.c	bpf: Use proper type to calculate bpf_raw_tp_null_args.mask index	2025-06-27 11:11:33 +01:00
cgroup_iter.c	bpf: Let verifier consider {task,cgroup} is trusted in bpf_iter_reg	2023-11-07 15:24:25 -08:00
cgroup.c	bpf: Allow pre-ordering for bpf cgroup progs	2025-05-29 11:02:17 +02:00
core.c	bpf: Avoid __bpf_prog_ret0_warn when jit fails	2025-06-19 15:31:54 +02:00
cpumap.c	bpf, cpumap: Move xdp:xdp_cpumap_kthread tracepoint before rcv	2024-09-11 16:32:11 +02:00
cpumask.c	bpf: Allow invoking kfuncs from BPF_PROG_TYPE_SYSCALL progs	2024-04-05 10:56:09 -07:00
crypto.c	bpf: crypto: make state and IV dynptr nullable	2024-06-13 16:33:04 -07:00
devmap.c	bpf: fix OOB devmap writes when deleting elements	2024-12-14 20:03:30 +01:00
disasm.c	bpf: add special internal-only MOV instruction to resolve per-CPU addrs	2024-04-03 10:29:55 -07:00
disasm.h
dispatcher.c	bpf: Add kernel symbol for struct_ops trampoline	2024-12-05 14:01:57 +01:00
hashtab.c	bpf: fix possible endless loop in BPF map iteration	2025-05-29 11:02:01 +02:00
helpers.c	bpf: Reject %p% format string in bprintf-like helpers	2025-07-24 08:56:29 +02:00
inode.c	bpf: Preserve param->string when parsing mount options	2024-10-22 12:56:38 -07:00
Kconfig	bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of	2024-05-14 00:36:29 -07:00
link_iter.c
local_storage.c	bpf: Replace 8 seq_puts() calls by seq_putc() calls	2024-07-29 12:53:00 -07:00
log.c	bpf: Fix print_reg_state's constant scalar dump	2024-10-17 11:06:34 -07:00
lpm_trie.c	bpf: Fix exact match conditions in trie_get_next_key()	2024-12-14 20:03:19 +01:00
Makefile	bpf: Remove custom build rule	2024-08-30 08:55:26 -07:00
map_in_map.c	bpf: switch maps to CLASS(fd, ...)	2024-08-13 15:58:17 -07:00
map_in_map.h	bpf: Add map and need_defer parameters to .map_fd_put_ptr()	2023-12-04 17:50:26 -08:00
map_iter.c	bpf: treewide: Annotate BPF kfuncs in BTF	2024-01-31 20:40:56 -08:00
memalloc.c	bpf: Add bpf_mem_alloc_check_size() helper	2024-10-30 12:13:46 -07:00
mmap_unlock_work.h
mprog.c	bpf: Handle bpf_mprog_query with NULL entry	2023-10-06 17:11:20 -07:00
net_namespace.c
offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-09-21 21:49:45 +02:00
percpu_freelist.c	bpf: Initialize same number of free nodes for each pcpu_freelist	2022-11-11 12:05:14 -08:00
percpu_freelist.h
prog_iter.c
queue_stack_maps.c	bpf: Avoid deadlock when using queue and stack maps from NMI	2023-09-11 19:04:49 -07:00
relo_core.c	bpf: Remove custom build rule	2024-08-30 08:55:26 -07:00
reuseport_array.c	bpf: Use sockfd_put() helper	2024-08-30 08:57:47 -07:00
ringbuf.c	bpf: unify VM_WRITE vs VM_MAYWRITE use in BPF map mmaping logic	2025-02-27 04:30:18 -08:00
stackmap.c	bpf: wire up sleepable bpf_get_stack() and bpf_get_task_stack() helpers	2024-09-11 09:58:31 -07:00
syscall.c	bpf: Allow pre-ordering for bpf cgroup progs	2025-05-29 11:02:17 +02:00
sysfs_btf.c	btf: Avoid weak external references	2024-04-16 16:35:13 +02:00
task_iter.c	bpf: Fix iter/task tid filtering	2024-10-17 10:52:18 -07:00
tcx.c	bpf, tcx: Get rid of tcx_link_const	2023-10-23 15:01:53 -07:00
tnum.c	bpf: simplify tnum output if a fully known constant	2023-12-02 11:36:51 -08:00
token.c	bpf: convert bpf_token_create() to CLASS(fd, ...)	2024-09-12 18:58:02 -07:00
trampoline.c	bpf: Prevent tailcall infinite loop caused by freplace	2024-12-14 20:03:49 +01:00
verifier.c	bpf: Do not include stack ptr register in precision backtracking bookkeeping	2025-07-10 16:05:00 +02:00