linux-yocto/tools/perf/ui
Arnaldo Carvalho de Melo baf8a7fed0 perf ui browser hists: Set actions->thread before calling do_zoom_thread()
[ Upstream commit 1741189d84 ]

In 7cecb7fe83 ("perf hists: Move sort__has_comm into struct
perf_hpp_list") it assumes that act->thread is set prior to calling
do_zoom_thread().

This doesn't happen when we use ESC or the Left arrow key to Zoom out of
a specific thread, making this operation not to work and we get stuck
into the thread zoom.

In 6422184b08 ("perf hists browser: Simplify zooming code using
pstack_peek()") it says no need to set actions->thread, and at that
point that was true, but in 7cecb7fe83 a actions->thread == NULL
check was added before the zoom out of thread could kick in.

We can zoom out using the alternative 't' thread zoom toggle hotkey to
finally set actions->thread before calling do_zoom_thread() and zoom
out, but lets also fix the ESC/Zoom out of thread case.

Fixes: 7cecb7fe83 ("perf hists: Move sort__has_comm into struct perf_hpp_list")
Reported-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/Z_TYux5fUg2pW-pF@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-06-19 15:32:04 +02:00
..
browsers perf ui browser hists: Set actions->thread before calling do_zoom_thread() 2025-06-19 15:32:04 +02:00
gtk perf dso: Fix address sanitizer build 2024-07-12 09:38:41 -07:00
stdio perf tools: Print lost samples due to BPF filter 2024-08-28 18:07:20 -03:00
tui perf ui: Make ui its own library 2024-06-26 11:06:34 -07:00
browser.c perf ui browser: Avoid SEGV on title 2024-05-09 18:12:47 -03:00
browser.h perf ui browser: Don't save pointer to stack memory 2024-05-07 18:05:31 -03:00
Build perf ui: Make ui its own library 2024-06-26 11:06:34 -07:00
helpline.c
helpline.h
hist.c perf hist: Don't set hpp_fmt_value for members in --no-group 2024-08-28 18:07:20 -03:00
keysyms.h
libslang.h perf tui slang: Tidy casts 2023-08-25 10:24:55 -03:00
progress.c
progress.h
setup.c perf ui: Move window resize signal functions 2023-04-10 19:20:38 -03:00
ui.h perf ui: Move window resize signal functions 2023-04-10 19:20:38 -03:00
util.c
util.h