Vasiliy Kovalev 84e8719c08 hfs/hfsplus: fix slab-out-of-bounds in hfs_bnode_read_key ... commit bb5e07cb92 upstream. Syzbot reported an issue in hfs subsystem: BUG: KASAN: slab-out-of-bounds in memcpy_from_page include/linux/highmem.h:423 [inline] BUG: KASAN: slab-out-of-bounds in hfs_bnode_read fs/hfs/bnode.c:35 [inline] BUG: KASAN: slab-out-of-bounds in hfs_bnode_read_key+0x314/0x450 fs/hfs/bnode.c:70 Write of size 94 at addr ffff8880123cd100 by task syz-executor237/5102 Call Trace: <TASK> __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_address_description mm/kasan/report.c:377 [inline] print_report+0x169/0x550 mm/kasan/report.c:488 kasan_report+0x143/0x180 mm/kasan/report.c:601 kasan_check_range+0x282/0x290 mm/kasan/generic.c:189 __asan_memcpy+0x40/0x70 mm/kasan/shadow.c:106 memcpy_from_page include/linux/highmem.h:423 [inline] hfs_bnode_read fs/hfs/bnode.c:35 [inline] hfs_bnode_read_key+0x314/0x450 fs/hfs/bnode.c:70 hfs_brec_insert+0x7f3/0xbd0 fs/hfs/brec.c:159 hfs_cat_create+0x41d/0xa50 fs/hfs/catalog.c:118 hfs_mkdir+0x6c/0xe0 fs/hfs/dir.c:232 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257 do_mkdirat+0x264/0x3a0 fs/namei.c:4280 __do_sys_mkdir fs/namei.c:4300 [inline] __se_sys_mkdir fs/namei.c:4298 [inline] __x64_sys_mkdir+0x6c/0x80 fs/namei.c:4298 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fbdd6057a99 Add a check for key length in hfs_bnode_read_key to prevent out-of-bounds memory access. If the key length is invalid, the key buffer is cleared, improving stability and reliability. Fixes: 1da177e4c3 ("Linux-2.6.12-rc2") Reported-by: syzbot+5f3a973ed3dfb85a6683@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=5f3a973ed3dfb85a6683 Cc: stable@vger.kernel.org Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> Link: https://lore.kernel.org/20241019191303.24048-1-kovalev@altlinux.org Reviewed-by: Cengiz Can <cengiz.can@canonical.com> Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-04-25 10:47:52 +02:00
..
attr.c	hfs: move hfs_xattr_handlers to .rodata	2023-10-09 16:24:19 +02:00
bfind.c
bitmap.c
bnode.c	hfs/hfsplus: fix slab-out-of-bounds in hfs_bnode_read_key	2025-04-25 10:47:52 +02:00
brec.c
btree.c	hfs: replace kmap() with kmap_local_page() in btree.c	2022-09-11 21:55:09 -07:00
btree.h
catalog.c	hfs: convert to new timestamp accessors	2023-10-18 14:08:21 +02:00
dir.c	hfs: convert to ctime accessor functions	2023-07-24 10:29:59 +02:00
extent.c	fs: Convert aops->write_begin to take a folio	2024-08-07 11:33:21 +02:00
hfs_fs.h	fs: Convert aops->write_begin to take a folio	2024-08-07 11:33:21 +02:00
hfs.h
inode.c	fs: Convert aops->write_begin to take a folio	2024-08-07 11:33:21 +02:00
Kconfig	fs: add CONFIG_BUFFER_HEAD	2023-08-02 09:13:09 -06:00
Makefile
mdb.c	block: remove genhd.h	2022-02-02 07:49:59 -07:00
part_tbl.c
string.c
super.c	hfs: Sanity check the root record	2025-01-23 17:22:54 +01:00
sysdep.c	hfs: convert to new timestamp accessors	2023-10-18 14:08:21 +02:00
trans.c	hfs: Fix OOB Write in hfs_asc2mac	2022-12-11 19:30:19 -08:00