mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-08-22 00:42:01 +02:00

[ Upstream commitb548f5e945
] hci_devcd_append may lead to the release of the skb, so it cannot be accessed once it is called. ================================================================== BUG: KASAN: slab-use-after-free in btmtk_process_coredump+0x2a7/0x2d0 [btmtk] Read of size 4 at addr ffff888033cfabb0 by task kworker/0:3/82 CPU: 0 PID: 82 Comm: kworker/0:3 Tainted: G U 6.6.40-lockdep-03464-g1d8b4eb3060e #1 b0b3c1cc0c842735643fb411799d97921d1f688c Hardware name: Google Yaviks_Ufs/Yaviks_Ufs, BIOS Google_Yaviks_Ufs.15217.552.0 05/07/2024 Workqueue: events btusb_rx_work [btusb] Call Trace: <TASK> dump_stack_lvl+0xfd/0x150 print_report+0x131/0x780 kasan_report+0x177/0x1c0 btmtk_process_coredump+0x2a7/0x2d0 [btmtk 03edd567dd71a65958807c95a65db31d433e1d01] btusb_recv_acl_mtk+0x11c/0x1a0 [btusb 675430d1e87c4f24d0c1f80efe600757a0f32bec] btusb_rx_work+0x9e/0xe0 [btusb 675430d1e87c4f24d0c1f80efe600757a0f32bec] worker_thread+0xe44/0x2cc0 kthread+0x2ff/0x3a0 ret_from_fork+0x51/0x80 ret_from_fork_asm+0x1b/0x30 </TASK> Allocated by task 82: stack_trace_save+0xdc/0x190 kasan_set_track+0x4e/0x80 __kasan_slab_alloc+0x4e/0x60 kmem_cache_alloc+0x19f/0x360 skb_clone+0x132/0xf70 btusb_recv_acl_mtk+0x104/0x1a0 [btusb] btusb_rx_work+0x9e/0xe0 [btusb] worker_thread+0xe44/0x2cc0 kthread+0x2ff/0x3a0 ret_from_fork+0x51/0x80 ret_from_fork_asm+0x1b/0x30 Freed by task 1733: stack_trace_save+0xdc/0x190 kasan_set_track+0x4e/0x80 kasan_save_free_info+0x28/0xb0 ____kasan_slab_free+0xfd/0x170 kmem_cache_free+0x183/0x3f0 hci_devcd_rx+0x91a/0x2060 [bluetooth] worker_thread+0xe44/0x2cc0 kthread+0x2ff/0x3a0 ret_from_fork+0x51/0x80 ret_from_fork_asm+0x1b/0x30 The buggy address belongs to the object at ffff888033cfab40 which belongs to the cache skbuff_head_cache of size 232 The buggy address is located 112 bytes inside of freed 232-byte region [ffff888033cfab40, ffff888033cfac28) The buggy address belongs to the physical page: page:00000000a174ba93 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x33cfa head:00000000a174ba93 order:1 entire_mapcount:0 nr_pages_mapped:0 pincount:0 anon flags: 0x4000000000000840(slab|head|zone=1) page_type: 0xffffffff() raw: 4000000000000840 ffff888100848a00 0000000000000000 0000000000000001 raw: 0000000000000000 0000000080190019 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff888033cfaa80: fb fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc ffff888033cfab00: fc fc fc fc fc fc fc fc fa fb fb fb fb fb fb fb >ffff888033cfab80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888033cfac00: fb fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc ffff888033cfac80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== Check if we need to call hci_devcd_complete before calling hci_devcd_append. That requires that we check data->cd_info.cnt >= MTK_COREDUMP_NUM instead of data->cd_info.cnt > MTK_COREDUMP_NUM, as we increment data->cd_info.cnt only once the call to hci_devcd_append succeeds. Fixes:0b70151328
("Bluetooth: btusb: mediatek: add MediaTek devcoredump support") Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
431 lines
10 KiB
C
431 lines
10 KiB
C
// SPDX-License-Identifier: ISC
|
|
/* Copyright (C) 2021 MediaTek Inc.
|
|
*
|
|
*/
|
|
#include <linux/module.h>
|
|
#include <linux/firmware.h>
|
|
|
|
#include <net/bluetooth/bluetooth.h>
|
|
#include <net/bluetooth/hci_core.h>
|
|
|
|
#include "btmtk.h"
|
|
|
|
#define VERSION "0.1"
|
|
|
|
/* It is for mt79xx download rom patch*/
|
|
#define MTK_FW_ROM_PATCH_HEADER_SIZE 32
|
|
#define MTK_FW_ROM_PATCH_GD_SIZE 64
|
|
#define MTK_FW_ROM_PATCH_SEC_MAP_SIZE 64
|
|
#define MTK_SEC_MAP_COMMON_SIZE 12
|
|
#define MTK_SEC_MAP_NEED_SEND_SIZE 52
|
|
|
|
struct btmtk_patch_header {
|
|
u8 datetime[16];
|
|
u8 platform[4];
|
|
__le16 hwver;
|
|
__le16 swver;
|
|
__le32 magicnum;
|
|
} __packed;
|
|
|
|
struct btmtk_global_desc {
|
|
__le32 patch_ver;
|
|
__le32 sub_sys;
|
|
__le32 feature_opt;
|
|
__le32 section_num;
|
|
} __packed;
|
|
|
|
struct btmtk_section_map {
|
|
__le32 sectype;
|
|
__le32 secoffset;
|
|
__le32 secsize;
|
|
union {
|
|
__le32 u4SecSpec[13];
|
|
struct {
|
|
__le32 dlAddr;
|
|
__le32 dlsize;
|
|
__le32 seckeyidx;
|
|
__le32 alignlen;
|
|
__le32 sectype;
|
|
__le32 dlmodecrctype;
|
|
__le32 crc;
|
|
__le32 reserved[6];
|
|
} bin_info_spec;
|
|
};
|
|
} __packed;
|
|
|
|
static void btmtk_coredump(struct hci_dev *hdev)
|
|
{
|
|
int err;
|
|
|
|
err = __hci_cmd_send(hdev, 0xfd5b, 0, NULL);
|
|
if (err < 0)
|
|
bt_dev_err(hdev, "Coredump failed (%d)", err);
|
|
}
|
|
|
|
static void btmtk_coredump_hdr(struct hci_dev *hdev, struct sk_buff *skb)
|
|
{
|
|
struct btmediatek_data *data = hci_get_priv(hdev);
|
|
char buf[80];
|
|
|
|
snprintf(buf, sizeof(buf), "Controller Name: 0x%X\n",
|
|
data->dev_id);
|
|
skb_put_data(skb, buf, strlen(buf));
|
|
|
|
snprintf(buf, sizeof(buf), "Firmware Version: 0x%X\n",
|
|
data->cd_info.fw_version);
|
|
skb_put_data(skb, buf, strlen(buf));
|
|
|
|
snprintf(buf, sizeof(buf), "Driver: %s\n",
|
|
data->cd_info.driver_name);
|
|
skb_put_data(skb, buf, strlen(buf));
|
|
|
|
snprintf(buf, sizeof(buf), "Vendor: MediaTek\n");
|
|
skb_put_data(skb, buf, strlen(buf));
|
|
}
|
|
|
|
static void btmtk_coredump_notify(struct hci_dev *hdev, int state)
|
|
{
|
|
struct btmediatek_data *data = hci_get_priv(hdev);
|
|
|
|
switch (state) {
|
|
case HCI_DEVCOREDUMP_IDLE:
|
|
data->cd_info.state = HCI_DEVCOREDUMP_IDLE;
|
|
break;
|
|
case HCI_DEVCOREDUMP_ACTIVE:
|
|
data->cd_info.state = HCI_DEVCOREDUMP_ACTIVE;
|
|
break;
|
|
case HCI_DEVCOREDUMP_TIMEOUT:
|
|
case HCI_DEVCOREDUMP_ABORT:
|
|
case HCI_DEVCOREDUMP_DONE:
|
|
data->cd_info.state = HCI_DEVCOREDUMP_IDLE;
|
|
btmtk_reset_sync(hdev);
|
|
break;
|
|
}
|
|
}
|
|
|
|
int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync)
|
|
{
|
|
struct btmtk_hci_wmt_params wmt_params;
|
|
struct btmtk_patch_header *hdr;
|
|
struct btmtk_global_desc *globaldesc = NULL;
|
|
struct btmtk_section_map *sectionmap;
|
|
const struct firmware *fw;
|
|
const u8 *fw_ptr;
|
|
const u8 *fw_bin_ptr;
|
|
int err, dlen, i, status;
|
|
u8 flag, first_block, retry;
|
|
u32 section_num, dl_size, section_offset;
|
|
u8 cmd[64];
|
|
|
|
err = request_firmware(&fw, fwname, &hdev->dev);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to load firmware file (%d)", err);
|
|
return err;
|
|
}
|
|
|
|
fw_ptr = fw->data;
|
|
fw_bin_ptr = fw_ptr;
|
|
hdr = (struct btmtk_patch_header *)fw_ptr;
|
|
globaldesc = (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE);
|
|
section_num = le32_to_cpu(globaldesc->section_num);
|
|
|
|
bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s",
|
|
le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr->datetime);
|
|
|
|
for (i = 0; i < section_num; i++) {
|
|
first_block = 1;
|
|
fw_ptr = fw_bin_ptr;
|
|
sectionmap = (struct btmtk_section_map *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE +
|
|
MTK_FW_ROM_PATCH_GD_SIZE + MTK_FW_ROM_PATCH_SEC_MAP_SIZE * i);
|
|
|
|
section_offset = le32_to_cpu(sectionmap->secoffset);
|
|
dl_size = le32_to_cpu(sectionmap->bin_info_spec.dlsize);
|
|
|
|
if (dl_size > 0) {
|
|
retry = 20;
|
|
while (retry > 0) {
|
|
cmd[0] = 0; /* 0 means legacy dl mode. */
|
|
memcpy(cmd + 1,
|
|
fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE +
|
|
MTK_FW_ROM_PATCH_GD_SIZE +
|
|
MTK_FW_ROM_PATCH_SEC_MAP_SIZE * i +
|
|
MTK_SEC_MAP_COMMON_SIZE,
|
|
MTK_SEC_MAP_NEED_SEND_SIZE + 1);
|
|
|
|
wmt_params.op = BTMTK_WMT_PATCH_DWNLD;
|
|
wmt_params.status = &status;
|
|
wmt_params.flag = 0;
|
|
wmt_params.dlen = MTK_SEC_MAP_NEED_SEND_SIZE + 1;
|
|
wmt_params.data = &cmd;
|
|
|
|
err = wmt_cmd_sync(hdev, &wmt_params);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to send wmt patch dwnld (%d)",
|
|
err);
|
|
goto err_release_fw;
|
|
}
|
|
|
|
if (status == BTMTK_WMT_PATCH_UNDONE) {
|
|
break;
|
|
} else if (status == BTMTK_WMT_PATCH_PROGRESS) {
|
|
msleep(100);
|
|
retry--;
|
|
} else if (status == BTMTK_WMT_PATCH_DONE) {
|
|
goto next_section;
|
|
} else {
|
|
bt_dev_err(hdev, "Failed wmt patch dwnld status (%d)",
|
|
status);
|
|
err = -EIO;
|
|
goto err_release_fw;
|
|
}
|
|
}
|
|
|
|
fw_ptr += section_offset;
|
|
wmt_params.op = BTMTK_WMT_PATCH_DWNLD;
|
|
wmt_params.status = NULL;
|
|
|
|
while (dl_size > 0) {
|
|
dlen = min_t(int, 250, dl_size);
|
|
if (first_block == 1) {
|
|
flag = 1;
|
|
first_block = 0;
|
|
} else if (dl_size - dlen <= 0) {
|
|
flag = 3;
|
|
} else {
|
|
flag = 2;
|
|
}
|
|
|
|
wmt_params.flag = flag;
|
|
wmt_params.dlen = dlen;
|
|
wmt_params.data = fw_ptr;
|
|
|
|
err = wmt_cmd_sync(hdev, &wmt_params);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to send wmt patch dwnld (%d)",
|
|
err);
|
|
goto err_release_fw;
|
|
}
|
|
|
|
dl_size -= dlen;
|
|
fw_ptr += dlen;
|
|
}
|
|
}
|
|
next_section:
|
|
continue;
|
|
}
|
|
/* Wait a few moments for firmware activation done */
|
|
usleep_range(100000, 120000);
|
|
|
|
err_release_fw:
|
|
release_firmware(fw);
|
|
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_setup_firmware_79xx);
|
|
|
|
int btmtk_setup_firmware(struct hci_dev *hdev, const char *fwname,
|
|
wmt_cmd_sync_func_t wmt_cmd_sync)
|
|
{
|
|
struct btmtk_hci_wmt_params wmt_params;
|
|
const struct firmware *fw;
|
|
const u8 *fw_ptr;
|
|
size_t fw_size;
|
|
int err, dlen;
|
|
u8 flag, param;
|
|
|
|
err = request_firmware(&fw, fwname, &hdev->dev);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to load firmware file (%d)", err);
|
|
return err;
|
|
}
|
|
|
|
/* Power on data RAM the firmware relies on. */
|
|
param = 1;
|
|
wmt_params.op = BTMTK_WMT_FUNC_CTRL;
|
|
wmt_params.flag = 3;
|
|
wmt_params.dlen = sizeof(param);
|
|
wmt_params.data = ¶m;
|
|
wmt_params.status = NULL;
|
|
|
|
err = wmt_cmd_sync(hdev, &wmt_params);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
|
|
goto err_release_fw;
|
|
}
|
|
|
|
fw_ptr = fw->data;
|
|
fw_size = fw->size;
|
|
|
|
/* The size of patch header is 30 bytes, should be skip */
|
|
if (fw_size < 30) {
|
|
err = -EINVAL;
|
|
goto err_release_fw;
|
|
}
|
|
|
|
fw_size -= 30;
|
|
fw_ptr += 30;
|
|
flag = 1;
|
|
|
|
wmt_params.op = BTMTK_WMT_PATCH_DWNLD;
|
|
wmt_params.status = NULL;
|
|
|
|
while (fw_size > 0) {
|
|
dlen = min_t(int, 250, fw_size);
|
|
|
|
/* Tell device the position in sequence */
|
|
if (fw_size - dlen <= 0)
|
|
flag = 3;
|
|
else if (fw_size < fw->size - 30)
|
|
flag = 2;
|
|
|
|
wmt_params.flag = flag;
|
|
wmt_params.dlen = dlen;
|
|
wmt_params.data = fw_ptr;
|
|
|
|
err = wmt_cmd_sync(hdev, &wmt_params);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to send wmt patch dwnld (%d)",
|
|
err);
|
|
goto err_release_fw;
|
|
}
|
|
|
|
fw_size -= dlen;
|
|
fw_ptr += dlen;
|
|
}
|
|
|
|
wmt_params.op = BTMTK_WMT_RST;
|
|
wmt_params.flag = 4;
|
|
wmt_params.dlen = 0;
|
|
wmt_params.data = NULL;
|
|
wmt_params.status = NULL;
|
|
|
|
/* Activate funciton the firmware providing to */
|
|
err = wmt_cmd_sync(hdev, &wmt_params);
|
|
if (err < 0) {
|
|
bt_dev_err(hdev, "Failed to send wmt rst (%d)", err);
|
|
goto err_release_fw;
|
|
}
|
|
|
|
/* Wait a few moments for firmware activation done */
|
|
usleep_range(10000, 12000);
|
|
|
|
err_release_fw:
|
|
release_firmware(fw);
|
|
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_setup_firmware);
|
|
|
|
int btmtk_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
|
|
{
|
|
struct sk_buff *skb;
|
|
long ret;
|
|
|
|
skb = __hci_cmd_sync(hdev, 0xfc1a, 6, bdaddr, HCI_INIT_TIMEOUT);
|
|
if (IS_ERR(skb)) {
|
|
ret = PTR_ERR(skb);
|
|
bt_dev_err(hdev, "changing Mediatek device address failed (%ld)",
|
|
ret);
|
|
return ret;
|
|
}
|
|
kfree_skb(skb);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_set_bdaddr);
|
|
|
|
void btmtk_reset_sync(struct hci_dev *hdev)
|
|
{
|
|
struct btmediatek_data *reset_work = hci_get_priv(hdev);
|
|
int err;
|
|
|
|
hci_dev_lock(hdev);
|
|
|
|
err = hci_cmd_sync_queue(hdev, reset_work->reset_sync, NULL, NULL);
|
|
if (err)
|
|
bt_dev_err(hdev, "failed to reset (%d)", err);
|
|
|
|
hci_dev_unlock(hdev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_reset_sync);
|
|
|
|
int btmtk_register_coredump(struct hci_dev *hdev, const char *name,
|
|
u32 fw_version)
|
|
{
|
|
struct btmediatek_data *data = hci_get_priv(hdev);
|
|
|
|
if (!IS_ENABLED(CONFIG_DEV_COREDUMP))
|
|
return -EOPNOTSUPP;
|
|
|
|
data->cd_info.fw_version = fw_version;
|
|
data->cd_info.state = HCI_DEVCOREDUMP_IDLE;
|
|
data->cd_info.driver_name = name;
|
|
|
|
return hci_devcd_register(hdev, btmtk_coredump, btmtk_coredump_hdr,
|
|
btmtk_coredump_notify);
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_register_coredump);
|
|
|
|
int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb)
|
|
{
|
|
struct btmediatek_data *data = hci_get_priv(hdev);
|
|
int err;
|
|
bool complete = false;
|
|
|
|
if (!IS_ENABLED(CONFIG_DEV_COREDUMP)) {
|
|
kfree_skb(skb);
|
|
return 0;
|
|
}
|
|
|
|
switch (data->cd_info.state) {
|
|
case HCI_DEVCOREDUMP_IDLE:
|
|
err = hci_devcd_init(hdev, MTK_COREDUMP_SIZE);
|
|
if (err < 0) {
|
|
kfree_skb(skb);
|
|
break;
|
|
}
|
|
data->cd_info.cnt = 0;
|
|
|
|
/* It is supposed coredump can be done within 5 seconds */
|
|
schedule_delayed_work(&hdev->dump.dump_timeout,
|
|
msecs_to_jiffies(5000));
|
|
fallthrough;
|
|
case HCI_DEVCOREDUMP_ACTIVE:
|
|
default:
|
|
/* Mediatek coredump data would be more than MTK_COREDUMP_NUM */
|
|
if (data->cd_info.cnt >= MTK_COREDUMP_NUM &&
|
|
skb->len > MTK_COREDUMP_END_LEN)
|
|
if (!memcmp((char *)&skb->data[skb->len - MTK_COREDUMP_END_LEN],
|
|
MTK_COREDUMP_END, MTK_COREDUMP_END_LEN - 1))
|
|
complete = true;
|
|
|
|
err = hci_devcd_append(hdev, skb);
|
|
if (err < 0)
|
|
break;
|
|
data->cd_info.cnt++;
|
|
|
|
if (complete) {
|
|
bt_dev_info(hdev, "Mediatek coredump end");
|
|
hci_devcd_complete(hdev);
|
|
}
|
|
|
|
break;
|
|
}
|
|
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_GPL(btmtk_process_coredump);
|
|
|
|
MODULE_AUTHOR("Sean Wang <sean.wang@mediatek.com>");
|
|
MODULE_AUTHOR("Mark Chen <mark-yw.chen@mediatek.com>");
|
|
MODULE_DESCRIPTION("Bluetooth support for MediaTek devices ver " VERSION);
|
|
MODULE_VERSION(VERSION);
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_FIRMWARE(FIRMWARE_MT7622);
|
|
MODULE_FIRMWARE(FIRMWARE_MT7663);
|
|
MODULE_FIRMWARE(FIRMWARE_MT7668);
|
|
MODULE_FIRMWARE(FIRMWARE_MT7922);
|
|
MODULE_FIRMWARE(FIRMWARE_MT7961);
|
|
MODULE_FIRMWARE(FIRMWARE_MT7925);
|