linux-yocto/drivers/s390
Fedor Pchelkin 88f3869649 s390/pkey: Prevent overflow in size calculation for memdup_user()
commit 7360ee4759 upstream.

Number of apqn target list entries contained in 'nr_apqns' variable is
determined by userspace via an ioctl call so the result of the product in
calculation of size passed to memdup_user() may overflow.

In this case the actual size of the allocated area and the value
describing it won't be in sync leading to various types of unpredictable
behaviour later.

Use a proper memdup_array_user() helper which returns an error if an
overflow is detected. Note that it is different from when nr_apqns is
initially zero - that case is considered valid and should be handled in
subsequent pkey_handler implementations.

Found by Linux Verification Center (linuxtesting.org).

Fixes: f2bbc96e7c ("s390/pkey: add CCA AES cipher key support")
Cc: stable@vger.kernel.org
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: Holger Dengler <dengler@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20250611192011.206057-1-pchelkin@ispras.ru
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-07-06 11:00:11 +02:00
..
block Revert "s390/dasd: Establish DMA alignment" 2024-08-29 17:33:59 +02:00
char s390/tty: Fix a potential memory leak bug 2025-05-02 07:50:53 +02:00
cio s390/cio: Fix CHPID "configure" attribute caching 2025-03-22 12:50:42 -07:00
crypto s390/pkey: Prevent overflow in size calculation for memdup_user() 2025-07-06 11:00:11 +02:00
net s390/ism: add release function for struct device 2025-02-27 04:10:48 -08:00
scsi scsi: s390: zfcp: Ensure synchronous unit_add 2025-06-27 11:08:59 +01:00
virtio s390/airq: remove lsi_mask from airq_struct 2023-08-30 11:03:28 +02:00
Makefile