linux-yocto/net/nfc
Krzysztof Kozlowski a8acc7080a NFC: nci: uart: Set tty->disc_data only in success path
commit fc27ab4890 upstream.

Setting tty->disc_data before opening the NCI device means we need to
clean it up on error paths.  This also opens some short window if device
starts sending data, even before NCIUARTSETDRIVER IOCTL succeeded
(broken hardware?).  Close the window by exposing tty->disc_data only on
the success path, when opening of the NCI device and try_module_get()
succeeds.

The code differs in error path in one aspect: tty->disc_data won't be
ever assigned thus NULL-ified.  This however should not be relevant
difference, because of "tty->disc_data=NULL" in nci_uart_tty_open().

Cc: Linus Torvalds <torvalds@linuxfoundation.org>
Fixes: 9961127d4b ("NFC: nci: add generic uart support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20250618073649.25049-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-06-27 11:08:48 +01:00
..
hci
nci NFC: nci: uart: Set tty->disc_data only in success path 2025-06-27 11:08:48 +01:00
af_nfc.c
core.c
digital_core.c
digital_dep.c
digital_technology.c
digital.h
Kconfig
llcp_commands.c
llcp_core.c nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local 2024-01-10 17:16:48 +01:00
llcp_sock.c nfc: llcp: fix nfc_llcp_setsockopt() unsafe copies 2024-08-19 06:04:28 +02:00
llcp.h
Makefile
netlink.c genetlink: use attrs from struct genl_info 2023-08-15 15:00:45 -07:00
nfc.h
rawsock.c