MIRRORS/meta-openembedded
1
0
Fork 0
mirror of https://github.com/openembedded/meta-openembedded.git synced 2025-12-13 22:05:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

libmtp: enable stack memory protection

Browse Source 
Add 0002-util-mtp-hotplug.c-Enable-stack-memory-protection.patch:
Use "return 0" instead of "exit(0)" to let the program exit normally
by returning from the main function. This allows the compiler to
perform necessary cleanup operations, including stack canary checks.

Signed-off-by: Hieu Van Nguyen <hieu2.nguyen@lge.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This commit is contained in:
Hieu Van Nguyen 2024-10-30 10:51:53 +00:00 committed by Khem Raj
parent cedfa1be3a
commit 0e2ed14c7a
No known key found for this signature in database
GPG Key ID: BB053355919D3314
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
meta-oe/recipes-connectivity/libmtp/libmtp/0002-util-mtp-hotplug.c-Enable-stack-memory-protection.patch Normal file
View File

@ -0,0 +1,33 @@
From 0644188a537a06bc6d04483b21e23b80987eb497 Mon Sep 17 00:00:00 2001
From: Hieu Van Nguyen <hieu2.nguyen@lge.com>
Date: Fri, 11 Oct 2024 04:21:21 +0000
Subject: [PATCH] util/mtp-hotplug.c: Enable stack memory protection
Use "return 0" instead of "exit(0)" at the end of main()
function to enable checking for Stack Overflow at Runtime.
Use "return 0" to let the program exit normally by returning from
the main function. This allows the compiler to perform necessary
cleanup operations, including stack canary checks.
__stack_chk_fail function isn't being invoked when using exit(0) at
the end of the main function
$ objdump -T ./util/.libs/mtp-hotplug | grep __stack_chk_fail
This return empty.
---
Upstream-Status: Backport [https://github.com/libmtp/libmtp/commit/e89dbb6ecf244936acc9a52aa4af9635bda5926a]
util/mtp-hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/mtp-hotplug.c b/util/mtp-hotplug.c
index b5bc6da40f..db75cb38a1 100644
--- a/util/mtp-hotplug.c
+++ b/util/mtp-hotplug.c
@@ -301,5 +301,5 @@ int main (int argc, char **argv)
printf("\n");
}
- exit (0);
+ return 0;
}

3
meta-oe/recipes-connectivity/libmtp/libmtp_1.1.21.bb
View File

@ -18,7 +18,8 @@ DEPENDS = "libusb1 gettext-native"
DEPENDS:append:class-target = " ${BPN}-native"
SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BP}.tar.gz"
SRC_URI:append:class-target = " file://0001-Use-native-mtp-hotplug.patch"
SRC_URI:append:class-target = " file://0001-Use-native-mtp-hotplug.patch \
file://0002-util-mtp-hotplug.c-Enable-stack-memory-protection.patch"
SRC_URI[sha256sum] = "f4c1ceb3df020a6cb851110f620c14fe399518c494ed252039cbfb4e34335135"
UPSTREAM_CHECK_URI = "https://github.com/libmtp/libmtp/releases"