Commit Graph

27 Commits

Author SHA1 Message Date
Khem Raj
26af1e5673 quagga: Fix AC_CHECK_LIB for libreadline
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-09-01 13:09:22 -07:00
Yi Zhao
9e20a2f41a quagga: do not set PIDFile in service files
The systemd can not open the pid file because it is locked by quagga
daemon.

Fixes:
$ systemctl status ospf6d.service
Feb 25 05:53:26 intel-x86-64 systemd[1]: Starting OSPF routing daemon for IPv6...
Feb 25 05:53:26 intel-x86-64 systemd[1]: ospf6d.service: Can't open PID file /run/quagga/ospf6d.pid (yet?) after start: Operation not permitted
Feb 25 05:53:26 intel-x86-64 systemd[1]: Started OSPF routing daemon for IPv6.

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-03-11 00:12:55 -08:00
Trevor Gamblin
db9dbfdc78 quagga: fix PIDFile path for service files
Multiple quagga service files are causing the following type of message to
appear during boot:

/lib/systemd/system/zebra.service:10: PIDFile= references a path below legacy
directory /var/run/, updating /var/run/quagga/zebra.pid → /run/quagga/zebra.pid;
please update the unit file accordingly.

Update the service files included as part of the recipe to use /run instead of
/var/run as the PIDFile path.

Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-17 08:33:53 -07:00
Yi Zhao
807be0aeed quagga: update to 1.1.0
* remove the following 3 patches which already fixed in upstream:
  0001-ospf6d-check-ospf6-before-using-it-in-ospf6_clean.patch
  quagga-Avoid-duplicate-connected-address.patch
  ripd-fix-two-bugs-after-received-SIGHUP.patch

* inherit pkgconfig to fix configure errors:
  | configure.ac:97: error: possibly undefined macro: AC_MSG_RESULT
  |   If this token and others are legitimate, please use m4_pattern_allow.
  |   See the Autoconf documentation.

* add user quagga to quaggavty supplementary group to fix startup error:
  Starting Quagga daemons: zebra
  privs_init: user(quagga) is not part of vty group specified(quaggavty)

* remove babeld related code from initscript becasue it had been removed
  from quagga

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-01-19 09:26:15 +01:00
Kai Kang
fcdd7e2c6f quagga: 0.99.24.1 -> 1.0.20160315
Upgrade quagga from 0.99.24.1 to 1.0.20160315.

* babeld was removed from quagga, so remove babeld related code, service
  file and patch and from recipe
* remove Zebra-sync-zebra-routing-table-with-the-kernel-one.patch which
  is obsoleted that quagga update the logic, see
  0abf6796c3
* remove configure options '--enable-ospf-te' and '--enable-opaque-lsa'
  which are set by default and removed from configure.ac already

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-08-16 21:26:11 -04:00
Qi.Chen@windriver.com
8310289187 quagga: fix segment fault when stopping ospf6d
In ospf6_clean, the variable ospf6 might be NULL causing segment fault
when stopping ospf6d. Check the variable before referencing it.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04 22:29:53 -05:00
Li xin
f195ff612b quagga: bug fix
The bug is: after the service stopped,the pid file still exists.
So modidy the service files.

Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-06 15:27:51 -04:00
Kang Kai
de8c3babcf quagga: fix typo in systemd service file
Fix typo in systemd service file ripngd.service.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-02-11 21:25:40 -05:00
Chong.Lu@windriver.com
07e13c6b94 quagga: add systemd service file
Add systemd service for quagga.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-10-04 00:30:29 +02:00
Roy Li
8a428b570d quagga: uprev it to 0.99.23
uprev it to 0.99.23
remove patches which have been in the latest version

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-08-13 23:28:06 +02:00
Yue Tao
71bb2dc7c3 quagga: Security Advisory - quagga - CVE-2013-2236
Stack-based buffer overflow in the new_msg_lsa_change_notify function in
the OSPFD API (ospf_api.c) in Quagga before 0.99.22.2, when
--enable-opaque-lsa and the -a command line option are used, allows
remote attackers to cause a denial of service (crash) via a large LSA.

http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2013-2236

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-08-05 16:23:58 -04:00
Robert Yang
c587fa5546 meta-networking: fix no newline at end of file
Add a '\n' to the last line of the file to fix:

No newline at end of file

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-07-15 14:57:27 +02:00
Yue Tao
26b31ad728 quagga: Security Advisory - CVE-2012-1820
The bgp_capability_orf function in bgpd in Quagga 0.99.20.1 and earlier
allows remote attackers to cause a denial of service (assertion failure
and daemon exit) by leveraging a BGP peering relationship and sending a
malformed Outbound Route Filtering (ORF) capability TLV in an OPEN
message.

http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-1820

Signed-off-by: Yue Tao <Yue.Tao@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2014-06-15 23:21:56 -04:00
Kai Kang
715893e5ff quagga: fix CVE-2013-6051
Backport patch to fix CVE-2013-6051.

Signed-off-by: Hu <yadi.hu@windriver.com>
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-04-24 21:07:46 -04:00
Robert Yang
c1d420a3b6 quagga: work with new readline
The Function and CPPFunction had been removed by in readline 6.3, use
the new functions to replace them.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2014-03-27 15:41:12 -04:00
Roy Li
7a673eb37e quagga: close the stdout/stderr as in other daemons
Once babald becomes a background daemon, it should not output information to
stdout, so need to close stdout.

In fact, other daemons close their stdout when they run into background, like
ospfd, isisd and bgpd, by calling daemon() which is in lib/daemon.c

Closing the stdout can fix a tee hang issue { #/usr/sbin/babeld -d |tee tmp }

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-02-23 23:17:29 +01:00
Roy Li
7cb2f9e4c2 quagga: fix a typOS
it should be CPP, not cpp; this typOS makes vtysh unable to work.

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2014-02-12 20:09:26 -05:00
Roy Li
75c52163b0 quagga: Backport a patch to fix extract.pl for cross compilation
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-27 15:20:06 -05:00
Hongxu Jia
ec152778cd quagga: add pam support for vtysh
According to DISTRO_FEATURES to add pam support for quagga, and import
configure file from Fedora.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 11:14:31 -05:00
Bopeng Liu
98367f46aa quagga: Fix watchquagga initscript problem.
Change the default config file for making watchquagga can startup successful

Signed-off-by: Bopeng Liu <Bopeng.Liu@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 11:01:47 -05:00
Xufeng Zhang
936febdff7 quagga: Avoid duplicate connected address adding to the list
commit 27ba970b9("quagga/ripd: Fix two bugs after received SIGHUP signal")
introduces an regression: ifp->connected list is cleaned up when ripd is
restarting, however, for interface addresses which are not specified in
ripd configuration file, they are never to be added into ifp->connected
again, this will lead to some abnormal behavior for route advertising.

Instead of cleaning up the ifp->connected list to avoid duplicated
connected address being added into this list, we can check this
condition during interface address adding process and return early
when an identical address has already been added.

Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-26 10:53:17 -05:00
Roy Li
e854d0d71e quagga: backport a patch from 0.99.22 to fix "no ip address" command
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-11-06 15:10:58 -05:00
Xufeng Zhang
27ba970b9e quagga/ripd: Fix two bugs after received SIGHUP signal
There are two problems for ripd implementation after received
SIGHUP signal:
1). ripd didn't clean up ifp->connected list before reload
    configuration file which makes the same advertise packet
    being sent multiple times(depends on how many SIGHUP was recieved).
2). ripd reset ri->split_horizon flag to RIP_NO_SPLIT_HORIZON
    during restart which is different from the flag when ripd is
    firstly started up, leading to unnecessary route to be advertised.

[YOCTO #5266]

Signed-off-by: Xufeng Zhang <xufeng.zhang@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-10-31 10:05:00 -04:00
Chen Qi
08c4c25787 quagga: fix babeld_option
Fix babeld_option to make babeld start correctly.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-09-23 09:56:56 -04:00
Joe MacDonald
5c3e27684c quagga: backport documentation patch
The latest stable quagga adopted this patch:

   http://git.savannah.gnu.org/gitweb/?p=quagga.git;a=commit;h=b58c90807c9d0bfa9601704c7490a16070906004

to repair a documentation build error.  Trivial backport.

Signed-off-by: Joe MacDonald <joe@deserted.net>
2013-08-12 09:00:00 -04:00
Aws Ismail
af74e53e97 Quagga: sync zebra routing table with the kernel one
When interface goes down, and there are some static routes that are
made with ip route, they are going to be deleted from kernel fib.
That's what kernel does by default. But they are not going to be
deleted from zebra's fib. They will be declared inactive.

This issue was originally discussed in [1] and a patch was proposed.

[1] http://www.gossamer-threads.com/lists/quagga/dev/22609

Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
2013-05-07 10:23:41 -04:00
Paul Eggleton
e762ce3fc0 quagga: add from OE-Classic, update and tidy-up
* Update to 0.99.21
* Fix SRC_URI to point to a working download location
* Make LICENSE more accurate
* Add LIC_FILES_CHKSUM
* Add old gentoo patch to fix libcap linking errors
* Put binaries in sbindir
* Use useradd.bbclass to create user/groups
* Handle hardcoded paths in initscript
* Add LSB headers to initscript (borrowed from debian)
* Tidy up packaging and directory references
* Add SUMMARY

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
2012-11-27 14:43:58 -05:00