mirror of
git://git.yoctoproject.org/meta-raspberrypi.git
synced 2025-07-19 12:59:03 +02:00
195c7d59bc
There is new patch-status QA check in oe-core: https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a This is temporary work around just to hide _many_ warnings from optional patch-status (if you add it to WARN_QA). This just added Upstream-Status: Pending everywhere without actually investigating what's the proper status. This is just to hide current QA warnings and to catch new .patch files being added without Upstream-Status, but the number of Pending patches is now terrible: Patches in Pending state: 41 (57%) With recent change to enable patch-status not only for all .patch files in oe-core, but for all recipes from oe-core: https://git.openembedded.org/openembedded-core/commit/?id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 this causes bluez5 do_patch failures as reported in: https://lists.openembedded.org/g/openembedded-core/message/183177 Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
52 lines
1.8 KiB
Diff
52 lines
1.8 KiB
Diff
From: Mauro Salvini <m.salvini@koansoftware.com>
|
|
To: u-boot@lists.denx.de
|
|
Subject: [PATCH] rpi: always set fdt_addr with firmware-provided FDT address
|
|
Date: Wed, 12 May 2021 14:39:45 +0200 [thread overview]
|
|
Message-ID: <20210512123945.25649-1-m.salvini@koansoftware.com> (raw)
|
|
|
|
Raspberry firmware prepares the FDT blob in memory at an address
|
|
that depends on both the memory size and the blob size [1].
|
|
After commit ade243a211d6 ("rpi: passthrough of the firmware provided FDT
|
|
blob") this FDT is passed to kernel through fdt_addr environment variable,
|
|
handled in set_fdt_addr() function in board file.
|
|
|
|
When u-boot environment is persistently saved, if a change happens
|
|
in loaded FDT (e.g. for a new overlay applied), firmware produces a FDT
|
|
address different from the saved one, but u-boot still use the saved
|
|
one because set_fdt_addr() function does not overwrite the fdt_addr
|
|
variable. So, for example, if there is a script that uses fdt commands for
|
|
e.g. manipulate the bootargs, boot hangs with error
|
|
|
|
libfdt fdt_check_header(): FDT_ERR_BADMAGIC
|
|
|
|
Removing the fdt_addr variable in saved environment allows to boot.
|
|
|
|
With this patch set_fdt_addr() function always overwrite fdt_addr value.
|
|
|
|
[1] https://www.raspberrypi.org/forums//viewtopic.php?f=107&t=134018
|
|
|
|
Signed-off-by: Mauro Salvini <m.salvini@koansoftware.com>
|
|
Cc: C?dric Schieli <cschieli@gmail.com>
|
|
Cc: Matthias Brugger <mbrugger@suse.com>
|
|
---
|
|
Upstream-Status: Pending
|
|
|
|
board/raspberrypi/rpi/rpi.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
|
|
index df52a4689f..611013471e 100644
|
|
--- a/board/raspberrypi/rpi/rpi.c
|
|
+++ b/board/raspberrypi/rpi/rpi.c
|
|
@@ -318,9 +318,6 @@ static void set_fdtfile(void)
|
|
*/
|
|
static void set_fdt_addr(void)
|
|
{
|
|
- if (env_get("fdt_addr"))
|
|
- return;
|
|
-
|
|
if (fdt_magic(fw_dtb_pointer) != FDT_MAGIC)
|
|
return;
|
|
|
|
--
|
|
2.17.1
|