From 36b07ec60c94eeeaa4866cc876bd6f7f8fd823e0 Mon Sep 17 00:00:00 2001 From: Quentin Schulz Date: Mon, 16 Oct 2023 13:21:10 +0200 Subject: [PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all The goal of the default COMPATIBLE_MACHINE was to not allow rockchip-rkbin to be even parsed if a MACHINE isn't part of the COMPATIBLE_MACHINE. However, COMPATIBLE_MACHINE is a regexp checked using Python's re module approximately like: """ if re.match(COMPATIBLE_MACHINE, MACHINE): return True """ and re.match() returns a match whatever MACHINE is if COMPATIBLE_MACHINE is the empty string. Therefore, let's change it to `^$` which only matches the empty string, which shouldn't be possible for anything in MACHINEOVERRIDES, and if it is there are probably bigger problems than parsing rockchip-rkbin. Fixes: f8af59dd7cd7 ("rock-5b: add") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- recipes-bsp/rkbin/rockchip-rkbin_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb index 7fefb01..f9e680d 100644 --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb @@ -12,7 +12,7 @@ inherit bin_package deploy S = "${WORKDIR}/git" -COMPATIBLE_MACHINE = "" +COMPATIBLE_MACHINE = "^$" COMPATIBLE_MACHINE:rk3588s = "rk3588s" PACKAGE_ARCH = "${MACHINE_ARCH}"