From 8f15c45f7d9cf5d6b25ab7c5865496e4ce3eb6d0 Mon Sep 17 00:00:00 2001 From: Chen Qi Date: Mon, 21 Jul 2025 17:26:08 +0800 Subject: [PATCH] skopeo: avoid overriding GOBUILDFLAGS set in go.bbclass When MACHINE is riscv64, skopeo fails to build with the following error message: ERROR: QA Issue: skopeo: ELF binary /usr/sbin/skopeo has relocations in .text [textrel] To reproduce the issue, run the following command: MACHINE=qemuriscv64 bitbake skopeo In go.bbclass, we have: """ export GOBUILDFLAGS ?= "-v ${GO_LDFLAGS} -trimpath" ... python() { if 'mips' in d.getVar('TARGET_ARCH') or 'riscv32' in d.getVar('TARGET_ARCH'): d.appendVar('INSANE_SKIP:%s' % d.getVar('PN'), " textrel") else: d.appendVar('GOBUILDFLAGS', ' -buildmode=pie') } """ The '-v -trimpath' and arch depedent '-buildmode=pie' is generally reasonable. And we can see we'll need to use anonymous python function to handle PIE. So we should avoid overriding it unless necessary. Signed-off-by: Chen Qi Signed-off-by: Bruce Ashfield --- recipes-containers/skopeo/skopeo_git.bb | 1 - 1 file changed, 1 deletion(-) diff --git a/recipes-containers/skopeo/skopeo_git.bb b/recipes-containers/skopeo/skopeo_git.bb index c5518cdc..32938108 100644 --- a/recipes-containers/skopeo/skopeo_git.bb +++ b/recipes-containers/skopeo/skopeo_git.bb @@ -60,7 +60,6 @@ do_compile() { export CGO_LDFLAGS="${TARGET_LDFLAGS}" export GO111MODULE=off - export GOBUILDFLAGS="-trimpath" export EXTRA_LDFLAGS="-s -w" oe_runmake bin/skopeo