From 22f513741db0ff258fe3ec02f5edbc8809aa0d26 Mon Sep 17 00:00:00 2001 From: Moritz Haase Date: Mon, 23 Jun 2025 11:56:01 +0200 Subject: [PATCH] json-c: Don't build unneeded apps to unblock builds with CMake 4+ Disable build of the apps, as we don't seem to package them (upstream says they aren't ready, see [0]). They are the only part of the code that doesn't build yet with CMake 4+. One alternative would be to apply [1], but the PR hasn't been merged yet by upstream, so we keep it simple. [0]: https://github.com/json-c/json-c/blob/7cee5237dc6c0831e3f9dc490394eaea44636861/apps/CMakeLists.txt#L119-L121 [1]: https://github.com/json-c/json-c/pull/888 (From OE-Core rev: cb5234acdab200bd43b89416d8d7e9df91af58cc) Signed-off-by: Moritz Haase Signed-off-by: Richard Purdie --- meta/recipes-devtools/json-c/json-c_0.18.bb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/meta/recipes-devtools/json-c/json-c_0.18.bb b/meta/recipes-devtools/json-c/json-c_0.18.bb index 2fd1897ba8..ece320d66c 100644 --- a/meta/recipes-devtools/json-c/json-c_0.18.bb +++ b/meta/recipes-devtools/json-c/json-c_0.18.bb @@ -19,8 +19,11 @@ UPSTREAM_CHECK_REGEX = "json-c-(?P\d+(\.\d+)+)-\d+" RPROVIDES:${PN} = "libjson" -# Required for ICECC builds -EXTRA_OECMAKE = "-DDISABLE_WERROR=ON" +# - '-Werror' must be disabled for ICECC builds +# - Apps aren't needed/packaged and their CMakeLists.txt is incompatible with CMake 4+. +EXTRA_OECMAKE = "-DDISABLE_WERROR=ON \ + -DBUILD_APPS=OFF \ +" inherit cmake ptest