MIRRORS/poky
1
0
Fork 0
mirror of git://git.yoctoproject.org/poky.git synced 2025-07-19 21:09:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

recipetool: Fix circular reference in SRC_URI

Browse Source 
When creating a new recipe.bb file for a binary, don't use BP which
includes the version information, instead use BPN which is just the
name base Package Name.

Since PB is not specified, it takes the default:
PV = "1.0+git${SRCPV}"

But SRCPV is defined in terms of the SRC_URI, which leads to infinite
recursion (traceback below). Here are the pertinent variables which
cause the recursion:

SRC_URI = "git://github.com/lvc/abi-dumper;protocol=https;subdir=${BP}"
BP = "${BPN}-${PV}"
PV = "1.0+git${SRCPV}"
SRCPV = "${@bb.fetch2.get_srcrev(d)}"

def get_srcrev(d, method_name='sortable_revision'):
    # ... trimmed
    scms = []
    fetcher = Fetch(d.getVar('SRC_URI').split(), d)
    # ... trimmed

[YOCTO #14040]

(From OE-Core rev: 3b8d43fc53ee13d39abc3b2a1f706a97fcf752aa)

Signed-off-by: Saul Wold <saul.wold@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Saul Wold 2022-02-03 11:43:48 -08:00 committed by Richard Purdie
parent 5c4a385426
commit 254fbcf614
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/lib/recipetool/create.py
View File

@ -435,7 +435,7 @@ def create_recipe(args):
if args.binary: if args.binary:
# Assume the archive contains the directory structure verbatim # Assume the archive contains the directory structure verbatim
# so we need to extract to a subdirectory # so we need to extract to a subdirectory
fetchuri += ';subdir=${BP}' fetchuri += ';subdir=${BPN}'
srcuri = fetchuri srcuri = fetchuri
rev_re = re.compile(';rev=([^;]+)') rev_re = re.compile(';rev=([^;]+)')
res = rev_re.search(srcuri) res = rev_re.search(srcuri)