mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 12:59:02 +02:00
libsoup: fix CVE-2025-2784
Refer: https://gitlab.gnome.org/GNOME/libsoup/-/issues/422 (From OE-Core rev: 504d92b01ac9a227e8e57b677f016fdfeccd5666) Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
This commit is contained in:
parent
8d4c3eb106
commit
5e4f229917
137
meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-2784.patch
Normal file
137
meta/recipes-support/libsoup/libsoup-3.4.4/CVE-2025-2784.patch
Normal file
|
@ -0,0 +1,137 @@
|
|||
From dd10ae267e33bcc35646610d7cc1841da77d05e7 Mon Sep 17 00:00:00 2001
|
||||
From: Patrick Griffis <pgriffis@igalia.com>
|
||||
Date: Wed, 5 Feb 2025 14:39:42 -0600
|
||||
Subject: [PATCH] Fix CVE-2025-2784
|
||||
|
||||
CVE: CVE-2025-2784
|
||||
Upstream-Status: Backport
|
||||
[https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/435/diffs?commit_id=242a10fbb12dbdc12d254bd8fc8669a0ac055304
|
||||
https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/442/diffs?commit_id=c415ad0b6771992e66c70edf373566c6e247089d]
|
||||
|
||||
Signed-off-by: Changqing Li <changqing.li@windriver.com>
|
||||
---
|
||||
.../content-sniffer/soup-content-sniffer.c | 10 ++--
|
||||
tests/meson.build | 4 +-
|
||||
tests/sniffing-test.c | 48 +++++++++++++++++++
|
||||
3 files changed, 56 insertions(+), 6 deletions(-)
|
||||
|
||||
diff --git a/libsoup/content-sniffer/soup-content-sniffer.c b/libsoup/content-sniffer/soup-content-sniffer.c
|
||||
index aeee2e2..a5e18d5 100644
|
||||
--- a/libsoup/content-sniffer/soup-content-sniffer.c
|
||||
+++ b/libsoup/content-sniffer/soup-content-sniffer.c
|
||||
@@ -638,8 +638,11 @@ sniff_text_or_binary (SoupContentSniffer *sniffer, GBytes *buffer)
|
||||
}
|
||||
|
||||
static gboolean
|
||||
-skip_insignificant_space (const char *resource, int *pos, int resource_length)
|
||||
+skip_insignificant_space (const char *resource, gsize *pos, gsize resource_length)
|
||||
{
|
||||
+ if (*pos >= resource_length)
|
||||
+ return TRUE;
|
||||
+
|
||||
while ((resource[*pos] == '\x09') ||
|
||||
(resource[*pos] == '\x20') ||
|
||||
(resource[*pos] == '\x0A') ||
|
||||
@@ -659,7 +662,7 @@ sniff_feed_or_html (SoupContentSniffer *sniffer, GBytes *buffer)
|
||||
gsize resource_length;
|
||||
const char *resource = g_bytes_get_data (buffer, &resource_length);
|
||||
resource_length = MIN (512, resource_length);
|
||||
- int pos = 0;
|
||||
+ gsize pos = 0;
|
||||
|
||||
if (resource_length < 3)
|
||||
goto text_html;
|
||||
@@ -669,9 +672,6 @@ sniff_feed_or_html (SoupContentSniffer *sniffer, GBytes *buffer)
|
||||
pos = 3;
|
||||
|
||||
look_for_tag:
|
||||
- if (pos > resource_length)
|
||||
- goto text_html;
|
||||
-
|
||||
if (skip_insignificant_space (resource, &pos, resource_length))
|
||||
goto text_html;
|
||||
|
||||
diff --git a/tests/meson.build b/tests/meson.build
|
||||
index 7ef7ac5..95b13b8 100644
|
||||
--- a/tests/meson.build
|
||||
+++ b/tests/meson.build
|
||||
@@ -95,7 +95,9 @@ tests = [
|
||||
{'name': 'server-auth'},
|
||||
{'name': 'server-mem-limit'},
|
||||
{'name': 'server'},
|
||||
- {'name': 'sniffing'},
|
||||
+ {'name': 'sniffing',
|
||||
+ 'depends': [test_resources],
|
||||
+ },
|
||||
{'name': 'ssl',
|
||||
'dependencies': [gnutls_dep],
|
||||
'depends': mock_pkcs11_module,
|
||||
diff --git a/tests/sniffing-test.c b/tests/sniffing-test.c
|
||||
index 6116719..7857732 100644
|
||||
--- a/tests/sniffing-test.c
|
||||
+++ b/tests/sniffing-test.c
|
||||
@@ -342,6 +342,52 @@ test_disabled (gconstpointer data)
|
||||
g_uri_unref (uri);
|
||||
}
|
||||
|
||||
+static const gsize MARKUP_LENGTH = strlen ("<!--") + strlen ("-->");
|
||||
+
|
||||
+static void
|
||||
+do_skip_whitespace_test (void)
|
||||
+{
|
||||
+ SoupContentSniffer *sniffer = soup_content_sniffer_new ();
|
||||
+ SoupMessage *msg = soup_message_new (SOUP_METHOD_GET, "http://example.org");
|
||||
+ const char *test_cases[] = {
|
||||
+ "",
|
||||
+ "<rdf:RDF",
|
||||
+ "<rdf:RDFxmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\"",
|
||||
+ "<rdf:RDFxmlns=\"http://purl.org/rss/1.0/\"",
|
||||
+ };
|
||||
+
|
||||
+ soup_message_headers_set_content_type (soup_message_get_response_headers (msg), "text/html", NULL);
|
||||
+
|
||||
+ for (guint i = 0; i < G_N_ELEMENTS (test_cases); i++) {
|
||||
+ const char *trailing_data = test_cases[i];
|
||||
+ gsize leading_zeros = 512 - MARKUP_LENGTH - strlen (trailing_data);
|
||||
+ gsize testsize = MARKUP_LENGTH + leading_zeros + strlen (trailing_data);
|
||||
+ guint8 *data = g_malloc0 (testsize);
|
||||
+ guint8 *p = data;
|
||||
+ char *content_type;
|
||||
+ GBytes *buffer;
|
||||
+
|
||||
+ // Format of <!--[0x00 * $leading_zeros]-->$trailing_data
|
||||
+ memcpy (p, "<!--", strlen ("<!--"));
|
||||
+ p += strlen ("<!--");
|
||||
+ p += leading_zeros;
|
||||
+ memcpy (p, "-->", strlen ("-->"));
|
||||
+ p += strlen ("-->");
|
||||
+ if (strlen (trailing_data))
|
||||
+ memcpy (p, trailing_data, strlen (trailing_data));
|
||||
+ // Purposefully not NUL terminated.
|
||||
+
|
||||
+ buffer = g_bytes_new_take (g_steal_pointer (&data), testsize);
|
||||
+ content_type = soup_content_sniffer_sniff (sniffer, msg, buffer, NULL);
|
||||
+
|
||||
+ g_free (content_type);
|
||||
+ g_bytes_unref (buffer);
|
||||
+ }
|
||||
+
|
||||
+ g_object_unref (msg);
|
||||
+ g_object_unref (sniffer);
|
||||
+}
|
||||
+
|
||||
int
|
||||
main (int argc, char **argv)
|
||||
{
|
||||
@@ -517,6 +563,8 @@ main (int argc, char **argv)
|
||||
"/text_or_binary/home.gif",
|
||||
test_disabled);
|
||||
|
||||
+ g_test_add_func ("/sniffing/whitespace", do_skip_whitespace_test);
|
||||
+
|
||||
ret = g_test_run ();
|
||||
|
||||
g_uri_unref (base_uri);
|
||||
--
|
||||
2.34.1
|
||||
|
|
@ -43,6 +43,7 @@ SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \
|
|||
file://CVE-2025-32050.patch \
|
||||
file://CVE-2025-46421.patch \
|
||||
file://CVE-2025-4948.patch \
|
||||
file://CVE-2025-2784.patch \
|
||||
"
|
||||
SRC_URI[sha256sum] = "291c67725f36ed90ea43efff25064b69c5a2d1981488477c05c481a3b4b0c5aa"
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user