From 8644f202a141f70e6c4bcbcd9dd3e2fd017cde0a Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Thu, 5 Jun 2025 21:11:51 +0100 Subject: [PATCH] insane: add test for recipe naming/class mismatches It's not unheard of for new users to create a recipe called foo-native that has BBCLASSEXTEND="native" instead of "inherit native". This will result in a foo-native recipe that is actually a target recipe, and a foo-native-native recipe for native builds. Add a test in recipe_qa to verify that recipes called -native inherit native, and recipes called nativesdk- inherit nativesdk. As this behaviour is expected, add the new test to the set of tests required to pass for Yocto Project Compatible status. (From OE-Core rev: ec2c10a3e85d0772135289fe416d13fa3afca571) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- meta/classes-global/insane.bbclass | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 152bef8ad5..eb8591f624 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -32,7 +32,7 @@ CHECKLAYER_REQUIRED_TESTS = "\ invalid-packageconfig la \ license-checksum license-exception license-exists license-file-missing license-format license-no-generic license-syntax \ mime mime-xdg missing-update-alternatives multilib obsolete-license \ - packages-list patch-fuzz patch-status perllocalpod perm-config perm-line perm-link \ + packages-list patch-fuzz patch-status perllocalpod perm-config perm-line perm-link recipe-naming \ pkgconfig pkgvarcheck pkgv-undefined pn-overrides shebang-size src-uri-bad symlink-to-sysroot \ unhandled-features-check unknown-configure-option unlisted-pkg-lics uppercase-pn useless-rpaths \ var-undefined virtual-slash xorg-driver-abi" @@ -1438,6 +1438,12 @@ python do_qa_unpack() { python do_recipe_qa() { import re + def test_naming(pn, d): + if pn.endswith("-native") and not bb.data.inherits_class("native", d): + oe.qa.handle_error("recipe-naming", "Recipe %s appears native but is not, should inherit native" % pn, d) + if pn.startswith("nativesdk-") and not bb.data.inherits_class("nativesdk", d): + oe.qa.handle_error("recipe-naming", "Recipe %s appears nativesdk but is not, should inherit nativesdk" % pn, d) + def test_missing_metadata(pn, d): fn = d.getVar("FILE") srcfile = d.getVar('SRC_URI').split() @@ -1482,6 +1488,7 @@ python do_recipe_qa() { oe.qa.handle_error("invalid-packageconfig", error_msg, d) pn = d.getVar('PN') + test_naming(pn, d) test_missing_metadata(pn, d) test_missing_maintainer(pn, d) test_srcuri(pn, d)