MIRRORS/poky
1
0
Fork 0
mirror of git://git.yoctoproject.org/poky.git synced 2025-07-19 12:59:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

runqemu: Remove potential lock races around tap device handling

Browse Source 
The qemu tap device handling is potentially race ridden. We pass the
fd to the main qemu subprocess which is good as it means the lock is held
as long as the qemu process exists. This means we shouldn't unlock it
ourselves though, only close the file. We also can't delete the file
as we have no idea if qemu is still using it. We could try and obtain
an exclusive new lock, then the file would be safe to unlink but it
doesn't seem worth it.

Also fix the same issue in the port lock code.

(From OE-Core rev: 2a87bddabf816d09ec801e33972879e6983627eb)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie 2021-07-07 11:08:41 +01:00
parent bdc5f4e892
commit a16d7d2ec6
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
scripts/runqemu
View File

@ -233,9 +233,12 @@ class BaseConfig(object):
def release_taplock(self):
if self.taplock_descriptor:
logger.debug("Releasing lockfile for tap device '%s'" % self.tap)
fcntl.flock(self.taplock_descriptor, fcntl.LOCK_UN)
# We pass the fd to the qemu process and if we unlock here, it would unlock for
# that too. Therefore don't unlock, just close
# fcntl.flock(self.taplock_descriptor, fcntl.LOCK_UN)
self.taplock_descriptor.close()
os.remove(self.taplock)
# Removing the file is a potential race, don't do that either
# os.remove(self.taplock)
self.taplock_descriptor = None
def check_free_port(self, host, port, lockdir):
@ -273,17 +276,23 @@ class BaseConfig(object):
def release_portlock(self, lockfile=None):
if lockfile != None:
logger.debug("Releasing lockfile '%s'" % lockfile)
fcntl.flock(self.portlocks[lockfile], fcntl.LOCK_UN)
self.portlocks[lockfile].close()
os.remove(lockfile)
del self.portlocks[lockfile]
logger.debug("Releasing lockfile '%s'" % lockfile)
# We pass the fd to the qemu process and if we unlock here, it would unlock for
# that too. Therefore don't unlock, just close
# fcntl.flock(self.portlocks[lockfile], fcntl.LOCK_UN)
self.portlocks[lockfile].close()
# Removing the file is a potential race, don't do that either
# os.remove(lockfile)
del self.portlocks[lockfile]
elif len(self.portlocks):
for lockfile, descriptor in self.portlocks.items():
logger.debug("Releasing lockfile '%s'" % lockfile)
fcntl.flock(descriptor, fcntl.LOCK_UN)
# We pass the fd to the qemu process and if we unlock here, it would unlock for
# that too. Therefore don't unlock, just close
# fcntl.flock(descriptor, fcntl.LOCK_UN)
descriptor.close()
os.remove(lockfile)
# Removing the file is a potential race, don't do that either
# os.remove(lockfile)
self.portlocks = {}
def get(self, key):