MIRRORS/poky
1
0
Fork 0
mirror of git://git.yoctoproject.org/poky.git synced 2025-07-19 21:09:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

bitbake: pyinotify: Handle potential latent bug

Browse Source 
The kernel inotify code can set more than one of the bits in the mask,
fsnotify_change() in linux/fsnotify.h is quite clear that IN_ATTRIB,
IN_MODIFY and IN_ACCESS can arrive together. We don't care about two
of these from a bitbake perspective but it probably explains why in
real world builds, we've seen:

pyinotify.ProcessEventError: Unknown mask 0x00000006

This module code assumes only one mask bit can be present. Since we
don't care about two of these events, just mask them out for now.
The "upstream" code is unmainained since 2015.

(Bitbake rev: 7fb93c2ce6dacd9b53fc3a227133a3493e6a6a1d)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie 2022-04-03 11:12:04 +01:00
parent d0082265d5
commit dfc910bdc2
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bitbake/lib/pyinotify.py
View File

@ -603,6 +603,17 @@ class _ProcessEvent:
unknown event.
"""
stripped_mask = event.mask - (event.mask & IN_ISDIR)
# Bitbake hack - we see event masks of 0x6, IN_MODIFY & IN_ATTRIB
# The kernel inotify code can set more than one of the bits in the mask,
# fsnotify_change() in linux/fsnotify.h is quite clear that IN_ATTRIB,
# IN_MODIFY and IN_ACCESS can arrive together.
# This breaks the code below which assume only one mask bit is ever
# set in an event. We don't care about attrib or access in bitbake so drop those
if (stripped_mask & IN_MODIFY) and (stripped_mask & IN_ATTRIB):
stripped_mask = stripped_mask - (stripped_mask & IN_ATTRIB)
if (stripped_mask & IN_MODIFY) and (stripped_mask & IN_ACCESS):
stripped_mask = stripped_mask - (stripped_mask & IN_ACCESS)
maskname = EventsCodes.ALL_VALUES.get(stripped_mask)
if maskname is None:
raise ProcessEventError("Unknown mask 0x%08x" % stripped_mask)