mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 21:09:03 +02:00
b090ff6a27
Python function subprocess.call() returns the return value of the executed process. If return values are not checked, errors may go unnoticed and bad things can happen. Change all callers of subprocess.call() which do not check for the return value to use subprocess.check_call() which raises CalledProcessError if the subprocess returns with non-zero value. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module All users of the function were found with: $ git grep "subprocess\.call" | \ egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call' Tested similar patch on top of yocto jethro. Only compile tested core-image-minimal on poky master branch. (From OE-Core rev: 578c8205fd14c48c6d30ef2889d86f1b4aee060a) Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
140 lines
5.0 KiB
Python
140 lines
5.0 KiB
Python
# Copyright (C) 2013 Intel Corporation
|
|
#
|
|
# Released under the MIT license (see COPYING.MIT)
|
|
|
|
# Provides a class for automating build tests for projects
|
|
|
|
import os
|
|
import re
|
|
import bb.utils
|
|
import subprocess
|
|
import tempfile
|
|
from abc import ABCMeta, abstractmethod
|
|
|
|
class BuildProject(metaclass=ABCMeta):
|
|
|
|
def __init__(self, d, uri, foldername=None, tmpdir=None):
|
|
self.d = d
|
|
self.uri = uri
|
|
self.archive = os.path.basename(uri)
|
|
if not tmpdir:
|
|
tmpdir = self.d.getVar('WORKDIR')
|
|
if not tmpdir:
|
|
tmpdir = tempfile.mkdtemp(prefix='buildproject')
|
|
self.localarchive = os.path.join(tmpdir,self.archive)
|
|
if foldername:
|
|
self.fname = foldername
|
|
else:
|
|
self.fname = re.sub(r'\.tar\.bz2$|\.tar\.gz$|\.tar\.xz$', '', self.archive)
|
|
|
|
# Download self.archive to self.localarchive
|
|
def _download_archive(self):
|
|
dl_dir = self.d.getVar("DL_DIR")
|
|
if dl_dir and os.path.exists(os.path.join(dl_dir, self.archive)):
|
|
bb.utils.copyfile(os.path.join(dl_dir, self.archive), self.localarchive)
|
|
return
|
|
|
|
exportvars = ['HTTP_PROXY', 'http_proxy',
|
|
'HTTPS_PROXY', 'https_proxy',
|
|
'FTP_PROXY', 'ftp_proxy',
|
|
'FTPS_PROXY', 'ftps_proxy',
|
|
'NO_PROXY', 'no_proxy',
|
|
'ALL_PROXY', 'all_proxy',
|
|
'SOCKS5_USER', 'SOCKS5_PASSWD']
|
|
|
|
cmd = ''
|
|
for var in exportvars:
|
|
val = self.d.getVar(var)
|
|
if val:
|
|
cmd = 'export ' + var + '=\"%s\"; %s' % (val, cmd)
|
|
|
|
cmd = cmd + "wget -O %s %s" % (self.localarchive, self.uri)
|
|
subprocess.check_output(cmd, shell=True)
|
|
|
|
# This method should provide a way to run a command in the desired environment.
|
|
@abstractmethod
|
|
def _run(self, cmd):
|
|
pass
|
|
|
|
# The timeout parameter of target.run is set to 0 to make the ssh command
|
|
# run with no timeout.
|
|
def run_configure(self, configure_args='', extra_cmds=''):
|
|
return self._run('cd %s; %s ./configure %s' % (self.targetdir, extra_cmds, configure_args))
|
|
|
|
def run_make(self, make_args=''):
|
|
return self._run('cd %s; make %s' % (self.targetdir, make_args))
|
|
|
|
def run_install(self, install_args=''):
|
|
return self._run('cd %s; make install %s' % (self.targetdir, install_args))
|
|
|
|
def clean(self):
|
|
self._run('rm -rf %s' % self.targetdir)
|
|
subprocess.check_call('rm -f %s' % self.localarchive, shell=True)
|
|
pass
|
|
|
|
class TargetBuildProject(BuildProject):
|
|
|
|
def __init__(self, target, d, uri, foldername=None):
|
|
self.target = target
|
|
self.targetdir = "~/"
|
|
BuildProject.__init__(self, d, uri, foldername)
|
|
|
|
def download_archive(self):
|
|
|
|
self._download_archive()
|
|
|
|
(status, output) = self.target.copy_to(self.localarchive, self.targetdir)
|
|
if status != 0:
|
|
raise Exception("Failed to copy archive to target, output: %s" % output)
|
|
|
|
(status, output) = self.target.run('tar xf %s%s -C %s' % (self.targetdir, self.archive, self.targetdir))
|
|
if status != 0:
|
|
raise Exception("Failed to extract archive, output: %s" % output)
|
|
|
|
#Change targetdir to project folder
|
|
self.targetdir = self.targetdir + self.fname
|
|
|
|
# The timeout parameter of target.run is set to 0 to make the ssh command
|
|
# run with no timeout.
|
|
def _run(self, cmd):
|
|
return self.target.run(cmd, 0)[0]
|
|
|
|
|
|
class SDKBuildProject(BuildProject):
|
|
|
|
def __init__(self, testpath, sdkenv, d, uri, foldername=None):
|
|
self.sdkenv = sdkenv
|
|
self.testdir = testpath
|
|
self.targetdir = testpath
|
|
bb.utils.mkdirhier(testpath)
|
|
self.datetime = d.getVar('DATETIME')
|
|
self.testlogdir = d.getVar("TEST_LOG_DIR")
|
|
bb.utils.mkdirhier(self.testlogdir)
|
|
self.logfile = os.path.join(self.testlogdir, "sdk_target_log.%s" % self.datetime)
|
|
BuildProject.__init__(self, d, uri, foldername, tmpdir=testpath)
|
|
|
|
def download_archive(self):
|
|
|
|
self._download_archive()
|
|
|
|
cmd = 'tar xf %s%s -C %s' % (self.targetdir, self.archive, self.targetdir)
|
|
subprocess.check_output(cmd, shell=True)
|
|
|
|
#Change targetdir to project folder
|
|
self.targetdir = os.path.join(self.targetdir, self.fname)
|
|
|
|
def run_configure(self, configure_args='', extra_cmds=' gnu-configize; '):
|
|
return super(SDKBuildProject, self).run_configure(configure_args=(configure_args or '$CONFIGURE_FLAGS'), extra_cmds=extra_cmds)
|
|
|
|
def run_install(self, install_args=''):
|
|
return super(SDKBuildProject, self).run_install(install_args=(install_args or "DESTDIR=%s/../install" % self.targetdir))
|
|
|
|
def log(self, msg):
|
|
if self.logfile:
|
|
with open(self.logfile, "a") as f:
|
|
f.write("%s\n" % msg)
|
|
|
|
def _run(self, cmd):
|
|
self.log("Running . %s; " % self.sdkenv + cmd)
|
|
return subprocess.check_call(". %s; " % self.sdkenv + cmd, shell=True)
|