mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 12:59:02 +02:00
2fdabc368a
The patchtest tests provide vague feedback to the user, and many of them also provide redundant 'fix' strings that could easily be incorporated into the issue messages themselves. Simplify them so that it is more clear what the errors are and how they can be addressed. No recommendation is given when the issue string adequately conveys the issue, e.g. with a missing "LICENSE" entry in a newly-created recipe. (From OE-Core rev: 0bfb3614244ec7aa79b6424bc63f9f2bccdabe98) Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
40 lines
1.4 KiB
Python
40 lines
1.4 KiB
Python
# Checks related to the patch's summary
|
|
#
|
|
# Copyright (C) 2016 Intel Corporation
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
import base
|
|
import parse_shortlog
|
|
import pyparsing
|
|
|
|
maxlength = 90
|
|
|
|
class Shortlog(base.Base):
|
|
|
|
def test_shortlog_format(self):
|
|
for commit in Shortlog.commits:
|
|
shortlog = commit.shortlog
|
|
if not shortlog.strip():
|
|
self.skip('Empty shortlog, no reason to execute shortlog format test')
|
|
else:
|
|
# no reason to re-check on revert shortlogs
|
|
if shortlog.startswith('Revert "'):
|
|
continue
|
|
try:
|
|
parse_shortlog.shortlog.parseString(shortlog)
|
|
except pyparsing.ParseException as pe:
|
|
self.fail('Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"',
|
|
commit=commit)
|
|
|
|
def test_shortlog_length(self):
|
|
for commit in Shortlog.commits:
|
|
# no reason to re-check on revert shortlogs
|
|
shortlog = commit.shortlog
|
|
if shortlog.startswith('Revert "'):
|
|
continue
|
|
l = len(shortlog)
|
|
if l > maxlength:
|
|
self.fail('Edit shortlog so that it is %d characters or less (currently %d characters)' % (maxlength, l),
|
|
commit=commit)
|