mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 12:59:02 +02:00
2fdabc368a
The patchtest tests provide vague feedback to the user, and many of them also provide redundant 'fix' strings that could easily be incorporated into the issue messages themselves. Simplify them so that it is more clear what the errors are and how they can be addressed. No recommendation is given when the issue string adequately conveys the issue, e.g. with a missing "LICENSE" entry in a newly-created recipe. (From OE-Core rev: 0bfb3614244ec7aa79b6424bc63f9f2bccdabe98) Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
26 lines
905 B
Python
26 lines
905 B
Python
# Checks related to patch line lengths
|
|
#
|
|
# Copyright (C) 2016 Intel Corporation
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
import base
|
|
import re
|
|
|
|
class MaxLength(base.Base):
|
|
add_mark = re.compile('\+ ')
|
|
max_length = 200
|
|
|
|
def test_max_line_length(self):
|
|
for patch in self.patchset:
|
|
# for the moment, we are just interested in metadata
|
|
if patch.path.endswith('.patch'):
|
|
continue
|
|
payload = str(patch)
|
|
for line in payload.splitlines():
|
|
if self.add_mark.match(line):
|
|
current_line_length = len(line[1:])
|
|
if current_line_length > self.max_length:
|
|
self.fail('Patch line too long (current length %s, maximum is %s)' % (current_line_length, self.max_length),
|
|
data=[('Patch', patch.path), ('Line', '%s ...' % line[0:80])])
|