mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 21:09:03 +02:00

Replace os.popen with subprocess.Popen since the older function would fail (more or less) silently if the executed program cannot be found There is a bb.process.run() which will invoke the Popen to run command, use it for simplify the code. For the: p4file = os.popen("%s%s files %s" % (p4cmd, p4opt, depot)) ... for file in p4file: list = file.split() in bitbake/lib/bb/fetch2/perforce.py, it should be an error in the past, since it didn't use readline() to read the pipe, but directly used the split() for the pipe. Use the bb.process.run would fix the problem since bb.process.run will return strings. More info: http://docs.python.org/library/subprocess.html#subprocess-replacements [YOCTO #2075] (Bitbake rev: 8d6700255a6d4dda403c89b171a6d4a1883e5aae) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
199 lines
6.2 KiB
Python
199 lines
6.2 KiB
Python
# ex:ts=4:sw=4:sts=4:et
|
|
# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
|
|
"""
|
|
BitBake 'Fetch' implementations
|
|
|
|
Classes for obtaining upstream sources for the
|
|
BitBake build tools.
|
|
|
|
"""
|
|
|
|
# Copyright (C) 2003, 2004 Chris Larson
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License version 2 as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with this program; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
#
|
|
# Based on functions from the base bb module, Copyright 2003 Holger Schurig
|
|
|
|
from future_builtins import zip
|
|
import os
|
|
import subprocess
|
|
import logging
|
|
import bb
|
|
from bb import data
|
|
from bb.fetch2 import FetchMethod
|
|
from bb.fetch2 import FetchError
|
|
from bb.fetch2 import logger
|
|
from bb.fetch2 import runfetchcmd
|
|
|
|
class Perforce(FetchMethod):
|
|
def supports(self, url, ud, d):
|
|
return ud.type in ['p4']
|
|
|
|
def doparse(url, d):
|
|
parm = {}
|
|
path = url.split("://")[1]
|
|
delim = path.find("@");
|
|
if delim != -1:
|
|
(user, pswd, host, port) = path.split('@')[0].split(":")
|
|
path = path.split('@')[1]
|
|
else:
|
|
(host, port) = data.getVar('P4PORT', d).split(':')
|
|
user = ""
|
|
pswd = ""
|
|
|
|
if path.find(";") != -1:
|
|
keys=[]
|
|
values=[]
|
|
plist = path.split(';')
|
|
for item in plist:
|
|
if item.count('='):
|
|
(key, value) = item.split('=')
|
|
keys.append(key)
|
|
values.append(value)
|
|
|
|
parm = dict(zip(keys, values))
|
|
path = "//" + path.split(';')[0]
|
|
host += ":%s" % (port)
|
|
parm["cset"] = Perforce.getcset(d, path, host, user, pswd, parm)
|
|
|
|
return host, path, user, pswd, parm
|
|
doparse = staticmethod(doparse)
|
|
|
|
def getcset(d, depot, host, user, pswd, parm):
|
|
p4opt = ""
|
|
if "cset" in parm:
|
|
return parm["cset"];
|
|
if user:
|
|
p4opt += " -u %s" % (user)
|
|
if pswd:
|
|
p4opt += " -P %s" % (pswd)
|
|
if host:
|
|
p4opt += " -p %s" % (host)
|
|
|
|
p4date = data.getVar("P4DATE", d, True)
|
|
if "revision" in parm:
|
|
depot += "#%s" % (parm["revision"])
|
|
elif "label" in parm:
|
|
depot += "@%s" % (parm["label"])
|
|
elif p4date:
|
|
depot += "@%s" % (p4date)
|
|
|
|
p4cmd = data.getVar('FETCHCOMMAND_p4', d, True)
|
|
logger.debug(1, "Running %s%s changes -m 1 %s", p4cmd, p4opt, depot)
|
|
p4file, errors = bb.process.run("%s%s changes -m 1 %s" % (p4cmd, p4opt, depot))
|
|
cset = p4file.strip()
|
|
logger.debug(1, "READ %s", cset)
|
|
if not cset:
|
|
return -1
|
|
|
|
return cset.split(' ')[1]
|
|
getcset = staticmethod(getcset)
|
|
|
|
def urldata_init(self, ud, d):
|
|
(host, path, user, pswd, parm) = Perforce.doparse(ud.url, d)
|
|
|
|
# If a label is specified, we use that as our filename
|
|
|
|
if "label" in parm:
|
|
ud.localfile = "%s.tar.gz" % (parm["label"])
|
|
return
|
|
|
|
base = path
|
|
which = path.find('/...')
|
|
if which != -1:
|
|
base = path[:which]
|
|
|
|
base = self._strip_leading_slashes(base)
|
|
|
|
cset = Perforce.getcset(d, path, host, user, pswd, parm)
|
|
|
|
ud.localfile = data.expand('%s+%s+%s.tar.gz' % (host, base.replace('/', '.'), cset), d)
|
|
|
|
def download(self, loc, ud, d):
|
|
"""
|
|
Fetch urls
|
|
"""
|
|
|
|
(host, depot, user, pswd, parm) = Perforce.doparse(loc, d)
|
|
|
|
if depot.find('/...') != -1:
|
|
path = depot[:depot.find('/...')]
|
|
else:
|
|
path = depot
|
|
|
|
module = parm.get('module', os.path.basename(path))
|
|
|
|
localdata = data.createCopy(d)
|
|
data.setVar('OVERRIDES', "p4:%s" % data.getVar('OVERRIDES', localdata), localdata)
|
|
data.update_data(localdata)
|
|
|
|
# Get the p4 command
|
|
p4opt = ""
|
|
if user:
|
|
p4opt += " -u %s" % (user)
|
|
|
|
if pswd:
|
|
p4opt += " -P %s" % (pswd)
|
|
|
|
if host:
|
|
p4opt += " -p %s" % (host)
|
|
|
|
p4cmd = data.getVar('FETCHCOMMAND', localdata, True)
|
|
|
|
# create temp directory
|
|
logger.debug(2, "Fetch: creating temporary directory")
|
|
bb.utils.mkdirhier(data.expand('${WORKDIR}', localdata))
|
|
data.setVar('TMPBASE', data.expand('${WORKDIR}/oep4.XXXXXX', localdata), localdata)
|
|
tmpfile, errors = bb.process.run(data.getVar('MKTEMPDIRCMD', localdata, True) or "false")
|
|
tmpfile = tmpfile.strip()
|
|
if not tmpfile:
|
|
raise FetchError("Fetch: unable to create temporary directory.. make sure 'mktemp' is in the PATH.", loc)
|
|
|
|
if "label" in parm:
|
|
depot = "%s@%s" % (depot, parm["label"])
|
|
else:
|
|
cset = Perforce.getcset(d, depot, host, user, pswd, parm)
|
|
depot = "%s@%s" % (depot, cset)
|
|
|
|
os.chdir(tmpfile)
|
|
logger.info("Fetch " + loc)
|
|
logger.info("%s%s files %s", p4cmd, p4opt, depot)
|
|
p4file, errors = bb.process.run("%s%s files %s" % (p4cmd, p4opt, depot))
|
|
p4file = p4file.strip()
|
|
|
|
if not p4file:
|
|
raise FetchError("Fetch: unable to get the P4 files from %s" % depot, loc)
|
|
|
|
count = 0
|
|
|
|
for file in p4file:
|
|
list = file.split()
|
|
|
|
if list[2] == "delete":
|
|
continue
|
|
|
|
dest = list[0][len(path)+1:]
|
|
where = dest.find("#")
|
|
|
|
subprocess.call("%s%s print -o %s/%s %s" % (p4cmd, p4opt, module, dest[:where], list[0]), shell=True)
|
|
count = count + 1
|
|
|
|
if count == 0:
|
|
logger.error()
|
|
raise FetchError("Fetch: No files gathered from the P4 fetch", loc)
|
|
|
|
runfetchcmd("tar -czf %s %s" % (ud.localpath, module), d, cleanup = [ud.localpath])
|
|
# cleanup
|
|
bb.utils.prunedir(tmpfile)
|