mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 21:09:03 +02:00
094742bed2
Replace os.popen with subprocess.Popen since the older function would
fail (more or less) silently if the executed program cannot be found
There is a bb.process.run() which will invoke the Popen to run command,
use it for simplify the code.
For the:
p4file = os.popen("%s%s files %s" % (p4cmd, p4opt, depot))
...
for file in p4file:
list = file.split()
in bitbake/lib/bb/fetch2/perforce.py, it should be an error in the past,
since it didn't use readline() to read the pipe, but directly used the
split() for the pipe. Use the bb.process.run would fix the problem since
bb.process.run will return strings.
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2075]
(Bitbake rev: 8d6700255a6d4dda403c89b171a6d4a1883e5aae)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
98 lines
3.4 KiB
Python
98 lines
3.4 KiB
Python
# ex:ts=4:sw=4:sts=4:et
|
|
# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
|
|
"""
|
|
BitBake 'Fetch' implementations
|
|
|
|
This implementation is for svk. It is based on the svn implementation
|
|
|
|
"""
|
|
|
|
# Copyright (C) 2006 Holger Hans Peter Freyther
|
|
# Copyright (C) 2003, 2004 Chris Larson
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License version 2 as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with this program; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
#
|
|
# Based on functions from the base bb module, Copyright 2003 Holger Schurig
|
|
|
|
import os
|
|
import logging
|
|
import bb
|
|
from bb import data
|
|
from bb.fetch2 import FetchMethod
|
|
from bb.fetch2 import FetchError
|
|
from bb.fetch2 import MissingParameterError
|
|
from bb.fetch2 import logger
|
|
from bb.fetch2 import runfetchcmd
|
|
|
|
class Svk(FetchMethod):
|
|
"""Class to fetch a module or modules from svk repositories"""
|
|
def supports(self, url, ud, d):
|
|
"""
|
|
Check to see if a given url can be fetched with svk.
|
|
"""
|
|
return ud.type in ['svk']
|
|
|
|
def urldata_init(self, ud, d):
|
|
|
|
if not "module" in ud.parm:
|
|
raise MissingParameterError('module', ud.url)
|
|
else:
|
|
ud.module = ud.parm["module"]
|
|
|
|
ud.revision = ud.parm.get('rev', "")
|
|
|
|
ud.localfile = data.expand('%s_%s_%s_%s_%s.tar.gz' % (ud.module.replace('/', '.'), ud.host, ud.path.replace('/', '.'), ud.revision, ud.date), d)
|
|
|
|
def need_update(self, url, ud, d):
|
|
if ud.date == "now":
|
|
return True
|
|
if not os.path.exists(ud.localpath):
|
|
return True
|
|
return False
|
|
|
|
def download(self, loc, ud, d):
|
|
"""Fetch urls"""
|
|
|
|
svkroot = ud.host + ud.path
|
|
|
|
svkcmd = "svk co -r {%s} %s/%s" % (ud.date, svkroot, ud.module)
|
|
|
|
if ud.revision:
|
|
svkcmd = "svk co -r %s %s/%s" % (ud.revision, svkroot, ud.module)
|
|
|
|
# create temp directory
|
|
localdata = data.createCopy(d)
|
|
data.update_data(localdata)
|
|
logger.debug(2, "Fetch: creating temporary directory")
|
|
bb.utils.mkdirhier(data.expand('${WORKDIR}', localdata))
|
|
data.setVar('TMPBASE', data.expand('${WORKDIR}/oesvk.XXXXXX', localdata), localdata)
|
|
tmpfile, errors = bb.process.run(data.getVar('MKTEMPDIRCMD', localdata, True) or "false")
|
|
tmpfile = tmpfile.strip()
|
|
if not tmpfile:
|
|
logger.error()
|
|
raise FetchError("Fetch: unable to create temporary directory.. make sure 'mktemp' is in the PATH.", loc)
|
|
|
|
# check out sources there
|
|
os.chdir(tmpfile)
|
|
logger.info("Fetch " + loc)
|
|
logger.debug(1, "Running %s", svkcmd)
|
|
runfetchcmd(svkcmd, d, cleanup = [tmpfile])
|
|
|
|
os.chdir(os.path.join(tmpfile, os.path.dirname(ud.module)))
|
|
# tar them up to a defined filename
|
|
runfetchcmd("tar -czf %s %s" % (ud.localpath, os.path.basename(ud.module)), d, cleanup = [ud.localpath])
|
|
|
|
# cleanup
|
|
bb.utils.prunedir(tmpfile)
|