mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 21:09:03 +02:00

OE wic plugins create temporary file with the index of the line tmp file name. This causes race in case several builds run in time. If source_params['file'] is an absolute path, the cr_workdir prefix is not applied by os.path.join(). So instead it writes to a ".1" file next to the original image - this is outside the WORKDIR and at risk of collision. (From OE-Core rev: c68d8a37ba4348fe1c0e75c63b5668187d326ec2) Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> Suggested-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Suggested-by: Paul Barker <pbarker@konsulko.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
82 lines
2.6 KiB
Python
82 lines
2.6 KiB
Python
#
|
|
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
|
|
import logging
|
|
import os
|
|
|
|
from wic import WicError
|
|
from wic.pluginbase import SourcePlugin
|
|
from wic.misc import exec_cmd, get_bitbake_var
|
|
from wic.filemap import sparse_copy
|
|
|
|
logger = logging.getLogger('wic')
|
|
|
|
class RawCopyPlugin(SourcePlugin):
|
|
"""
|
|
Populate partition content from raw image file.
|
|
"""
|
|
|
|
name = 'rawcopy'
|
|
|
|
@staticmethod
|
|
def do_image_label(fstype, dst, label):
|
|
if fstype.startswith('ext'):
|
|
cmd = 'tune2fs -L %s %s' % (label, dst)
|
|
elif fstype in ('msdos', 'vfat'):
|
|
cmd = 'dosfslabel %s %s' % (dst, label)
|
|
elif fstype == 'btrfs':
|
|
cmd = 'btrfs filesystem label %s %s' % (dst, label)
|
|
elif fstype == 'swap':
|
|
cmd = 'mkswap -L %s %s' % (label, dst)
|
|
elif fstype == 'squashfs':
|
|
raise WicError("It's not possible to update a squashfs "
|
|
"filesystem label '%s'" % (label))
|
|
else:
|
|
raise WicError("Cannot update filesystem label: "
|
|
"Unknown fstype: '%s'" % (fstype))
|
|
|
|
exec_cmd(cmd)
|
|
|
|
@classmethod
|
|
def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
|
|
oe_builddir, bootimg_dir, kernel_dir,
|
|
rootfs_dir, native_sysroot):
|
|
"""
|
|
Called to do the actual content population for a partition i.e. it
|
|
'prepares' the partition to be incorporated into the image.
|
|
"""
|
|
if not kernel_dir:
|
|
kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
|
|
if not kernel_dir:
|
|
raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")
|
|
|
|
logger.debug('Kernel dir: %s', kernel_dir)
|
|
|
|
if 'file' not in source_params:
|
|
raise WicError("No file specified")
|
|
|
|
src = os.path.join(kernel_dir, source_params['file'])
|
|
dst = os.path.join(cr_workdir, "%s.%s" % (os.path.basename(source_params['file']), part.lineno))
|
|
|
|
if not os.path.exists(os.path.dirname(dst)):
|
|
os.makedirs(os.path.dirname(dst))
|
|
|
|
if 'skip' in source_params:
|
|
sparse_copy(src, dst, skip=int(source_params['skip']))
|
|
else:
|
|
sparse_copy(src, dst)
|
|
|
|
# get the size in the right units for kickstart (kB)
|
|
du_cmd = "du -Lbks %s" % dst
|
|
out = exec_cmd(du_cmd)
|
|
filesize = int(out.split()[0])
|
|
|
|
if filesize > part.size:
|
|
part.size = filesize
|
|
|
|
if part.label:
|
|
RawCopyPlugin.do_image_label(part.fstype, dst, part.label)
|
|
|
|
part.source_file = dst
|