mirror of
git://git.yoctoproject.org/poky.git
synced 2025-07-19 12:59:02 +02:00
fd06e4f266
Various tweaks to make the test suite cleaner and more efficient: - Replace use of "re" module with "pyparsing" in tests (but not base.py) - Make test_mbox_cve only check for CVE tags in the commit if the added patch has them - Make test_mbox_cve SKIP instead of PASS if there's no CVE tag - Simplify the bugzilla tag checking test now that pyparsing is used - Modify the selftest script to correctly parse the new result output (From OE-Core rev: 7a187c2475aa762e2bc830950f608143f2535a72) Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
52 lines
2.2 KiB
Python
52 lines
2.2 KiB
Python
# Checks related to the patch's CVE lines
|
|
#
|
|
# Copyright (C) 2016 Intel Corporation
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License version 2 as
|
|
# published by the Free Software Foundation.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with this program; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
import base
|
|
import os
|
|
import parse_cve_tags
|
|
import pyparsing
|
|
|
|
class CVE(base.Base):
|
|
|
|
revert_shortlog_regex = pyparsing.Regex('Revert\s+".*"')
|
|
prog = parse_cve_tags.cve_tag
|
|
patch_prog = parse_cve_tags.patch_cve_tag
|
|
|
|
def setUp(self):
|
|
if self.unidiff_parse_error:
|
|
self.skip('Parse error %s' % self.unidiff_parse_error)
|
|
|
|
# we are just interested in series that introduce CVE patches, thus discard other
|
|
# possibilities: modification to current CVEs, patch directly introduced into the
|
|
# recipe, upgrades already including the CVE, etc.
|
|
new_patches = [p for p in self.patchset if p.path.endswith('.patch') and p.is_added_file]
|
|
if not new_patches:
|
|
self.skip('No new patches introduced')
|
|
|
|
def test_cve_presence_in_commit_message(self):
|
|
for commit in CVE.commits:
|
|
# skip those patches that revert older commits, these do not required the tag presence
|
|
if self.revert_shortlog_regex.search_string(commit.shortlog):
|
|
continue
|
|
if not self.patch_prog.search_string(commit.payload):
|
|
self.skip("No CVE tag in added patch, so not needed in mbox")
|
|
elif not self.prog.search_string(commit.payload):
|
|
self.fail('Missing or incorrectly formatted CVE tag in mbox. Correct or include the CVE tag in the mbox with format: "CVE: CVE-YYYY-XXXX"',
|
|
commit=commit)
|