From 0a815f40329e735a4fb36f68c993be82bbb2076d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexis=20Lothor=C3=A9?= Date: Mon, 13 Mar 2023 15:51:40 +0100 Subject: [PATCH] scripts/send-qa-email: invert boolean logic for release check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit is_non_release_version has an inverted logic which makes its reuse quite confusing Transform it as is_release_version and let caller do the negation if needed Signed-off-by: Alexis Lothoré Signed-off-by: Richard Purdie --- scripts/send_qa_email.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/send_qa_email.py b/scripts/send_qa_email.py index 96225a8..320ff24 100755 --- a/scripts/send_qa_email.py +++ b/scripts/send_qa_email.py @@ -14,15 +14,15 @@ import re import utils -def is_non_release_version(version): +def is_release_version(version): p = re.compile('\d{8}-\d+') - return p.match(version) is not None + return p.match(version) is None def get_previous_tag(targetrepodir, version): previousversion = None previousmilestone = None if version: - if is_non_release_version(version): + if not is_release_version(version): return subprocess.check_output(["git", "describe", "--abbrev=0"], cwd=targetrepodir).decode('utf-8').strip() compareversion, comparemilestone, _ = utils.get_version_from_string(version) compareversionminor = compareversion[-1]