Michael Halstead has confirmed this.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Since https://lists.yoctoproject.org/g/yocto/message/50282 was merged in
autoupgrade-helper git repo, the python script isn't called
upgradehelper.py anymore but upgrade-helper.py for consistency sake.
Let's update the run-auh script so that it's still working.
Signed-off-by: Quentin Schulz <foss@0leil.net>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sadly, many maintainers do not act on AUH mails in a timely manner
(or do not act at all). Sending these emails to oe-core list as well
will allow other people to pick them up, and ease up the path
to doing recipe version maintenance.
Also, recently the amount of outdate recipes has been greatly reduced,
so there should not be too many of those emails each month.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
On stable release branch builds, it will clone "master" since comparebranch
is None. It will then fail to push since there is already a dunfell
branch upstream with changes on which it needs to rebase on top of.
The change to use shallow clones significantly increases this problem.
To fix this, fall back to cloning basebranch by name, then master
if it doesn't exist.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The existing checksum files were encoding full paths. This patch changes
this to use just the filename which allows relocation of the directories
and is more appropriate for sharing over http.
Signed-off-by: Vineela Tummalapalli <vineela.tummalapalli@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This allows automating its setup and execution on all autobuilder worker machines;
previously there was a static setup on a dedicated machine, which wasn't
great from maintenance perspective.
To use:
scripts/setup-auh target_dir
scripts/run-auh target_dir
(run-auh can be run several times in a directory that
was previously set up)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We were mistakenly doing a force push if the branch was in either
BUILD_HISTORY_FORKPUSH or BUILD_HISTORY_DIRECTPUSH.
Now we force push for branches in BUILD_HISTORY_FORKPUSH, regular push
for branches in BUILD_HISTORY_DIRECTPUSH, and no push if the branch is
in neither list.
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This code was copy/pasted but in this case the variables should
be called "compare", not base.
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The buildtools path contains "../" which may not resolve correctly by the
shell if the final directory doesn't exist. Avoid this by using abspath()
on the expression straightaway.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Allow the workername to be passed into the script. This is to allow future
buildtools tarball support based upon the worker.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This fixes failures on the buildperf workers which do early cleanup of build
directories.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There are several issues:
* New branches don't currently have git regression history
* The regression tool errors if there isn't anything to compare against
To fix this, create a branch with history and only generate a regression
report if there are commits to compare against.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The previous fixes requires the user to set "no-layer-add"
for a repo and then use ADDLAYER to insert the sub-repos
(e.g., meta-openmbedded/meta-oe) as a two-part process.
This means that you would also have to specify that flag
if a repo that is a layer with dependencies is in the
list so that it can be inserted in the correct order later
via ADDLAYER to avoid parsing problems. This fix allows
for specifying a NEEDREPOS with the subdirectory of the
target layer (e.g., meta-openembedded/meta-oe) so that
there is no need for the "no-layer-add" followed by
ADDLAYER combination. The entire meta-openembedded
repo would be moved into place, and the sublayer added
to bblayers.conf.
Signed-off-by: Thomas Goodwin <btgoodwin@geontech.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The preceeding errors that would be shown should be enough to
identify the problem since it would have been a problem
running bitbake-layers add-layer, indicating a misconfiguration
of config.json.
Signed-off-by: Thomas Goodwin <btgoodwin@geontech.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The return value from bitbakecmd was not being returned when
errors occurred which allowed shared-repo-unpack to succeed
despite the failure. This fix changes to check_call and a
try-catch when attempting to add repos that fail for whatever
reason during add-layer, like a missing conf/layer.conf at
the top level or a previously-added layer breaks parsing
because of missing dependencies.
Signed-off-by: Thomas Goodwin <btgoodwin@geontech.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Affects sumo since that doesn't have oe-selftest parallelism. thud/master create
these in a different location so don't see the issue.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Since we now have functional buildhistory repository functionality,
generate buildhistory-diff output for builds where its enabled.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently there was no way to override an existing extra vars
assignment, which meant BB_NUMBER_THREADS was impossible to change.
This adds code to allow the higher override of a value to override
the other settings which makes the code function more as a user
would expect.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently it was being placed a directory level too high and hence
was being ignored.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This ensures that release branch performance build tests work on the correct
branch and that comparisions between mut+master and master-next+master
start to work correctly. It also ensures reports for the current
revision are generated even if later revisions are built.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The shell script can't access the config.json data easily, convert
from shell to python so that we prepare the way for further enhancements.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This makes the build performance code behave similarly to the other
results publishing code using the standard location.
Also tweak the report names so they sort.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We need the final logging to show which command steps contain errors so print
failing commands but allow the code to continue and show the final log output.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This ensures the builds get as far as they can when there is failure rather
that stopping at the first sign of one. This means caches are hotter and
allows for faster respins, at the cost of the failure being lost in longer
logs.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This should further protect us against contamination between different build directories
as old build directory paths should no longer exist.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There is no current mechanism to reference the 'builddir' within the config.json,
so add HELPERBUILDDIR for this purpose.
Use this to set SSTATEDIR for nightly-bringup, meaning sstate arefacts should be
shared for use between the different oe-selftest threads, speeding up builds.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The SSTATEDIR was accidentally using getconfiglist instead of getconfigvar which
meant it couldn't be unset. Fix to use var so the values in config.json work
as intended.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Many of the distros we use have sendmail in /sbin or /usr/sbin
which may not be in the path for non-interactive users. Handle
this in the script to avoid failures where tests work but the
real QA email fails.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add in the support to publish images into the designated path.
BSP packages of the previous build will be cleaned up before
new BSP packages are copied over. This ensures the previous
image will not be retained and causes conflicts before image
is loaded into x86_64 (MTURBOT64) hardware.
Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[RP: Minor tweaks made to adpat to buildbot and option naming
Fixed shared-repo-unpack for publishing when no cache-dir supplied]
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The new buildbot code can directly monitor the logfiles itself so
we need to be able to optionally stop echoing onto the console.
Add missing flush() calls and print the command being used and logfile
so its clear what is happening on stdout too.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This patch fixes the "Collection Error during parsing layer conf"
when a parent layer is accidentally added before depend layers.
When removing layers from bblayers, we should not be following
the same sequence of adding the layers, it should be done in a
reversed order. This is an assumption that the layers have their
dependent layers added before the parent layers are added.
In general, the parent layer require to be remove first before
its child dependencies layers.
Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Testing this code is becoming increasingly problematic. This allows
ABHELPERTEST to be set from the environment and means the script will
still create directories and configuration files but it will not execute
anything, just print what would be executed.
This allows faster validation of changes to the configurations/code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Remove the code disabling it
* Move to a non-shared directory by default (but still support absolute pathnames
if wanted)
* Use shallow clones by default for speed
* Allow force pushing 'fork' mode branches
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Usage is documented in README and an example, local-example.json is
included.
Also clean up the parameter to loadconfig() as its actually not needed.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We want to be able to use data expansion/variable substitution
in most variables so convert to use the utils API for this.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The code clearly won't scale without some kind of variable substitution/
variable expansion mechanism, so add one.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This means making the configuration generation conditional, the error
reporting conditional and allowing non bitbake commands.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
tee hides the exit code of the pipeline. Instead use subprocess to write out the logfile.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
As the mv commands use a filename wildcard we need to tell check_call to
execute through the shell so that the wildcard is expanded, rather than
treat as a file name.
Signed-off-by: Joshua Lock <joshua.g.lock@intel.com>
