From a232d2c032ef09759d3454f261a08e21bbc7048a Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Sun, 29 Nov 2020 11:01:59 +0000 Subject: [PATCH] yocto_console_view: Fix mystery performance problem We were pushing duplicate builder values into changes list which was causing angular to get rather upset, triggering console warnings and heavy CPU usage. Stop doing that. Also drop the pointless return value. Signed-off-by: Richard Purdie --- yocto_console_view/src/module/main.module.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/yocto_console_view/src/module/main.module.js b/yocto_console_view/src/module/main.module.js index f65828c..7c2fcd1 100644 --- a/yocto_console_view/src/module/main.module.js +++ b/yocto_console_view/src/module/main.module.js @@ -465,7 +465,9 @@ class Console { change.caption = rev; } - return change.buildersById[build.builderid].builds.push(build); + if (change.buildersById[build.builderid].builds.indexOf(build) == -1) { + change.buildersById[build.builderid].builds.push(build); + } } makeFakeChange(revision, when_timestamp, comments) {