This was changed compared to the upstream console view code due to bugs in our
own changes code. Those are now fixed so revert to the upstream version allowing
these data structures to persist and not always be reset.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Where we inject a "fake" change, we then never update the list of builders it
contains. This leads to bugs in the UI rendering since the builders list
might not be the accurate in early calls to the onChange function.
Keep track of fake changes and update those too so the builders list
is maintained.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If a field doesn't exist in the current build, allow the selector to still work
(e.g. meta-arm branch in a-quick).
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We were pushing duplicate builder values into changes list which was causing
angular to get rather upset, triggering console warnings and heavy CPU usage.
Stop doing that. Also drop the pointless return value.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The logic in the function was odd, we need to trigger onChange if we update
any values. The return values are also pointless. Fix and clean up the code
logic accordingly.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Our plugin is based on upstream buildbot's console plugin. Upstream moved
away from coffescript and made a number of other fixes and improvements.
Run decaffeinate on the coffeescript to translate to angularjs and then
convert to the new build environment and standards.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The previous approach was basically repeatedly adding change nofification
calls recursively which could lock up the browser. It turns out nofitications
are not being generated properly in upstream buildbot.
https://github.com/buildbot/buildbot/issues/4321https://github.com/buildbot/buildbot/pull/4323
For now accept a UI regression which will get fixed when the above is
fixed. Avoid the current performance problems.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This corresponds to the poky branch being used by default so its easier
for users to tell the builds apart and know which ones they are.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
