mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-09-02 18:06:13 +02:00

Masahiro Yamada 5c8166419a kbuild: replace $(if A,A,B) with $(or A,B)

$(or ...) is available since GNU Make 3.81, and useful to shorten the
code in some places.

Covert as follows:

  $(if A,A,B)  -->  $(or A,B)

This patch also converts:

  $(if A, A, B) --> $(or A, B)

Strictly speaking, the latter is not an equivalent conversion because
GNU Make keeps spaces after commas; if A is not empty, $(if A, A, B)
expands to " A", while $(or A, B) expands to "A".

Anyway, preceding spaces are not significant in the code hunks I touched.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

2022-02-15 12:25:56 +09:00

2.4 KiB

Raw Permalink Blame History

SPDX-License-Identifier: GPL-2.0

include ../scripts/Makefile.include

bindir ?= /usr/bin

This will work when gpio is built in tools env. where srctree

isn't set and when invoked from selftests build, where srctree

is set to ".". building_out_of_srctree is undefined for in srctree

builds

ifndef building_out_of_srctree srctree := $(patsubst %/,%,$(dir $(CURDIR))) srctree := $(patsubst %/,%,$(dir $(srctree))) endif

Do not use make's built-in rules

(this improves performance and avoids hard-to-debug behaviour);

MAKEFLAGS += -r

override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include

ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon gpio-watch ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))

all: $(ALL_PROGRAMS)

export srctree OUTPUT CC LD CFLAGS include $(srctree)/tools/build/Makefile.include

We need the following to be outside of kernel tree

$(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h mkdir -p $(OUTPUT)include/linux 2>&1 || true ln -sf $(CURDIR)/../../include/uapi/linux/gpio.h $@

prepare: $(OUTPUT)include/linux/gpio.h

GPIO_UTILS_IN := $(OUTPUT)gpio-utils-in.o $(GPIO_UTILS_IN): prepare FORCE $(Q)$(MAKE) $(build)=gpio-utils

lsgpio

LSGPIO_IN := $(OUTPUT)lsgpio-in.o $(LSGPIO_IN): prepare FORCE $(OUTPUT)gpio-utils-in.o $(Q)$(MAKE) $(build)=lsgpio $(OUTPUT)lsgpio: $(LSGPIO_IN) $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@

gpio-hammer

GPIO_HAMMER_IN := $(OUTPUT)gpio-hammer-in.o $(GPIO_HAMMER_IN): prepare FORCE $(OUTPUT)gpio-utils-in.o $(Q)$(MAKE) $(build)=gpio-hammer $(OUTPUT)gpio-hammer: $(GPIO_HAMMER_IN) $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@

gpio-event-mon

GPIO_EVENT_MON_IN := $(OUTPUT)gpio-event-mon-in.o $(GPIO_EVENT_MON_IN): prepare FORCE $(OUTPUT)gpio-utils-in.o $(Q)$(MAKE) $(build)=gpio-event-mon $(OUTPUT)gpio-event-mon: $(GPIO_EVENT_MON_IN) $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@

gpio-watch

GPIO_WATCH_IN := $(OUTPUT)gpio-watch-in.o $(GPIO_WATCH_IN): prepare FORCE $(Q)$(MAKE) $(build)=gpio-watch $(OUTPUT)gpio-watch: $(GPIO_WATCH_IN) $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@

clean: rm -f $(ALL_PROGRAMS) rm -f $(OUTPUT)include/linux/gpio.h find $(or $(OUTPUT),.) -name '.o' -delete -o -name '..d' -delete

install: $(ALL_PROGRAMS) install -d -m 755 $(DESTDIR)$(bindir);
for program in $(ALL_PROGRAMS); do
install $$program $(DESTDIR)$(bindir);
done

FORCE:

.PHONY: all install clean FORCE prepare

2.4 KiB Raw Permalink Blame History