a0769f25a3
When a symbol is selected that has extra dependencies,
anything that selects it must have the same dependencies.
With the added CONFIG_DRM reference from I2C_HID_CORE,
this broke a couple of drivers that now also depend
on DRM:
WARNING: unmet direct dependencies detected for I2C_HID_CORE
Depends on [m]: HID_SUPPORT [=y] && I2C_HID [=y] && (DRM [=m] || !DRM [=m])
Selected by [y]:
- I2C_HID_OF [=y] && HID_SUPPORT [=y] && I2C_HID [=y]
- I2C_HID_ACPI [=y] && HID_SUPPORT [=y] && I2C_HID [=y] && ACPI [=y]
- I2C_HID_OF_GOODIX [=y] && HID_SUPPORT [=y] && I2C_HID [=y] && OF [=y]
x86_64-linux-ld: vmlinux.o: in function `i2c_hid_core_remove':
(.text+0xfc8826): undefined reference to `drm_panel_remove_follower'
x86_64-linux-ld: vmlinux.o: in function `i2c_hid_core_probe':
(.text+0xfc8da0): undefined reference to `drm_is_panel_follower'
Add the corresponding DRM||!DRM dependencies on each one that
is affected.
Fixes: 96a37bfd23 ("HID: i2c-hid: Support being a panel follower")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230802124947.1355415-1-arnd@kernel.org
2.4 KiB
SPDX-License-Identifier: GPL-2.0-only
menuconfig I2C_HID tristate "I2C HID support" default y depends on I2C && INPUT && HID
if I2C_HID
config I2C_HID_ACPI tristate "HID over I2C transport layer ACPI driver" depends on ACPI depends on DRM || !DRM select I2C_HID_CORE help Say Y here if you use a keyboard, a touchpad, a touchscreen, or any other HID based devices which is connected to your computer via I2C. This driver supports ACPI-based systems.
If unsure, say N.
This support is also available as a module. If so, the module
will be called i2c-hid-acpi. It will also build/depend on the
module i2c-hid.
config I2C_HID_OF tristate "HID over I2C transport layer Open Firmware driver" # No "depends on OF" because this can also be used for manually # (board-file) instantiated "hid-over-i2c" type i2c-clients. depends on DRM || !DRM select I2C_HID_CORE help Say Y here if you use a keyboard, a touchpad, a touchscreen, or any other HID based devices which is connected to your computer via I2C. This driver supports Open Firmware (Device Tree)-based systems as well as binding to manually (board-file) instantiated i2c-hid-clients.
If unsure, say N.
This support is also available as a module. If so, the module
will be called i2c-hid-of. It will also build/depend on the
module i2c-hid.
config I2C_HID_OF_ELAN tristate "Driver for Elan hid-i2c based devices on OF systems" depends on OF depends on DRM || !DRM select I2C_HID_CORE help Say Y here if you want support for Elan i2c devices that use the i2c-hid protocol on Open Firmware (Device Tree)-based systems.
If unsure, say N.
This support is also available as a module. If so, the module
will be called i2c-hid-of-elan. It will also build/depend on
the module i2c-hid.
config I2C_HID_OF_GOODIX tristate "Driver for Goodix hid-i2c based devices on OF systems" depends on OF depends on DRM || !DRM select I2C_HID_CORE help Say Y here if you want support for Goodix i2c devices that use the i2c-hid protocol on Open Firmware (Device Tree)-based systems.
If unsure, say N.
This support is also available as a module. If so, the module
will be called i2c-hid-of-goodix. It will also build/depend on
the module i2c-hid.
config I2C_HID_CORE tristate # We need to call into panel code so if DRM=m, this can't be 'y' depends on DRM || !DRM endif