
Build breaks when executing make with run_tests for sub-folders under powerpc. This is because, CFLAGS and GIT_VERSION macros are defined in Makefile of toplevel powerpc folder. make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/mm' gcc hugetlb_vs_thp_test.c ../harness.c ../utils.c -o /home/maddy/selftest_output//hugetlb_vs_thp_test hugetlb_vs_thp_test.c:6:10: fatal error: utils.h: No such file or directory 6 | #include "utils.h" | ^~~~~~~~~ compilation terminated. Fix this by adding the flags.mk in each sub-folder Makefile. Also remove the CFLAGS and GIT_VERSION macros from powerpc/ folder Makefile since the same is definied in flags.mk Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20240229093711.581230-3-maddy@linux.ibm.com
2.0 KiB
SPDX-License-Identifier: GPL-2.0
TEST_GEN_PROGS := copyuser_64_t0 copyuser_64_t1 copyuser_64_t2
copyuser_p7_t0 copyuser_p7_t1
memcpy_64_t0 memcpy_64_t1 memcpy_64_t2
memcpy_p7_t0 memcpy_p7_t1 copy_mc_64
copyuser_64_exc_t0 copyuser_64_exc_t1 copyuser_64_exc_t2
memmove_64
EXTRA_SOURCES := validate.c ../harness.c stubs.S
top_srcdir = ../../../../.. include ../../lib.mk include ../flags.mk
The loops are all 64-bit code
CFLAGS += -m64 CFLAGS += -I$(CURDIR) CFLAGS += -D SELFTEST CFLAGS += -maltivec CFLAGS += -mcpu=power4
Use our CFLAGS for the implicit .S rule & set the asm machine type
ASFLAGS = $(CFLAGS) -Wa,-mpower4
$(OUTPUT)/copyuser_64_t%: copyuser_64.S $(EXTRA_SOURCES)
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test___copy_tofrom_user_base
-D SELFTEST_CASE=$(subst copyuser_64_t,,$(notdir $@))
-o $@ $^
$(OUTPUT)/copyuser_p7_t%: copyuser_power7.S $(EXTRA_SOURCES)
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test___copy_tofrom_user_power7
-D SELFTEST_CASE=$(subst copyuser_p7_t,,$(notdir $@))
-o $@ $^
Strictly speaking, we only need the memcpy_64 test cases for big-endian
$(OUTPUT)/memcpy_64_t%: memcpy_64.S $(EXTRA_SOURCES)
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test_memcpy
-D SELFTEST_CASE=$(subst memcpy_64_t,,$(notdir $@))
-o $@ $^
$(OUTPUT)/memcpy_p7_t%: memcpy_power7.S $(EXTRA_SOURCES)
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test_memcpy_power7
-D SELFTEST_CASE=$(subst memcpy_p7_t,,$(notdir $@))
-o $@ $^
$(OUTPUT)/copy_mc_64: copy_mc_64.S $(EXTRA_SOURCES)
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test_copy_mc_generic
-o $@ $^
$(OUTPUT)/copyuser_64_exc_t%: copyuser_64.S exc_validate.c ../harness.c
copy_tofrom_user_reference.S stubs.S
$(CC) $(CPPFLAGS) $(CFLAGS)
-D COPY_LOOP=test___copy_tofrom_user_base
-D SELFTEST_CASE=$(subst copyuser_64_exc_t,,$(notdir $@))
-o $@ $^
$(OUTPUT)/memmove_64: mem_64.S memcpy_64.S memmove_validate.c ../harness.c
memcpy_stubs.S
$(CC) $(CPPFLAGS) $(CFLAGS)
-D TEST_MEMMOVE=test_memmove
-o $@ $^